On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote: > The reason that's not good is that it creates a singular-plural mismatch. > If you'd also changed "PathKeys" to "PathKey", it would still read OK, > though I don't think it's an improvement particularly. > > (Hm ... though arguably, "structure" should be "structures" if we're > going to let it stand as plural.)
Indeed, missed that. This first sentence mentions "orderings" for those PathKeys, which refers to multiple PathKeys, so actually Amit's patch seems to be fine, no? -- Michael
signature.asc
Description: PGP signature
