On 2 March 2018 at 07:17, Jesper Pedersen wrote:
> A small typo in 0001:
>
> + * leftmost_ons_pos[x] gives the bit number (0-7) of the leftmost one bit
> in a
>
> ..."_one_"...
Oops. I'll fix that.
> 0004 fails "make check-world" due to
>
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
On 2018-01-17 09:03:51 -0500, Peter Eisentraut wrote:
> Graham, will you be able to respond to my questions or provide an
> updated patch within the next week or so?
Given that nothing has happend since, I've marked this as returned with
feedback.
Greetings,
Andres Freund
Hi Alexander,
On 2/27/18 5:05 AM, Aleksander Alekseev wrote:
Hello David,
Just a few days left until the last Commitfest for the PG11 release begins!
I'm planning to fill the CFM role, unless there are objections.
Thank you for volunteering!
I would like to be CFM assistant, if you need on
>
>
> - new plpgsql extra_checks
>
> WOA, but recently set to that status. Patch essentially from
> 2017-01-11.
>
> I'm not really sure there's agreement we want this.
>
>
This patch is simple and has benefit for users with basic plpgsql skills,
and some for all.
In more complex cases, proba
Hi,
On 2018-02-27 15:52:32 -0500, David Steele wrote:
> Thanks for having a look at the patches.
I'd personally appreciate if you'd add commit messages to the individual
patches in a series. A brief explanation why something is done is good
enough. E.g. here it's far from obvious why something i
Hi,
On 2018-01-26 23:30:08 +0100, Daniel Gustafsson wrote:
> And another rebase and update after the refactoring in c1869542b3a4da4b12ca.
> Also fixed some typos in comments. The other patches originally posted in
> this
> patchset are either committed or made redundant.
Could you provide a qui
On 2 March 2018 at 08:13, Robert Haas wrote:
> I don't like the comments at the top of partprune.c very much. It
> seems strange to document individual functions here; those functions
> can (and should) be documented in their individual header comments.
> What we should have at the top of the fil
2018-03-01 23:10 GMT+01:00 Andres Freund :
> On 2018-01-23 17:08:56 +0100, Pavel Stehule wrote:
> > 2018-01-22 23:15 GMT+01:00 Stephen Frost :
> > > This really could use a new thread, imv. This thread is a year old and
> > > about a completely different feature than what you've implemented here.
> On 02 Mar 2018, at 10:10, Andres Freund wrote:
>
> On 2018-01-26 23:30:08 +0100, Daniel Gustafsson wrote:
>> And another rebase and update after the refactoring in c1869542b3a4da4b12ca.
>> Also fixed some typos in comments. The other patches originally posted in
>> this
>> patchset are either
Hi Andres,
On 3/1/18 9:04 PM, Andres Freund wrote:
On 2018-02-27 15:52:32 -0500, David Steele wrote:
Thanks for having a look at the patches.
I'd personally appreciate if you'd add commit messages to the individual
patches in a series. A brief explanation why something is done is good
enough.
On 03/02/2018 02:12 AM, Andres Freund wrote:
> On 2018-02-01 23:51:55 +0100, Tomas Vondra wrote:
>> On 02/01/2018 03:51 PM, Peter Eisentraut wrote:
>>> To close out this commit fest, I'm setting both of these patches as
>>> returned with feedback, as there are apparently significant issues to be
>>
On 2018-03-02 03:13:04 +0100, Pavel Stehule wrote:
> 2018-03-01 23:10 GMT+01:00 Andres Freund :
>
> > On 2018-01-23 17:08:56 +0100, Pavel Stehule wrote:
> > > 2018-01-22 23:15 GMT+01:00 Stephen Frost :
> > > > This really could use a new thread, imv. This thread is a year old and
> > > > about a
Hi Tomas.
On 3/1/18 9:33 PM, Tomas Vondra wrote:
On 03/02/2018 02:12 AM, Andres Freund wrote:
On 2018-02-01 23:51:55 +0100, Tomas Vondra wrote:
On 02/01/2018 03:51 PM, Peter Eisentraut wrote:
To close out this commit fest, I'm setting both of these patches as
returned with feedback, as there
On Fri, Mar 2, 2018 at 2:42 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Thu, Mar 1, 2018 at 5:09 PM, Amit Kapila
> wrote:
>
>> Preliminary performance results
>> ---
>>
>> *We’ve shown the performance improvement of zheap over heap in a
2018-03-02 3:38 GMT+01:00 Andres Freund :
> On 2018-03-02 03:13:04 +0100, Pavel Stehule wrote:
> > 2018-03-01 23:10 GMT+01:00 Andres Freund :
> >
> > > On 2018-01-23 17:08:56 +0100, Pavel Stehule wrote:
> > > > 2018-01-22 23:15 GMT+01:00 Stephen Frost :
> > > > > This really could use a new thread
Hi,
On 2018-02-07 16:46:38 +0100, Emre Hasegeli wrote:
> I am incorporating the fix you have posted to the other thread to this patch.
You've not posted a version fixing the issues in the surrounding thread,
do I see that right?
I'm a bit confused how this patch has gone through several revision
Hi,
Based on this sub-thread this patch's status of 'needs review' doesn't
quite seem accurate and 'waiting on author' and then 'returned with
feedback' would be more fitting?
Greetings,
Andres Freund
On 2017-11-29 17:56:30 +0300, Victor Drobny wrote:
> Thank you for review. I have tried to fix all of your comments.
> However i want to mention that the absence of comments for functions
> in to_tsany.c is justified by the absence of comments for other
> similar functions.
That's not justificatio
Hi!
On 2018-03-02 02:29:13 +0900, Fujii Masao wrote:
> On Fri, Feb 2, 2018 at 2:06 PM, Michael Paquier
> wrote:
> > On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
> >> The patch basically looks good to me. Here are some small comments.
> >>
> >>
> >> The backup history fil
Hi,
On 2018-02-24 23:01:59 +0100, Tomas Vondra wrote:
> Sadly, this patch series does not seem to move forward very much, and
> I'm not sure how to change that :-/
What's your estimate about the patchset's maturity?
Greetings,
Andres Freund
Quite simply:
d1=# create table bp (b bool) partition by list(b);
CREATE TABLE
d1=# create table bp_f partition of bp for values in('f');
CREATE TABLE
d1=# \q
$ createdb d2
$ pg_dump d1 | psql d2
...
ERROR: syntax error at or near "false"
LINE 2: FOR VALUES IN (false);
^
I think it was impolite to post this on the very same day the commitfest
started. We have enough patches as it is ...
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hi,
On 2018-02-25 01:30:47 +0100, Tomas Vondra wrote:
> Note: Currently, this only works with float8-based data types.
> Supporting additional data types is not a big issue, but will
> require extending the opclass with "subtract" operator (used to
> compute distance between values when merging ra
On Fri, Mar 2, 2018 at 3:57 PM, Andres Freund wrote:
> Based on this sub-thread this patch's status of 'needs review' doesn't
> quite seem accurate and 'waiting on author' and then 'returned with
> feedback' would be more fitting?
I personally think this patch is really close to RFC. Shubham has
On 02/03/18 16:53, Alvaro Herrera wrote:
I think it was impolite to post this on the very same day the commitfest
started. We have enough patches as it is ...
To be fair - he did say things like "wanting feedback..." and "shows an
example of using pluggable storage.." and for PG 12. If he h
On Thu, Mar 01, 2018 at 02:54:22PM -0300, Alvaro Herrera wrote:
> Tom Lane wrote:
>> Actually, this patch still wasn't quite right: although it fixed
>> one aspect of the behavior, it still produced identical results
>> for typemod NULL and typemod -1, which as the function's comment
>> explains is
On Fri, Mar 02, 2018 at 02:29:13AM +0900, Fujii Masao wrote:
> + * write a backup history file with the same name.
>
> So more than one backup history files with the same name
> but the diffferent content can be created and archived.
> Isn't this problematic because the backup history file that
>
Andres Freund writes:
> On 2018-02-25 01:30:47 +0100, Tomas Vondra wrote:
>> Note: Currently, this only works with float8-based data types.
>> Supporting additional data types is not a big issue, but will
>> require extending the opclass with "subtract" operator (used to
>> compute distance betwee
On Thu, Mar 01, 2018 at 07:26:09PM -0800, Andres Freund wrote:
> On 2018-03-02 02:29:13 +0900, Fujii Masao wrote:
>> + * write a backup history file with the same name.
>>
>> So more than one backup history files with the same name
>> but the diffferent content can be created and archived.
>> Isn'
Hi,
On 2018-01-09 08:21:33 +, Tsunakawa, Takayuki wrote:
> From: Simon Riggs [mailto:si...@2ndquadrant.com]
> > When will the next version be posted?
>
> I'm very sorry I haven't submitted anything. I'd like to address this during
> this CF. Thanks for remembering this.
Given that no new
On Thu, Mar 01, 2018 at 09:12:18AM +0800, Craig Ringer wrote:
> On 1 March 2018 at 06:28, Justin Pryzby wrote:
> > The more fine grained these are the more useful they can be:
> >
> > Running with fsync=off is common advice while loading, so reporting that
> > "fsync=off at some point" is much les
On 3/1/18 11:07 PM, Michael Paquier wrote:
> On Fri, Mar 02, 2018 at 02:29:13AM +0900, Fujii Masao wrote:
>> + * write a backup history file with the same name.
>>
>> So more than one backup history files with the same name
>> but the diffferent content can be created and archived.
>> Isn't this pr
On Thu, Mar 01, 2018 at 09:32:58PM -0500, David Steele wrote:
> On 3/1/18 9:04 PM, Andres Freund wrote:
>> I'd suggest just using git format-patch -v to format series.
>
> Sure, I've been meaning to switch over to this format and just haven't
> gotten around to it yet. I do recognize the value, h
Hi Andres and Craig,
>> In the future you should number them. Right now they appear to be out of
>> order in your email. I suggest using git format-patch, that does all
>> the necessary work for you.
>>
> Yep, specially git format-patch with a -v argument, so the whole patchset is
> visibly versi
Hi,
On 2018-02-07 19:28:29 +0300, Arthur Zakirov wrote:
> + {
> + {"max_shared_dictionaries_size", PGC_POSTMASTER, RESOURCES_MEM,
> + gettext_noop("Sets the maximum size of all text search
> dictionaries loaded into shared memory."),
> + get
On 2018-03-01 14:45:15 -0800, Andres Freund wrote:
> Second round.
And last round. [ work ]. Scratch that. There'll be one more after this
;)
- Subscription code improvements
WOA. This is some minor cleanup stuff afaics. Don't think it's
terribly release bound.
- Bootstrap data conversio
On Thu, Mar 01, 2018 at 02:28:54AM -0800, Andres Freund wrote:
> On 2018-02-01 09:04:57 -0500, Peter Eisentraut wrote:
>> I've been testing this a bit further and during a test setup with 4-byte
>> bools I still got regression test failures related to GIN, so it doesn't
>> seem quite ready. I'll k
On Thu, Mar 01, 2018 at 02:27:13AM -0800, Andres Freund wrote:
> If I understand correctly there's been no progress on this since, and
> there'd definitely need to be major work to get something we can agree
> upon. Doesn't seem v11 material. I think we should mark this as returned
> with feedback.
Hi,
On 2018-01-19 09:28:33 -0500, Stephen Frost wrote:
> This patch still needs updating for Magnus' comments, of course, and
> I'm still planning to make that happen, so Waiting on Author is the
> right status currently.
Given that this hasn't happened, and that the next CF has started, ISTM,
th
Hi Andres.
On 2018/03/02 13:34, Andres Freund wrote:
> - reorganize partitioning code
>
> NR. Created recently, but split off an older patch.
>
> Seems like a generally reasonable idea. Wonder if it conflicts with
> some other partition related patches?
It actually does. There are at lea
On Thu, Mar 01, 2018 at 01:12:19PM -0500, David Steele wrote:
> But your point is well-taken. No symlinks are used in this test so it
> *should* work.
>
> Michael, what do you think?
Perl's symlink() does not work on Windows. It does not fly higher than
that, and that's the reason why a good chu
<20180301103641.tudam4mavba3g...@alap3.anarazel.de>
Thu, 1 Mar 2018 02:36:41 -0800Andres Freund wrote :
Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent
memory
>On 2018-02-05 09:59:25 +0900, Yoshimi Ichiyanagi wrote:
>> I added my patches to the CommitFest 2018-3.
>> https://c
On Thu, Mar 1, 2018 at 10:10 PM, Tom Lane wrote:
> I wrote:
> > I don't see anything in the commit message or linked discussion to
> > indicate that any visible behavior change was intended, so I think
> > you're right, this is a bug. Will check and push your patch.
>
> Actually, this patch stil
Thank you the comment.
On Fri, Mar 2, 2018 at 4:18 AM, Alvaro Herrera wrote:
> Masahiko Sawada wrote:
>
>> While reading the code, I realized that the requesting an autovacuum
>> work-item could fail in silence if work-item array is full. So the
>> users cannot realize that work-item is never per
> 1 марта 2018 г., в 22:44, Tom Lane написал(а):
>
> Michail Nikolaev writes:
>> I have added small change to patch to allow it be compiled using msvc
>> (uint64_t -> uint64).
>> Everything seems to work, check-world is passing.
>
>> Actually patch fixes two issues:
>> 1) Partial GIST indexe
Hi, Michail!
Here are points that we need to address before advancing the patch.
> 20 февр. 2018 г., в 11:45, Andrey Borodin написал(а):
>
> Minor spots:
> There are some trailing whitespaces at line ends
>> Offset cannot be optimized because parallel execution
> I'd replace with
>> Offset can
Hi,
On 2018-01-26 17:00:26 +0900, Michael Paquier wrote:
> Another topic that I would like to discuss is how this interface is fit
> for the buildfarm code. After hacking my stuff, I have looked at the
> buildfarm code to notice that things like TestUpgradeXversion.pm do
> *not* make use of test.
Hi,
On 2018-02-10 20:45:40 +0500, Andrey Borodin wrote:
> I've contacted Postgres Professional. Marina Polyakova had kindly provided
> their patch.
> The patch allows to use libc locale with ICU collation as default for cluster
> or database.
>
> It seems that this patch brings important long-a
Hi,
On 2018-02-28 11:16:24 +0300, Arthur Zakirov wrote:
> I've created the commitfest entry https://commitfest.postgresql.org/17/1569/
What is that entry for, if I may ask? We need to wait for them to merge
it, then sync the snowball code, including the nepali dictionary. This
doesn't realistica
On 2018/03/01 21:56, Robert Haas wrote:
> On Tue, Feb 27, 2018 at 4:33 AM, Amit Langote
> wrote:
>> Attached an updated version in which I incorporated some of the revisions
>> that David Rowley suggested to OR clauses handling (in partprune.c) that
>> he posted as a separate patch on the run-time
This appears to be a duplicate of https://commitfest.postgresql.org/17/1466/ -
as the other one is older, I'm closing this one.
Hi,
On 2018-03-01 00:58:42 +0300, Nikita Glukhov wrote:
> Attached 3rd version of kNN for SP-GiST.
Given that this was submitted to the last v11 CF, after not being
developed for a year, I think it's unfortunately too late for v11. As we
should be concentrating on getting things into v11, I think
Hi,
This patchset currently has multiple CF entries:
https://commitfest.postgresql.org/17/1063/
and then subordinate ones like
https://commitfest.postgresql.org/17/1471/
https://commitfest.postgresql.org/17/1472/
https://commitfest.postgresql.org/17/1473/
Thus I'm marking this entry as returned
Hi,
I found that tab completion for ALTER INDEX SET [tab] doesn't support
the reloptions of brin and gist. Attached patch adds "buffering",
"pages_per_range" and "autosummarize" options.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
tab_
On 2018-02-02 17:00:24 -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > There might be other options, but one way to solve this would be to
> > treat partition bounds as a general expression in the grammar and then
> > check in post-parse analysis that it's a constant.
>
> That's pretty much
Hi David.
On 2018/03/02 12:41, David Rowley wrote:
> Quite simply:
>
> d1=# create table bp (b bool) partition by list(b);
> CREATE TABLE
> d1=# create table bp_f partition of bp for values in('f');
> CREATE TABLE
> d1=# \q
> $ createdb d2
> $ pg_dump d1 | psql d2
>
> ...
>
> ERROR: syntax err
Hi,
On 2018-02-20 12:10:22 -0300, Matheus de Oliveira wrote:
> I attached a patch to add support for changing ON UPDATE/DELETE actions of
> a constraint using ALTER TABLE ... ALTER CONSTRAINT.
This patch has been submitted to the last commitfest for v11 and is not
a trivial patch. As we don't ac
Hi,
On 2018-02-28 22:35:52 -0500, Peter Eisentraut wrote:
> This feature is meant to help manage transaction isolation in
> procedures.
This is a major new feature, submitted the evening before the last CF
for v11 starts. Therefore I think it should just be moved to the next
fest, it doesn't seem
Hi,
On 2018-01-20 14:51:12 +0200, Magnus Hagander wrote:
> Finally found myself back at this one, because I still think this is a
> problem we definitely need to adress (whether with this file or not).
This has an open CF entry for CF 2018-03. Given that there's still a lot
of uncertainty what we
On 2018/03/02 15:58, Andres Freund wrote:
> On 2018-02-02 17:00:24 -0500, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> There might be other options, but one way to solve this would be to
>>> treat partition bounds as a general expression in the grammar and then
>>> check in post-parse analysis
On 2018-01-15 12:12:26 -0500, Robert Haas wrote:
> On Thu, Jan 11, 2018 at 9:02 AM, Stephen Frost wrote:
> > Parallel pg_dump is based on synchronized transactions though and we
> > have a bunch of checks in ImportSnapshot() because a pg_dump parallel
> > worker also can't really be quite the same
On 2 Mar 2018 09:44, "Andres Freund" wrote:
Hi,
This patchset currently has multiple CF entries:
https://commitfest.postgresql.org/17/1063/
and then subordinate ones like
https://commitfest.postgresql.org/17/1471/
https://commitfest.postgresql.org/17/1472/
https://commitfest.postgresql.org/17/1
Hi,
On 2018-02-19 17:00:34 +0100, Tomas Vondra wrote:
> I have a hard time understanding how adding yet another autovacuum
> table-level knob makes the DBA's life any easier. Especially when the
> behavior is so unreliable and does not really guarantee when the
> high-priority table will be cleane
On 2018-03-02 10:31:34 +0300, Oleg Bartunov wrote:
> Right, we divided it to manageable pieces as Andrew suggested.
Please close the corresponding CF entry next time, if you do so. It's a
bit painful having to reconstruct such things out of numerous large
threads.
Greetings,
Andres Freund
On 2018-03-01 16:18:48 +0100, Magnus Hagander wrote:
> On Thu, Mar 1, 2018 at 9:04 AM, Andres Freund wrote:
>
> > On 2018-03-01 12:56:35 +0500, Andrey Borodin wrote:
> > > I've tried to rebase this patch to 10 and, despite minor rebase issues
> > (oids, bgw_type, changes to specscanner), patch wo
Horiguchi-san,
On 2018/02/05 18:17, Kyotaro HORIGUCHI wrote:
> At Mon, 29 Jan 2018 13:21:54 +0900, Amit Langote wrote:
>> Partition bound literals as captured gram.y don't have any type
>> information attached. They're carried over in a A_Const to
>> transformPartitionBoundValue() and coerced to
Hi,
On 2018-02-28 18:04:27 +0900, Masahiko Sawada wrote:
> I've created the new thread for the changing AV launcher scheduling.
> The problem of AV launcher scheduling is described on [1] but I
> summarize it here.
This is a new patch submitted to CF 2018-03. As that's the last CF for
v11, and th
Hi,
On 2018-03-01 20:34:11 -0800, Andres Freund wrote:
> On 2018-03-01 14:45:15 -0800, Andres Freund wrote:
> > Second round.
>
> And last round. [ work ]. Scratch that. There'll be one more after this
> ;)
Let's do this. Hell, this CF is large. I'll have a glass of wine at
some point of this.
On Wed, Feb 28, 2018 at 1:45 AM, Alexander Korotkov
wrote:
> On Wed, Nov 29, 2017 at 6:06 PM, Masahiko Sawada
> wrote:
>>
>> On Wed, Nov 29, 2017 at 11:05 PM, Simon Riggs
>> wrote:
>> > On 25 September 2017 at 22:34, Kyotaro HORIGUCHI
>> > wrote:
>> >
>> >>> > Here is a small patch that skips s
201 - 269 of 269 matches
Mail list logo
