On 19 February 2018 at 18:01, David Rowley wrote:
> On 19 February 2018 at 15:11, Tomas Vondra
> wrote:
>> and perhaps we should do s/isproxy/is_proxy/ which seems like the usual
>> naming for boolean variables.
>
> You're right. I'll change that and post an updated patch. I'll also
> reprocess
While poking around partition.c I noticed that one of the functions
there is *defined* as "extern". Normally we'd only do this in the
declaration of the function. I don't really see why it's needed in the
definition.
Anyway, I removed it. I then thought I'd better look around for any
others too...
The SQL standard has the expression "NEXT VALUE FOR asequence" to do
what we traditionally do with "nextval('asequence')".
This is an attempt to implement this on top of the recently introduced
NextValueExpr node.
If there is no obvious reason why we would not want that, I'll add it
to the next c
Hello,
On Fri, Feb 02, 2018 at 06:03:27PM +0300, Ildus Kurbangaliev wrote:
> Hi,
>
> Attached patch introduces prefix operator ^@ for text type. For 'a ^@ b'
> it returns true if 'a' starts with 'b'. Also there is spgist index
> support for this operator.
>
> It could be useful as an alternative
On Mon, Feb 19, 2018 at 07:05:47AM +, Tsunakawa, Takayuki wrote:
> The current PostgreSQL documentation overestimates the number of huge pages
> (vm.nr_hugepages) because the calculation uses the maximum virtual address
> space. In practice, huge pages are only used for the anonymous shared me
Hi all.
I'm lead developer for pgCodeKeeper which is a tool for PostgreSQL database
schema comparison.
In our tool we have a pg_dump-like schema reader for comparing against live
DB instances.
This reader consumes majority of the time the comparison operation takes
and we had an idea to speed it u
Laurenz Albe wrote:
> The SQL standard has the expression "NEXT VALUE FOR asequence" to do
> what we traditionally do with "nextval('asequence')".
The behavior mandated by the standard is that several invocations
of NEXT VALUE on the same sequence on the same output row
must produce the s
On 19 February 2018 at 22:19, Amit Langote
wrote:
> Attached updated patches. Thanks again!
Thanks for making those changes. I've made another pass of v28 and
have a few more comments.
The patch is starting to look good, but there are some new changes in
recent versions which still don't look
There was a complaint recently about the documentation using the widely
frowned-upon md5() function in an unrelated context as an example hash
function. This is quite common in many examples, such as hashing row
values to compare them, or hashing datums if they don't fit into an
index. But there
Hello Peter,
> So I suggest these patches that expose the new functions sha224(),
> sha256(), sha384(), sha512(). That allows us to make the SSL and SCRAM
> tests more robust, and it will allow them to be used in general purpose
> contexts over md5().
Nice patch. I wonder though whether tests sh
Hello hackers,
I would like to propose nepali snowball dictionary patch.
Nepali is inflectional and derivational language. And it can be stemmed.
initdb also patched, so it can determine default text search
configuration.
Examples:
=# select ts_lexize('nepali_stem', 'लेख्');
ts_lexize
--
On 16.02.2018 11:59, Michail Nikolaev wrote:
Hello.
Just want to notice - this work also correlates with
https://www.postgresql.org/message-id/CAEepm%3D18buPTwNWKZMrAXLqja1Tvezw6sgFJKPQ%2BsFFTuwM0bQ%40mail.gmail.com paper.
It provides more general way to address the issue comparing to single
On 02/19/2018 08:43 AM, Peter Eisentraut wrote:
> I also noticed while working on some SSL code that we have perfectly
> good SHA-2 functionality in the server already, but it has no test
> coverage outside the SCRAM tests.
>
> So I suggest these patches that expose the new functions sha224(),
> s
On Mon, 19 Feb 2018 15:06:51 +0300
Arthur Zakirov wrote:
> Hello,
>
> On Fri, Feb 02, 2018 at 06:03:27PM +0300, Ildus Kurbangaliev wrote:
> > Hi,
> >
> > Attached patch introduces prefix operator ^@ for text type. For 'a
> > ^@ b' it returns true if 'a' starts with 'b'. Also there is spgist
> >
01.02.2018 05:12, Tom Lane:
Yugo Nagata writes:
I'm sorry the patch attached in the previous mail is broken and
not raises a compile error. I attached the fixed patch.
This patch is almost certainly wrong: you can't assume that the scan-level
state matches the tuple we are currently processing
On Fri, 16 Feb 2018 21:48:14 +0900
Masahiko Sawada wrote:
> On Fri, Feb 16, 2018 at 7:50 PM, Ildus Kurbangaliev
> wrote:
> > On Fri, 16 Feb 2018 17:42:34 +0900
> > Masahiko Sawada wrote:
> >
> >> On Thu, Feb 15, 2018 at 10:16 PM, Grigory Smolkin
> >> wrote:
> >> > On 02/15/2018 09:28 AM, M
Arthur Zakirov writes:
> Is it appropriate to add new snowball dictionaries? I'm not sure about
> policy of including new snowball dictionaries.
We are not the upstream for the snowball stuff, and lack the expertise
to decide whether proposed changes are any good. To get anything
changed there,
Laurenz Albe writes:
> The SQL standard has the expression "NEXT VALUE FOR asequence" to do
> what we traditionally do with "nextval('asequence')".
> This is an attempt to implement this on top of the recently introduced
> NextValueExpr node.
This has been proposed repeatedly, and rejected repeat
On 02/19/2018 03:38 PM, Ildus Kurbangaliev wrote:
> On Fri, 16 Feb 2018 21:48:14 +0900
> Masahiko Sawada wrote:
>
>> On Fri, Feb 16, 2018 at 7:50 PM, Ildus Kurbangaliev
>> wrote:
>>> On Fri, 16 Feb 2018 17:42:34 +0900
>>> Masahiko Sawada wrote:
>>>
On Thu, Feb 15, 2018 at 10:16 PM, Gri
On 02/18/2018 01:33 PM, Joe Conway wrote:
> On 02/18/2018 11:18 AM, Tom Lane wrote:
>> I'm fairly suspicious of toasting anything that the toast mechanism itself
>> depends on, actually, and that would include at least pg_attribute and
>> pg_index as well as pg_class. Maybe we could get away with
On Sat, Feb 17, 2018 at 12:22:37PM -0500, Alvaro Hernandez wrote:
>
>
> On 17/02/18 12:17, Tom Lane wrote:
> > Alvaro Hernandez writes:
> >> On 17/02/18 11:26, Tom Lane wrote:
> >>> Fabien COELHO writes:
> Here is a attempt at extending --scale so that it can be given a size.
> >>> I do no
David Rowley writes:
> While poking around partition.c I noticed that one of the functions
> there is *defined* as "extern". Normally we'd only do this in the
> declaration of the function. I don't really see why it's needed in the
> definition.
> Anyway, I removed it. I then thought I'd better lo
Hello Mark,
What if we consider using ascii (utf8?) text file sizes as a reference
point, something independent from the database?
Why not.
TPC-B basically specifies that rows (accounts, tellers, branches) are all
padded to 100 bytes, thus we could consider (i.e. document) that
--scale=SIZ
On 12 February 2018 at 15:26, Alvaro Herrera wrote:
> Hello,
>
> Thanks, Peter, Jesper, Amit, for reviewing the patch. Replying to
> all review comments at once:
>
[... v5 of patch attached ...]
Hi Álvaro,
attached a tiny patch (on top of yours) that silence two "variables
uninitilized" warnin
Hello devs,
While investigating moving pgbench expressions to fe_utils so that they
can be shared with psql (\if ..., \let ?), I figure out that psql's \if
has a syntax to test whether a variable exists, which is not yet available
to pgbench.
This patch adds the same syntax to pgbench expre
Jaime Casanova wrote:
> Hi Álvaro,
>
> attached a tiny patch (on top of yours) that silence two "variables
> uninitilized" warnings.
Thanks! Applied.
> also noted that if you:
>
> """
> create table t1(i int) partition by hash (i);
> create table t1_0 partition of t1 for values with (modulus
Hi,
On 02/14/2018 01:17 PM, Andres Freund wrote:
On 2018-02-07 06:54:05 -0800, Andres Freund wrote:
I've pushed v10.0. The big (and pretty painful to make) change is that
now all the LLVM specific code lives in src/backend/jit/llvm, which is
built as a shared library which is loaded on demand.
On 2/19/18 09:06, Aleksander Alekseev wrote:
>> So I suggest these patches that expose the new functions sha224(),
>> sha256(), sha384(), sha512(). That allows us to make the SSL and SCRAM
>> tests more robust, and it will allow them to be used in general purpose
>> contexts over md5().
>
> Nice
I pushed this now, with fixes for the last few comments there were.
Peter Eisentraut wrote:
> I don't understand the variable name "third". I don't see a "first" or
> "second" nearby.
Hah. That was referring to variables "myself" and "referenced". I
changed the variable name to "parentConstr"
Thank you for your answer!
2018-02-19 18:43 GMT+03:00 Tom Lane :
> We are not the upstream for the snowball stuff, and lack the expertise
> to decide whether proposed changes are any good. To get anything
> changed there, you'd have to get it approved by the snowball group.
>
> As best I know, th
On Fri, Aug 18, 2017 at 8:39 AM, Claudio Freire wrote:
> On Fri, Apr 7, 2017 at 10:51 PM, Claudio Freire
> wrote:
>> Indeed they do, and that's what motivated this patch. But I'd need
>> TB-sized tables to set up something like that. I don't have the
>> hardware or time available to do that (vac
I found the following change to be confusing.
/doc/src/sgml/ref/alter_table.sgml
+
+Additional restrictions apply when unique indexes are applied to
+partitioned tables; see .
+
That paragraph appears in the section covering "ALTER TABLE name ADD
table_constraint_usi
On Tue, Feb 20, 2018 at 12:01 AM, Arthur Zakirov
wrote:
> Thank you for your answer!
>
> 2018-02-19 18:43 GMT+03:00 Tom Lane :
>> We are not the upstream for the snowball stuff, and lack the expertise
>> to decide whether proposed changes are any good. To get anything
>> changed there, you'd have
On Mon, Feb 19, 2018 at 11:33:30AM -0500, Joe Conway wrote:
> The attached does exactly this. Gives all system tables toast tables
> except pg_class, pg_attribute, and pg_index, and includes cat version
> bump and regression test in misc_sanity.
>
> Any further discussion, comments, complaints?
T
On Mon, Feb 19, 2018 at 03:02:02PM -0500, Peter Eisentraut wrote:
> On 2/19/18 09:06, Aleksander Alekseev wrote:
>>> So I suggest these patches that expose the new functions sha224(),
>>> sha256(), sha384(), sha512(). That allows us to make the SSL and SCRAM
>>> tests more robust, and it will allo
Hello,
I propose changing the default value of wal_sync_method from fdatasync to
open_datasync on Linux. The patch is attached. I'm feeling this may be
controversial, so I'd like to hear your opinions.
The reason for change is better performance. Robert Haas said open_datasync
was much fast
Hi,
On 2018-02-20 00:27:47 +, Tsunakawa, Takayuki wrote:
> I propose changing the default value of wal_sync_method from fdatasync
> to open_datasync on Linux. The patch is attached. I'm feeling this
> may be controversial, so I'd like to hear your opinions.
Indeed. My past experience with o
Marina Polyakova writes:
> On 16-02-2018 19:31, Tom Lane wrote:
>> Weird. AFAICS the cost estimates for those two plans should be quite
>> different, so this isn't just a matter of the estimates maybe being
>> a bit platform-dependent. (And that test has been there nearly a
>> year without causi
On 20/02/18 13:27, Tsunakawa, Takayuki wrote:
Hello,
I propose changing the default value of wal_sync_method from fdatasync to
open_datasync on Linux. The patch is attached. I'm feeling this may be
controversial, so I'd like to hear your opinions.
The reason for change is better performanc
From: Andres Freund [mailto:and...@anarazel.de]
> Indeed. My past experience with open_datasync on linux shows it to be slower
> by roughly an order of magnitude. Even if that would turn out not to be
> the case anymore, I'm *extremely* hesitant to make such a change.
Thanks for giving so quick fe
On Mon, Feb 19, 2018 at 4:37 PM, Tom Lane wrote:
> I see several things we could do about this:
>
> 1. Nothing; just say "sorry, we don't promise that the regression tests
> pass with no plan differences on nonstandard configurations". Given that
> --disable-float8-byval has hardly any real-world
Hi,
Attached patch for fixing $subject.
s/replicaton/replication/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_procarray_c.patch
Description: Binary data
Petr Jelinek wrote:
> > Attached patch proposes a required fix.
> >
>
> Looks correct to me.
Masahiko Sawada wrote:
> The change looks good to me. Thank you.
Thanks, pushed.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Tra
On Mon, Feb 19, 2018 at 08:43:44AM -0500, Peter Eisentraut wrote:
> I also noticed while working on some SSL code that we have perfectly
> good SHA-2 functionality in the server already, but it has no test
> coverage outside the SCRAM tests.
Yep, the refactoring in src/common/ has been done for SC
From: Mark Kirkwood [mailto:mark.kirkw...@catalyst.net.nz]
> I think the use of 'nobarrier' is probably disabling most/all reliable
> writing to the devices. What do the numbers look like if use remove this
> option?
Disabling the filesystem barrier is a valid tuning method as the PG manual says:
On 2018-02-20 01:56:17 +, Tsunakawa, Takayuki wrote:
> Disabling the filesystem barrier is a valid tuning method as the PG manual
> says:
I don't think it says that:
> https://www.postgresql.org/docs/devel/static/wal-reliability.html
>
> [Excerpt]
> Recent SATA drives (those following ATAPI
From: Justin Pryzby [mailto:pry...@telsasoft.com]
> One can do with fewer greps:
> pryzbyj@pryzbyj:~$ sudo pmap `pgrep -P 1 -u postgres` |awk
> '/rw-s/&&/zero/{print $2}' # check PPID=1 144848K
Thanks, I'd like to take this.
Regards
Takayuki Tsunakawa
hugepage_size_doc_v2.patch
Description: hu
http://www.publix.com/myaccount/verify?validationCode=889fd4cb-6dbb-4f93-9d4f-c701410cd8a2
On Mon, Feb 19, 2018 at 1:18 PM, David Rowley
wrote:
> On 19 February 2018 at 13:48, Andrew Dunstan
> wrote:
>> On Sun, Feb 18, 2018 at 2:52 PM, David Rowley
>> wrote:
>>> I'll try to spend some time revi
Hi,
On 2018-02-17 00:23:40 +0100, Tomas Vondra wrote:
> Anyway, I consider the performance to be OK. But perhaps Andres could
> comment on this too, as he requested the benchmarks.
My performance concerns were less about CREATE TABLE related things than
about analytics workloads or such, where de
Hi!
I've played with patch. I observe that in some expected scenarios it reduces
read buffers significantly.
> 14 февр. 2018 г., в 0:04, Michail Nikolaev
> написал(а):
> Patch updated + rebased on master. check-world is passing.
Minor spots:
There are some trailing whitespaces at line ends
>
On Tue, Feb 20, 2018 at 5:03 PM, Andrew Dunstan
wrote:
> http://www.publix.com/myaccount/verify?validationCode=889fd4cb-6dbb-4f93-9d4f-c701410cd8a2
Wow, my c&p was working overtime. Good thing this won't do anyone any good.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadr
On Tue, Feb 20, 2018 at 12:34 PM, Amit Langote <
langote_amit...@lab.ntt.co.jp> wrote:
> Attached updated version.
>
Hi Amit,
I have applied v29 patch-set on head and got "ERROR: operator 1209 is not
a member of opfamily 1994" with below test case. Please take a look.
CREATE TABLE part (c1 IN
52 matches
Mail list logo
