Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-27 Thread Andres Freund
On 2018-09-26 12:35:25 -0700, Andres Freund wrote: > Hi, > > On 2018-09-26 12:41:38 +0900, Michael Paquier wrote: > > On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote: > > > My point is that FuncCallContext->slot isn't actually all that related > > > to TupleDescGetSlot() and could be

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-26 Thread Andres Freund
Hi, On 2018-09-26 12:41:38 +0900, Michael Paquier wrote: > On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote: > > My point is that FuncCallContext->slot isn't actually all that related > > to TupleDescGetSlot() and could be used entirely independently. > > That's fair. Why not just r

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-25 Thread Michael Paquier
On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote: > My point is that FuncCallContext->slot isn't actually all that related > to TupleDescGetSlot() and could be used entirely independently. That's fair. Why not just replacing the existing comment with something like "slot can be used

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-25 Thread Andres Freund
On 2018-09-26 10:38:51 +0900, Michael Paquier wrote: > On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote: > >> git grep TupleDescGetSlot > >> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated > >> TupleDescGetSlot(). > >> src/include/funcapi.h: * user-defined S

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-25 Thread Michael Paquier
On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote: >> git grep TupleDescGetSlot >> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated >> TupleDescGetSlot(). >> src/include/funcapi.h: * user-defined SRFs that use the deprecated >> TupleDescGetSlot(). > > But he

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-25 Thread Andres Freund
On 2018-09-26 09:04:14 +0900, Michael Paquier wrote: > Hi Andres, > > On Tue, Sep 25, 2018 at 11:39:05PM +, Andres Freund wrote: > > Remove absolete function TupleDescGetSlot(). > > > > TupleDescGetSlot() was kept around for backward compatibility for > > user-written SRFs. With the TupleTabl

Re: pgsql: Remove absolete function TupleDescGetSlot().

2018-09-25 Thread Michael Paquier
Hi Andres, On Tue, Sep 25, 2018 at 11:39:05PM +, Andres Freund wrote: > Remove absolete function TupleDescGetSlot(). > > TupleDescGetSlot() was kept around for backward compatibility for > user-written SRFs. With the TupleTableSlot abstraction work, that code > will need to be version specifi