On 2018-09-26 12:35:25 -0700, Andres Freund wrote: > Hi, > > On 2018-09-26 12:41:38 +0900, Michael Paquier wrote: > > On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote: > > > My point is that FuncCallContext->slot isn't actually all that related > > > to TupleDescGetSlot() and could be used entirely independently. > > > > That's fair. Why not just replacing the existing comment with something > > like "slot can be used in your own context to store tuple values, > > useful in the context of user-defined SRFs"? Just my 2c. > > I've tried to do search for users of FuncCallContext->slot and couldn't > find anything. Therefore I'm more inclined to drop it too - just about > all cases where it's useful seem to require a more extensive > datastructure around anyway. Unless somebody protests I'm going to that > in a few - if somebody later in the cycle signals a need for it, we can > still revert that part.
Done so now. Greetings, Andres Freund
