On Mon, Feb 22, 2021 at 8:27 PM Michael Paquier wrote:
> Looks good to me, thanks!
Pushed, with one further small change: I realised that tab completion
should use a "schema" query.
On Mon, Feb 22, 2021 at 06:34:22PM +1300, Thomas Munro wrote:
> On Thu, Feb 18, 2021 at 8:15 PM Michael Paquier wrote:
>> Could you just add a test with pg_collation_current_version(0)?
>
> Done.
>
>> + pg_strncasecmp("POSIX.", collcollate, 6) != 0)
>>
>> I didn't know that "POSIX." was po
On Thu, Feb 18, 2021 at 8:15 PM Michael Paquier wrote:
> Could you just add a test with pg_collation_current_version(0)?
Done.
> + pg_strncasecmp("POSIX.", collcollate, 6) != 0)
>
> I didn't know that "POSIX." was possible.
Yeah, that isn't valid on my (quite current) GNU or FreeBSD syste
On Thu, Feb 18, 2021 at 10:45:53AM +1300, Thomas Munro wrote:
> I guess I was trying to preserve a distinction between "unknown OID"
> and "this is a collation OID, but I don't have version information for
> it" (for example, "C.utf8"). But it hardly matters, and your
> suggestion works for me. T
On Wed, Feb 17, 2021 at 8:04 PM Michael Paquier wrote:
> On Wed, Feb 17, 2021 at 03:08:36PM +1300, Thomas Munro wrote:
> > tp = SearchSysCache1(COLLOID, ObjectIdGetDatum(oid));
> > if (!HeapTupleIsValid(tp))
> > + {
> > + if (found)
> > +
On Wed, Feb 17, 2021 at 03:08:36PM +1300, Thomas Munro wrote:
> tp = SearchSysCache1(COLLOID, ObjectIdGetDatum(oid));
> if (!HeapTupleIsValid(tp))
> + {
> + if (found)
> + {
> + *found = fals
On Mon, Jan 18, 2021 at 11:22 AM Thomas Munro wrote:
> On Mon, Jan 18, 2021 at 10:59 AM Justin Pryzby > |postgres=# SELECT
> pg_collation_actual_version(123);
> > |ERROR: cache lookup failed for collation 123
>
> Yeah, not a great user experience. Will fix next week; perhaps
> get_collation_vers
On Mon, Jan 18, 2021 at 10:59 AM Justin Pryzby > |postgres=# SELECT
pg_collation_actual_version(123);
> |ERROR: cache lookup failed for collation 123
Yeah, not a great user experience. Will fix next week; perhaps
get_collation_version_for_oid() needs missing_ok and found flags, or
something like
As of 257836a75, this returns:
|postgres=# SELECT pg_collation_actual_version(123);
|ERROR: cache lookup failed for collation 123
|postgres=# \errverbose
|ERROR: XX000: cache lookup failed for collation 123
|LOCATION: get_collation_version_for_oid, pg_locale.c:1754
I'm of the impression that'
