On Mon, Feb 22, 2021 at 06:34:22PM +1300, Thomas Munro wrote:
> On Thu, Feb 18, 2021 at 8:15 PM Michael Paquier <mich...@paquier.xyz> wrote:
>> Could you just add a test with pg_collation_current_version(0)?
>
> Done.
>
>> + pg_strncasecmp("POSIX.", collcollate, 6) != 0)
>>
>> I didn't know that "POSIX." was possible.
>
> Yeah, that isn't valid on my (quite current) GNU or FreeBSD systems,
> and doesn't show up in their "locale -a" output, but I wondered about
> that theoretical possibility and googled it, and that showed that it
> does exist out there, though I don't know where/which versions,
> possibly only a long time ago. You know what, let's just forget that
> bit, it's not necessary. Removed.
>
>> While on it, I guess that you could add tab completion support for
>> CREATE COLLATION foo FROM.
>
> Good point. Added.
>
>> And shouldn't CREATE COLLATION complete
>> with the list of existing collation?
>
> Rght, fixed.Looks good to me, thanks! -- Michael
signature.asc
Description: PGP signature
