On Thu, Feb 18, 2021 at 10:45:53AM +1300, Thomas Munro wrote:
> I guess I was trying to preserve a distinction between "unknown OID"
> and "this is a collation OID, but I don't have version information for
> it" (for example, "C.utf8").  But it hardly matters, and your
> suggestion works for me.  Thanks for looking!

Could you just add a test with pg_collation_current_version(0)?

+       pg_strncasecmp("POSIX.", collcollate, 6) != 0)
I didn't know that "POSIX." was possible.

While on it, I guess that you could add tab completion support for
CREATE COLLATION foo FROM.  And shouldn't CREATE COLLATION complete
with the list of existing collation?
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to