Re: document pg_settings view doesn't display custom options

2020-11-09 Thread John Naylor
On Mon, Nov 9, 2020 at 2:12 AM Fujii Masao wrote: > Pushed. Thanks! > Thank you! -- John Naylor EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: document pg_settings view doesn't display custom options

2020-11-08 Thread Fujii Masao
On 2020/11/07 0:42, Fujii Masao wrote: On 2020/10/31 2:06, John Naylor wrote: On Fri, Oct 30, 2020 at 12:48 PM Tom Lane mailto:t...@sss.pgh.pa.us>> wrote:     John Naylor mailto:john.nay...@enterprisedb.com>> writes: > Okay, along those lines here's a patch using "this view" in a ne

Re: document pg_settings view doesn't display custom options

2020-11-06 Thread Fujii Masao
On 2020/10/31 2:06, John Naylor wrote: On Fri, Oct 30, 2020 at 12:48 PM Tom Lane mailto:t...@sss.pgh.pa.us>> wrote: John Naylor mailto:john.nay...@enterprisedb.com>> writes: > Okay, along those lines here's a patch using "this view" in a new paragraph > for simplicity. B

Re: document pg_settings view doesn't display custom options

2020-10-30 Thread John Naylor
On Fri, Oct 30, 2020 at 12:48 PM Tom Lane wrote: > John Naylor writes: > > Okay, along those lines here's a patch using "this view" in a new > paragraph > > for simplicity. > > Basically OK with me, but ... > > > It seems fairly weird to use a nonspecific reference first and then a > specific o

Re: document pg_settings view doesn't display custom options

2020-10-30 Thread Tom Lane
John Naylor writes: > Okay, along those lines here's a patch using "this view" in a new paragraph > for simplicity. Basically OK with me, but ... It seems fairly weird to use a nonspecific reference first and then a specific one. That is, I'd expect to read "The pg_settings view ..." and then

Re: document pg_settings view doesn't display custom options

2020-10-30 Thread John Naylor
On Fri, Oct 30, 2020 at 12:07 PM Tom Lane wrote: > John Naylor writes: > > On Thu, Oct 29, 2020 at 11:51 PM Fujii Masao < > masao.fu...@oss.nttdata.com> > > wrote: > >> Also I think this note should be in the different paragraph from the > >> paragraph > >> of "The pg_settings view cannot be ins

Re: document pg_settings view doesn't display custom options

2020-10-30 Thread Tom Lane
John Naylor writes: > On Thu, Oct 29, 2020 at 11:51 PM Fujii Masao > wrote: >> Also I think this note should be in the different paragraph from the >> paragraph >> of "The pg_settings view cannot be inserted into or deleted from" >> because >> they are different topics. Thought? > Agreed on

Re: document pg_settings view doesn't display custom options

2020-10-30 Thread John Naylor
On Thu, Oct 29, 2020 at 11:51 PM Fujii Masao wrote: > > > On 2020/10/29 21:54, John Naylor wrote: > > > The pg_settings does not display > > customized options > > that have been set before the relevant extension module has been > loaded. > > I guess that someone can misread this as >

Re: document pg_settings view doesn't display custom options

2020-10-29 Thread Fujii Masao
On 2020/10/29 21:54, John Naylor wrote: On Wed, Oct 28, 2020 at 11:38 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: On 2020/10/29 3:45, John Naylor wrote: > On Wed, Oct 28, 2020 at 2:15 PM John Naylor mailto:john.nay...@enterprisedb.com>

Re: document pg_settings view doesn't display custom options

2020-10-29 Thread John Naylor
On Wed, Oct 28, 2020 at 11:38 PM Fujii Masao wrote: > > > On 2020/10/29 3:45, John Naylor wrote: > > On Wed, Oct 28, 2020 at 2:15 PM John Naylor < > john.nay...@enterprisedb.com > wrote: > > > > Starting separate threads to keep from cluttering the TODO li

Re: document pg_settings view doesn't display custom options

2020-10-28 Thread Fujii Masao
On 2020/10/29 3:45, John Naylor wrote: On Wed, Oct 28, 2020 at 2:15 PM John Naylor mailto:john.nay...@enterprisedb.com>> wrote: Starting separate threads to keep from cluttering the TODO list thread. Here's a patch for the subject, as mentioned in https://www.postgresql.org/messa

Re: document pg_settings view doesn't display custom options

2020-10-28 Thread John Naylor
On Wed, Oct 28, 2020 at 2:15 PM John Naylor wrote: > Starting separate threads to keep from cluttering the TODO list thread. > > Here's a patch for the subject, as mentioned in > https://www.postgresql.org/message-id/20201027220555.GS4951%40momjian.us > I just realized I introduced a typo, so he

document pg_settings view doesn't display custom options

2020-10-28 Thread John Naylor
Starting separate threads to keep from cluttering the TODO list thread. Here's a patch for the subject, as mentioned in https://www.postgresql.org/message-id/20201027220555.GS4951%40momjian.us -- John Naylor EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company doc-pg-set