On Fri, Oct 30, 2020 at 12:07 PM Tom Lane <t...@sss.pgh.pa.us> wrote:

> John Naylor <john.nay...@enterprisedb.com> writes:
> > On Thu, Oct 29, 2020 at 11:51 PM Fujii Masao <
> masao.fu...@oss.nttdata.com>
> > wrote:
> >> Also I think this note should be in the different paragraph from the
> >> paragraph
> >> of "The pg_settings view cannot be inserted into or deleted from...."
> >> because
> >> they are different topics. Thought?
>
> > Agreed on both points. In a separate paragraph, I think it's awkward to
> > start two consecutive sentences with "The pg_settings view". If we put it
> > in the previous paragraph we could phrase it like this:
>
> > "See Section 20.1 for more information about the various ways to change
> > these parameters. Customized options are not displayed until the
> > extension module that defines them has been loaded.
>
> That just moves the subject-inconsistency to a different para :-(
> I think this item should be its own new para.
>
> As for the repetitiveness, we could just say "This view ...", in one or
> even both paras.
>

Okay, along those lines here's a patch using "this view" in a new paragraph
for simplicity.

-- 
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment: v3-doc-pg-settings-no-custom.patch
Description: Binary data

Reply via email to