On 2020/10/31 2:06, John Naylor wrote:


On Fri, Oct 30, 2020 at 12:48 PM Tom Lane <t...@sss.pgh.pa.us 
<mailto:t...@sss.pgh.pa.us>> wrote:

    John Naylor <john.nay...@enterprisedb.com 
<mailto:john.nay...@enterprisedb.com>> writes:
     > Okay, along those lines here's a patch using "this view" in a new 
paragraph
     > for simplicity.

    Basically OK with me, but ...

    <quibble>
    It seems fairly weird to use a nonspecific reference first and then a
    specific one.  That is, I'd expect to read "The pg_settings view ..."
    and then "This view ...", not the other way around.  So we could
    put this para second, or put it first but make this para say
    "The pg_settings view ..." while the existing text gets reduced to
    "This view ...".

    Or just make them both say "This view ..." so we don't have to have
    this discussion again the next time somebody wants to add a para here.
    </quibble>


Okay, how's this?

Looks good to me. Barring any objection, I will commit the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION


Reply via email to