Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-16 Thread Tom Lane
Christoph Berg writes: >> Agreed so far as the script name goes. However, two out of three of these >> scripts also print their input file names, and I'm suspicious that that >> output is also gonna change in a VPATH build. I'm a little less inclined >> to buy the claim that we're not losing any

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-16 Thread Christoph Berg
Re: Tom Lane 2017-12-16 <5525.1513381...@sss.pgh.pa.us> > >>> As per > >>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/postgresql-10.html, > >>> that's the only place that makes it into the resulting binary. > > I'm fairly confused by this claim. Since the string in questio

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Tom Lane
Andres Freund writes: > On 2017-12-16 07:52:41 +0900, Michael Paquier wrote: >> On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg >> wrote: >>> Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> genbki.pl is hardly our only script that prints its $0 ... >>> As per >>> https://tests.repro

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Peter Geoghegan
On Fri, Dec 15, 2017 at 3:21 PM, Andres Freund wrote: >> Why not fixing that? Reproducible builds are a trend of these days, >> and what's proposed here is really simple to make PG more compliant >> with this purpose in mind. > > It's not like $0 instead of a hardcoded name in the header actually

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Andres Freund
On 2017-12-16 07:52:41 +0900, Michael Paquier wrote: > On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg > wrote: > > Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> > >> Christoph Berg writes: > >> > Debian's reproducible builds project has revealed that the full build > >> > path gets emb

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Michael Paquier
On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg wrote: > Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> >> Christoph Berg writes: >> > Debian's reproducible builds project has revealed that the full build >> > path gets embedded into server/catalog/schemapg.h: >> >> genbki.pl is hardly o

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Christoph Berg
Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> > Christoph Berg writes: > > Debian's reproducible builds project has revealed that the full build > > path gets embedded into server/catalog/schemapg.h: > > genbki.pl is hardly our only script that prints its $0 ... As per https://tests.re

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Tom Lane
Christoph Berg writes: > Debian's reproducible builds project has revealed that the full build > path gets embedded into server/catalog/schemapg.h: genbki.pl is hardly our only script that prints its $0 ... regards, tom lane

Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Christoph Berg
Hi, Debian's reproducible builds project has revealed that the full build path gets embedded into server/catalog/schemapg.h: /*- * * schemapg.h *Schema_pg_xxx macros for use by relcache.c * * Portions Copyright (c) 1