On 2017-12-16 07:52:41 +0900, Michael Paquier wrote: > On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg > <christoph.b...@credativ.de> wrote: > > Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> > >> Christoph Berg <christoph.b...@credativ.de> writes: > >> > Debian's reproducible builds project has revealed that the full build > >> > path gets embedded into server/catalog/schemapg.h: > >> > >> genbki.pl is hardly our only script that prints its $0 ... > > > > As per > > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/postgresql-10.html, > > that's the only place that makes it into the resulting binary. > > I wouldn't be sending a patch if it didn't fix the issue. > > Why not fixing that? Reproducible builds are a trend of these days, > and what's proposed here is really simple to make PG more compliant > with this purpose in mind.
It's not like $0 instead of a hardcoded name in the header actually buys us anything afaict. Greetings, Andres Freund
