Re: testclient.exe installed under MSVC

2022-05-04 Thread Daniel Gustafsson
> On 4 May 2022, at 02:34, Andrew Dunstan wrote: > I think we should make the standard MSVC install look as much like the > standard Unix/msys install as possible. +1 -- Daniel Gustafsson https://vmware.com/

Re: testclient.exe installed under MSVC

2022-05-04 Thread Daniel Gustafsson
> On 3 May 2022, at 16:50, Daniel Gustafsson wrote: > >> On 3 May 2022, at 15:58, Alvaro Herrera wrote: >> >> On 2022-May-03, Noah Misch wrote: >> >>> Michael Paquier recommended s/-/_/ for uri-regress, and I agree with that. >>> What do you think? >> >> libpq_uri-regress is horrible, so +1 f

Re: testclient.exe installed under MSVC

2022-05-03 Thread Andrew Dunstan
On 2022-05-01 Su 09:23, Michael Paquier wrote: > On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: >> My annual audit for executables missing Windows icons turned up these: >> >> pginstall/bin/testclient.exe >> pginstall/bin/uri-regress.exe >> >> I was going to add the i

Re: testclient.exe installed under MSVC

2022-05-03 Thread Daniel Gustafsson
> On 3 May 2022, at 15:58, Alvaro Herrera wrote: > > On 2022-May-03, Noah Misch wrote: > >> Michael Paquier recommended s/-/_/ for uri-regress, and I agree with that. >> What do you think? > > libpq_uri-regress is horrible, so +1 for that. Agreed, I'll do that before pushing. -- Daniel Gustaf

Re: testclient.exe installed under MSVC

2022-05-03 Thread Alvaro Herrera
On 2022-May-03, Noah Misch wrote: > Michael Paquier recommended s/-/_/ for uri-regress, and I agree with that. > What do you think? libpq_uri-regress is horrible, so +1 for that. I would personally rename more thoroughly (say pq_uri_test), but I doubt it's worth the bikeshedding effort. -- Álv

Re: testclient.exe installed under MSVC

2022-05-03 Thread Noah Misch
On Tue, May 03, 2022 at 03:04:26PM +0200, Daniel Gustafsson wrote: > > On 3 May 2022, at 04:02, Noah Misch wrote: > > On Mon, May 02, 2022 at 03:14:50PM +0200, Daniel Gustafsson wrote: > > >> Renaming is probably the best option given how MSVC works. Using a pg_ > >> prefix > >> makes them sound

Re: testclient.exe installed under MSVC

2022-05-03 Thread Daniel Gustafsson
> On 3 May 2022, at 04:02, Noah Misch wrote: > On Mon, May 02, 2022 at 03:14:50PM +0200, Daniel Gustafsson wrote: >> Renaming is probably the best option given how MSVC works. Using a pg_ prefix >> makes them sound like actual useful tools though with (albeit small) risk for >> confusion? Noah's

Re: testclient.exe installed under MSVC

2022-05-02 Thread Noah Misch
On Mon, May 02, 2022 at 03:14:50PM +0200, Daniel Gustafsson wrote: > > On 1 May 2022, at 15:23, Michael Paquier wrote: > > On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: > >> My annual audit for executables missing Windows icons turned up these: > >> > >>pginstall/bin/testcli

Re: testclient.exe installed under MSVC

2022-05-02 Thread Jacob Champion
On Mon, 2022-05-02 at 15:14 +0200, Daniel Gustafsson wrote: > Using a pg_ prefix > makes them sound like actual useful tools though with (albeit small) risk for > confusion? Noah's suggestion of libpq_ is perhaps better: libpq_testclient. +1 I also like Justin's idea of only installing the test

Re: testclient.exe installed under MSVC

2022-05-02 Thread Daniel Gustafsson
> On 1 May 2022, at 15:23, Michael Paquier wrote: > > On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: >> My annual audit for executables missing Windows icons turned up these: >> >>pginstall/bin/testclient.exe >>pginstall/bin/uri-regress.exe >> >> I was going to add

Re: testclient.exe installed under MSVC

2022-05-01 Thread Justin Pryzby
On Sun, May 01, 2022 at 10:23:18PM +0900, Michael Paquier wrote: > On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: > > My annual audit for executables missing Windows icons turned up these: > > > > pginstall/bin/testclient.exe > > pginstall/bin/uri-regress.exe > > > >

Re: testclient.exe installed under MSVC

2022-05-01 Thread Michael Paquier
On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: > My annual audit for executables missing Windows icons turned up these: > > pginstall/bin/testclient.exe > pginstall/bin/uri-regress.exe > > I was going to add the icons, but I felt the testclient.exe name is too > gener