> On 1 May 2022, at 15:23, Michael Paquier <mich...@paquier.xyz> wrote: > > On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote: >> My annual audit for executables missing Windows icons turned up these: >> >> pginstall/bin/testclient.exe >> pginstall/bin/uri-regress.exe >> >> I was going to add the icons, but I felt the testclient.exe name is too >> generic-sounding to be installed. testclient originated in commit ebc8b7d. >> I >> recommend ceasing to install both programs under MSVC. (The GNU make build >> system does not install them.) > > But MSVC works differently. vcregress.pl does a TempInstall(), which > is a simple Install(), so isn't it going to be an issue for the tests > if these two tools are not installed anymore? > >> If that's unwanted for some reason, could you >> rename testclient to something like libpq_test? > > Yes, the renaming makes sense. I'd say to do more, and also rename > uri-regress, removing the hyphen from the binary name and prefix both > binaries with a "pg_".
Renaming is probably the best option given how MSVC works. Using a pg_ prefix makes them sound like actual useful tools though with (albeit small) risk for confusion? Noah's suggestion of libpq_ is perhaps better: libpq_testclient. -- Daniel Gustafsson https://vmware.com/
