Re: pg_upgrade: warn about roles with md5 passwords

2025-06-04 Thread Daniel Gustafsson
> On 4 Jun 2025, at 22:15, Peter Eisentraut wrote: > I tend think pg_upgrade should stick to checking things that are necessary > for the upgrade to succeed. It shouldn't start being an interactive portal > to the release notes for aspects that are merely recommendations. Agreed, I was going

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-04 Thread Nathan Bossart
On Wed, Jun 04, 2025 at 04:46:52PM -0400, Bruce Momjian wrote: > On Wed, Jun 4, 2025 at 10:15:49PM +0200, Peter Eisentraut wrote: >> I tend think pg_upgrade should stick to checking things that are necessary >> for the upgrade to succeed. It shouldn't start being an interactive portal >> to the r

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-04 Thread Bruce Momjian
On Wed, Jun 4, 2025 at 10:15:49PM +0200, Peter Eisentraut wrote: > On 02.06.25 17:32, Nathan Bossart wrote: > > Since MD5 passwords are slated to be marked as deprecated in v18, I figured > > it might be a good idea to add a check for roles with MD5 passwords to > > pg_upgrade. I'm tempted to sug

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-04 Thread Peter Eisentraut
On 02.06.25 17:32, Nathan Bossart wrote: Since MD5 passwords are slated to be marked as deprecated in v18, I figured it might be a good idea to add a check for roles with MD5 passwords to pg_upgrade. I'm tempted to suggest that we apply this to v18, but I'm content to leave it for v19 if nobody

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Nathan Bossart
On Tue, Jun 03, 2025 at 09:43:59AM -0500, Nathan Bossart wrote: > On Tue, Jun 03, 2025 at 10:34:06AM -0400, Tom Lane wrote: >> If we really want to be in peoples' face about this, the thing >> to do is to print a warning every time they log in with an MD5 >> password. Also, to Michael's point, tha

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Nathan Bossart
On Tue, Jun 03, 2025 at 10:34:06AM -0400, Tom Lane wrote: > If we really want to be in peoples' face about this, the thing > to do is to print a warning every time they log in with an MD5 > password. Also, to Michael's point, that really would be exactly > the same place where the eventual "sorry,

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Tom Lane
ISTM that warnings emitted by pg_upgrade will be seen by about 0.1% of users anyway, since packagers typically wrap scripts around that. If we really want to be in peoples' face about this, the thing to do is to print a warning every time they log in with an MD5 password. Also, to Michael's point

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Heikki Linnakangas
+1 for this, and +1 for doing this still in v18. On 03/06/2025 17:12, Nathan Bossart wrote: On Tue, Jun 03, 2025 at 01:38:49PM +0900, Michael Paquier wrote: I'm not sure that this is necessary. Only requiring one to use --retain sounds kind of enough to me. Yeah, maybe we should just leave i

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Nathan Bossart
On Tue, Jun 03, 2025 at 01:38:49PM +0900, Michael Paquier wrote: > I'm not sure that this is necessary. Only requiring one to use > --retain sounds kind of enough to me. Yeah, maybe we should just leave it alone for now. > Saying that, warning users if they have MD5 passwords is a good idea, > b

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-03 Thread Laurenz Albe
On Mon, 2025-06-02 at 09:45 -0700, Jeff Davis wrote: > On Mon, 2025-06-02 at 10:32 -0500, Nathan Bossart wrote: > > Since MD5 passwords are slated to be marked as deprecated in v18, I figured > > it might be a good idea to add a check for roles with MD5 passwords to > > pg_upgrade.  I'm tempted to

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-02 Thread Michael Paquier
On Mon, Jun 02, 2025 at 02:55:40PM -0500, Nathan Bossart wrote: > So, right now the upgrade directory will be something like: > > ./pg_upgrade_output.d/20250602T095620.137 > > cleanup_output_dirs() recursively deletes everything in the timestamp > directory (and the directory itself), and t

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-02 Thread Nathan Bossart
On Mon, Jun 02, 2025 at 12:41:47PM -0700, Jeff Davis wrote: > On Mon, 2025-06-02 at 12:04 -0500, Nathan Bossart wrote: >> That seems worth considering.  Another option could be to just >> document >> that files generated for warnings will be lost without --retain.  >> WDYT? > > I haven't looked in

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-02 Thread Jeff Davis
On Mon, 2025-06-02 at 12:04 -0500, Nathan Bossart wrote: > > > That seems worth considering.  Another option could be to just > document > that files generated for warnings will be lost without --retain.  > WDYT? I haven't looked into it yet, but copying the files to an "upgrade_warnings" directo

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-02 Thread Nathan Bossart
On Mon, Jun 02, 2025 at 09:45:55AM -0700, Jeff Davis wrote: > On Mon, 2025-06-02 at 10:32 -0500, Nathan Bossart wrote: >> The one thing I don't like about this check is that it's probably not >> great >> from a security standpoint to effectively announce which roles have >> MD5 >> passwords. > > D

Re: pg_upgrade: warn about roles with md5 passwords

2025-06-02 Thread Jeff Davis
On Mon, 2025-06-02 at 10:32 -0500, Nathan Bossart wrote: > Since MD5 passwords are slated to be marked as deprecated in v18, I > figured > it might be a good idea to add a check for roles with MD5 passwords > to > pg_upgrade.  I'm tempted to suggest that we apply this to v18, but > I'm > content to