+1 for this, and +1 for doing this still in v18.
On 03/06/2025 17:12, Nathan Bossart wrote:
On Tue, Jun 03, 2025 at 01:38:49PM +0900, Michael Paquier wrote:
I'm not sure that this is necessary. Only requiring one to use
--retain sounds kind of enough to me.
Yeah, maybe we should just leave it alone for now.
I have no direct opinion on how the logging should work, but some thoughts:
- It's better to print a warning somewhere, even if you need to use
--retain to see it, than not doing it at all. At least there's a
fighting chance that someone might see it.
- If we're worried about printing a list of users with md5 passwords, we
could just say "there are users with md5 passwords" without naming them.
I'm not too worried though, pg_upgrade has full access to the data anyway.
--
Heikki Linnakangas
Neon (https://neon.tech)
