Re: pg_recvlogical cannot create slots with failover=true

2025-04-09 Thread Masahiko Sawada
On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu) wrote: > > On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: > > Hi, > > > Thank you for updating the patch! Pushed with small cosmetic changes. > > Thanks for pushing the feature ! > > I noticed one typo in the doc and here is a tiny patch t

RE: pg_recvlogical cannot create slots with failover=true

2025-04-06 Thread Zhijie Hou (Fujitsu)
On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: Hi, > Thank you for updating the patch! Pushed with small cosmetic changes. Thanks for pushing the feature ! I noticed one typo in the doc and here is a tiny patch to fix it. -The --two-phase and --falover options +The --two

Re: pg_recvlogical cannot create slots with failover=true

2025-04-04 Thread Michael Banck
Hi, On Tue, Apr 01, 2025 at 08:01:32AM +, Hayato Kuroda (Fujitsu) wrote: > Attached patch implements it. Since -f/-F option has already been used, -O was > chosen for the short-version. Better idea is very welcomed. Maybe we don't need a short option at all for this, at least initially? Mic

Re: pg_recvlogical cannot create slots with failover=true

2025-04-04 Thread Masahiko Sawada
On Thu, Apr 3, 2025 at 8:28 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Sawada-san, > > > Thank you for updating the patch. Here are some minor comments: > > > > The --two-phase can be specified with > > --create-slot to enable decoding of prepared > > transactions. > > +A

RE: pg_recvlogical cannot create slots with failover=true

2025-04-03 Thread Hayato Kuroda (Fujitsu)
Dear Sawada-san, > Thank you for updating the patch. Here are some minor comments: > > The --two-phase can be specified with > --create-slot to enable decoding of prepared > transactions. > +Also, --falover can be specified with > +--create-slot to create replica

Re: pg_recvlogical cannot create slots with failover=true

2025-04-03 Thread Masahiko Sawada
On Wed, Apr 2, 2025 at 11:57 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Michael, > > > Maybe we don't need a short option at all for this, at least initially? > > Indeed, updated. Thank you for updating the patch. Here are some minor comments: The --two-phase can be specified with

RE: pg_recvlogical cannot create slots with failover=true

2025-04-02 Thread Hayato Kuroda (Fujitsu)
Dear Michael, > Maybe we don't need a short option at all for this, at least initially? Indeed, updated. Best regards, Hayato Kuroda FUJITSU LIMITED v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch Description: v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch