Re: pg_recvlogical cannot create slots with failover=true

2025-06-29 Thread Masahiko Sawada
On Mon, Jun 30, 2025 at 2:37 AM Peter Eisentraut wrote: > > On 22.06.25 15:38, Peter Eisentraut wrote: > > On 17.06.25 20:19, Masahiko Sawada wrote: > Ideally, we should change both to maintain consistency across various > slot options. OTOH, as we have already described these options as

Re: pg_recvlogical cannot create slots with failover=true

2025-06-29 Thread Peter Eisentraut
On 22.06.25 15:38, Peter Eisentraut wrote: On 17.06.25 20:19, Masahiko Sawada wrote: Ideally, we should change both to maintain consistency across various slot options. OTOH, as we have already described these options as: " The --two-phase and --failover options can be specified with --create-sl

Re: pg_recvlogical cannot create slots with failover=true

2025-06-22 Thread Peter Eisentraut
On 17.06.25 20:19, Masahiko Sawada wrote: Ideally, we should change both to maintain consistency across various slot options. OTOH, as we have already described these options as: " The --two-phase and --failover options can be specified with --create-slot.", it is clear that these are slot option

Re: pg_recvlogical cannot create slots with failover=true

2025-06-17 Thread Masahiko Sawada
On Tue, Jun 17, 2025 at 12:59 AM Peter Eisentraut wrote: > > On 14.06.25 07:26, Amit Kapila wrote: > > On Sat, Jun 14, 2025 at 3:11 AM Masahiko Sawada > > wrote: > >> > >> On Thu, Jun 12, 2025 at 10:42 PM Peter Eisentraut > >> wrote: > > > > -The --two-phase and > > --falo

Re: pg_recvlogical cannot create slots with failover=true

2025-06-17 Thread Peter Eisentraut
On 14.06.25 07:26, Amit Kapila wrote: On Sat, Jun 14, 2025 at 3:11 AM Masahiko Sawada wrote: On Thu, Jun 12, 2025 at 10:42 PM Peter Eisentraut wrote: -The --two-phase and --falover options +The --two-phase and --failover options Thank you for the report and the patch! Pus

RE: pg_recvlogical cannot create slots with failover=true

2025-06-16 Thread Hayato Kuroda (Fujitsu)
Dear Amit, Sawada, Peter, > > > I wonder if the option name --failover is ideal. To me, it sounds like > > > an action "do a failover!". Also consider that pg_recvlogical has other > > > action options such as --start and --create-slot, so it sounds a bit > > > like those. > > > > Fair point. >

Re: pg_recvlogical cannot create slots with failover=true

2025-06-13 Thread Amit Kapila
On Sat, Jun 14, 2025 at 3:11 AM Masahiko Sawada wrote: > > On Thu, Jun 12, 2025 at 10:42 PM Peter Eisentraut > wrote: > > >> > > >> -The --two-phase and --falover > > >> options > > >> +The --two-phase and > > >> --failover options > > > > > > Thank you for the report and the p

Re: pg_recvlogical cannot create slots with failover=true

2025-06-13 Thread Masahiko Sawada
On Thu, Jun 12, 2025 at 10:42 PM Peter Eisentraut wrote: > > On 07.04.25 21:15, Masahiko Sawada wrote: > > On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu) > > wrote: > >> > >> On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: > >> > >> Hi, > >> > >>> Thank you for updating the patch! Push

Re: pg_recvlogical cannot create slots with failover=true

2025-06-12 Thread Peter Eisentraut
On 07.04.25 21:15, Masahiko Sawada wrote: On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu) wrote: On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: Hi, Thank you for updating the patch! Pushed with small cosmetic changes. Thanks for pushing the feature ! I noticed one typo in the

Re: pg_recvlogical cannot create slots with failover=true

2025-04-09 Thread Masahiko Sawada
On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu) wrote: > > On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: > > Hi, > > > Thank you for updating the patch! Pushed with small cosmetic changes. > > Thanks for pushing the feature ! > > I noticed one typo in the doc and here is a tiny patch t

RE: pg_recvlogical cannot create slots with failover=true

2025-04-06 Thread Zhijie Hou (Fujitsu)
On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote: Hi, > Thank you for updating the patch! Pushed with small cosmetic changes. Thanks for pushing the feature ! I noticed one typo in the doc and here is a tiny patch to fix it. -The --two-phase and --falover options +The --two

Re: pg_recvlogical cannot create slots with failover=true

2025-04-04 Thread Michael Banck
Hi, On Tue, Apr 01, 2025 at 08:01:32AM +, Hayato Kuroda (Fujitsu) wrote: > Attached patch implements it. Since -f/-F option has already been used, -O was > chosen for the short-version. Better idea is very welcomed. Maybe we don't need a short option at all for this, at least initially? Mic

Re: pg_recvlogical cannot create slots with failover=true

2025-04-04 Thread Masahiko Sawada
On Thu, Apr 3, 2025 at 8:28 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Sawada-san, > > > Thank you for updating the patch. Here are some minor comments: > > > > The --two-phase can be specified with > > --create-slot to enable decoding of prepared > > transactions. > > +A

RE: pg_recvlogical cannot create slots with failover=true

2025-04-03 Thread Hayato Kuroda (Fujitsu)
Dear Sawada-san, > Thank you for updating the patch. Here are some minor comments: > > The --two-phase can be specified with > --create-slot to enable decoding of prepared > transactions. > +Also, --falover can be specified with > +--create-slot to create replica

Re: pg_recvlogical cannot create slots with failover=true

2025-04-03 Thread Masahiko Sawada
On Wed, Apr 2, 2025 at 11:57 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Michael, > > > Maybe we don't need a short option at all for this, at least initially? > > Indeed, updated. Thank you for updating the patch. Here are some minor comments: The --two-phase can be specified with

RE: pg_recvlogical cannot create slots with failover=true

2025-04-02 Thread Hayato Kuroda (Fujitsu)
Dear Michael, > Maybe we don't need a short option at all for this, at least initially? Indeed, updated. Best regards, Hayato Kuroda FUJITSU LIMITED v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch Description: v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch