Re: Remaining calls of heap_close/heap_open in the tree

2019-10-18 Thread Michael Paquier
On Fri, Oct 18, 2019 at 10:03:11AM +0900, Michael Paquier wrote: > Not sure that's worth the trouble. If there are no objections, I will > remove the compatibility macros. Okay, cleanup done with the compatibility macros removed. -- Michael signature.asc Description: PGP signature

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Michael Paquier
On Thu, Oct 17, 2019 at 12:34:44PM +0100, Dagfinn Ilmari Mannsåker wrote: > Would it be possible to wrap them in some #if(n)def guard so that > they're available when building out-of-tree extensions, but not when > building postgres itself? Not sure that's worth the trouble. If there are no objec

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Dagfinn Ilmari Mannsåker
Andres Freund writes: > Hi, > > On 2019-10-17 06:58:27 -0300, Alvaro Herrera wrote: >> On 2019-Oct-17, Michael Paquier wrote: >> >> > On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote: >> > > Wonder if it's worth removing the backward compat ones from master? I >> > > don't quite thi

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Andres Freund
Hi, On 2019-10-17 06:58:27 -0300, Alvaro Herrera wrote: > On 2019-Oct-17, Michael Paquier wrote: > > > On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote: > > > Wonder if it's worth removing the backward compat ones from master? I > > > don't quite think so, but... > > > > I would vot

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Alvaro Herrera
On 2019-Oct-17, Michael Paquier wrote: > On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote: > > Wonder if it's worth removing the backward compat ones from master? I > > don't quite think so, but... > > I would vote for the removal so as we'll never see that again in > core. Let's se

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Michael Paquier
On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote: > Wonder if it's worth removing the backward compat ones from master? I > don't quite think so, but... I would vote for the removal so as we'll never see that again in core. Let's see what others think here. -- Michael signature.asc

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Tom Lane
Andres Freund writes: > On 2019-10-17 10:47:06 +0900, Michael Paquier wrote: >> I have just bumped into $subject, and we now use the table_* >> equivalents in the code. Any objections to the simple patch attached >> to clean up that? > They're not really "remaining", as much as having been intro

Re: Remaining calls of heap_close/heap_open in the tree

2019-10-17 Thread Andres Freund
Hi, On 2019-10-17 10:47:06 +0900, Michael Paquier wrote: > I have just bumped into $subject, and we now use the table_* > equivalents in the code. Any objections to the simple patch attached > to clean up that? They're not really "remaining", as much as having been introduced after the introduct