Re: Minor typo in generate_useful_gather_paths comment

2021-07-05 Thread David Rowley
On Tue, 6 Jul 2021 at 06:55, James Coleman wrote: > While re-reading this code I found a small typo and fixed it (making > the comment more explicit at the same time). Thanks. Pushed (9ee91cc58). David

Re: Minor typo

2018-12-06 Thread Stephen Frost
Greetings, * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote: > At Tue, 4 Dec 2018 11:37:16 -0500, Stephen Frost wrote > in <20181204163716.gr3...@tamriel.snowman.net> > > Thanks to everyone for sharing their thoughts here, the goal is simply > > to try and have the comments as clear a

Re: Minor typo

2018-12-05 Thread Kyotaro HORIGUCHI
At Tue, 4 Dec 2018 11:37:16 -0500, Stephen Frost wrote in <20181204163716.gr3...@tamriel.snowman.net> > Thanks to everyone for sharing their thoughts here, the goal is simply > to try and have the comments as clear as we can for everyone. > > Please find attached a larger rewording of the commen

Re: Minor typo

2018-12-04 Thread Stephen Frost
Greetings, * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote: > At Wed, 28 Nov 2018 10:01:36 +0900, Michael Paquier > wrote in <20181128010136.gu1...@paquier.xyz> > > On Tue, Nov 27, 2018 at 07:51:03PM -0500, Stephen Frost wrote: > > > That isn't at all what I got from that. > > > > >

Re: minor typo in dsa.c

2018-11-28 Thread Thomas Munro
On Thu, Nov 29, 2018 at 1:40 PM Ideriha, Takeshi wrote: > I found a minor typo in dsa.c. > > s/set_dsa_size_limit/dsa_set_size_limit/ Thanks! Pushed. -- Thomas Munro http://www.enterprisedb.com

Re: Minor typo

2018-11-27 Thread Kyotaro HORIGUCHI
This is a noise from a Japanese having poor English skill.. At Wed, 28 Nov 2018 10:01:36 +0900, Michael Paquier wrote in <20181128010136.gu1...@paquier.xyz> > On Tue, Nov 27, 2018 at 07:51:03PM -0500, Stephen Frost wrote: > > That isn't at all what I got from that. > > > > A rewrite of this rea

Re: Minor typo

2018-11-27 Thread Michael Paquier
On Tue, Nov 27, 2018 at 07:51:03PM -0500, Stephen Frost wrote: > That isn't at all what I got from that. > > A rewrite of this really should avoid talking about removing the hole as > if it's 'compression' because, first of all, it isn't, and second, now > that we have *actual* compression happeni

Re: Minor typo

2018-11-27 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Nov 27, 2018 at 07:18:39PM -0500, Tom Lane wrote: > > * When wal_compression is enabled and a "hole" is removed from a full > > * page image, the page image is compressed using PGLZ compression. > > > > (BTW, is this trying t

Re: Minor typo

2018-11-27 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Daniel Gustafsson writes: > >> On 28 Nov 2018, at 00:43, Stephen Frost wrote: > >> Sending it here in case anyone feels that we should do more than just > >> correct the word..? Perhaps for non-native English speakers seeing > >> "whose" used

Re: Minor typo

2018-11-27 Thread Michael Paquier
On Tue, Nov 27, 2018 at 07:18:39PM -0500, Tom Lane wrote: > * When wal_compression is enabled and a "hole" is removed from a full > * page image, the page image is compressed using PGLZ compression. > > (BTW, is this trying to say that we don't apply compression if the page > contains no hole?

Re: Minor typo

2018-11-27 Thread Tom Lane
Daniel Gustafsson writes: >> On 28 Nov 2018, at 00:43, Stephen Frost wrote: >> Sending it here in case anyone feels that we should do more than just >> correct the word..? Perhaps for non-native English speakers seeing >> "whose" used here is confusing? > Being a non-native English speaker I th

Re: Minor typo

2018-11-27 Thread Daniel Gustafsson
> On 28 Nov 2018, at 00:43, Stephen Frost wrote: > Sending it here in case anyone feels that we should do more than just > correct the word..? Perhaps for non-native English speakers seeing > "whose" used here is confusing? Being a non-native English speaker I think it’s fine and, in my own bia