On Tue, Nov 27, 2018 at 07:51:03PM -0500, Stephen Frost wrote: > That isn't at all what I got from that. > > A rewrite of this really should avoid talking about removing the hole as > if it's 'compression' because, first of all, it isn't, and second, now > that we have *actual* compression happening, it's terribly confusing to > talk about removing the hole using that terminology.
You may want to be careful about other comments in xloginsert.c or such then. Removing a page hole is mentioned in a couple of places as a form of compression if I recall correctly. -- Michael
signature.asc
Description: PGP signature
