Re: Correct comment in StartupXLOG().

2021-02-05 Thread Michael Paquier
On Fri, Feb 05, 2021 at 02:42:57PM +0530, Amul Sul wrote: > Alright, that too looks good. Thank you ! Thanks, Amul. I have applied this one. -- Michael signature.asc Description: PGP signature

Re: Correct comment in StartupXLOG().

2021-02-05 Thread Amul Sul
On Fri, Feb 5, 2021 at 11:53 AM Michael Paquier wrote: > > On Thu, Feb 04, 2021 at 12:58:29PM +0530, Dilip Kumar wrote: > > Looks good to me. > > Rather than using the term "recovery state", I would just use > SharedRecoveryState. This leads me to the attached. Alright, that too looks good. Tha

Re: Correct comment in StartupXLOG().

2021-02-04 Thread Michael Paquier
On Thu, Feb 04, 2021 at 12:58:29PM +0530, Dilip Kumar wrote: > Looks good to me. Rather than using the term "recovery state", I would just use SharedRecoveryState. This leads me to the attached. -- Michael diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index f0

Re: Correct comment in StartupXLOG().

2021-02-03 Thread Dilip Kumar
On Thu, Feb 4, 2021 at 9:39 AM Amul Sul wrote: > > On Thu, Feb 4, 2021 at 6:18 AM Kyotaro Horiguchi > wrote: > > > > At Wed, 3 Feb 2021 16:36:13 +0530, Amul Sul wrote in > > > On Wed, Feb 3, 2021 at 2:48 PM Dilip Kumar wrote: > > > > > > > > On Wed, Feb 3, 2021 at 2:28 PM Amul Sul wrote: > > >

Re: Correct comment in StartupXLOG().

2021-02-03 Thread Amul Sul
On Thu, Feb 4, 2021 at 6:18 AM Kyotaro Horiguchi wrote: > > At Wed, 3 Feb 2021 16:36:13 +0530, Amul Sul wrote in > > On Wed, Feb 3, 2021 at 2:48 PM Dilip Kumar wrote: > > > > > > On Wed, Feb 3, 2021 at 2:28 PM Amul Sul wrote: > > > > > > > > Hi, > > > > > > > > SharedRecoveryState member of XLo

Re: Correct comment in StartupXLOG().

2021-02-03 Thread Kyotaro Horiguchi
At Wed, 3 Feb 2021 16:36:13 +0530, Amul Sul wrote in > On Wed, Feb 3, 2021 at 2:48 PM Dilip Kumar wrote: > > > > On Wed, Feb 3, 2021 at 2:28 PM Amul Sul wrote: > > > > > > Hi, > > > > > > SharedRecoveryState member of XLogCtl is no longer a boolean flag, got > > > changes > > > in 4e87c4836ab9

Re: Correct comment in StartupXLOG().

2021-02-03 Thread Amul Sul
On Wed, Feb 3, 2021 at 2:48 PM Dilip Kumar wrote: > > On Wed, Feb 3, 2021 at 2:28 PM Amul Sul wrote: > > > > Hi, > > > > SharedRecoveryState member of XLogCtl is no longer a boolean flag, got > > changes > > in 4e87c4836ab9 to enum but, comment referring to it still referred as the > > boolean f

Re: Correct comment in StartupXLOG().

2021-02-03 Thread Dilip Kumar
On Wed, Feb 3, 2021 at 2:28 PM Amul Sul wrote: > > Hi, > > SharedRecoveryState member of XLogCtl is no longer a boolean flag, got changes > in 4e87c4836ab9 to enum but, comment referring to it still referred as the > boolean flag which is pretty confusing and incorrect. +1 for the comment change