On Wed, Feb 3, 2021 at 2:28 PM Amul Sul <sula...@gmail.com> wrote: > > Hi, > > SharedRecoveryState member of XLogCtl is no longer a boolean flag, got changes > in 4e87c4836ab9 to enum but, comment referring to it still referred as the > boolean flag which is pretty confusing and incorrect.
+1 for the comment change > Also, the last part of the same comment is as: > > " .. although the boolean flag to allow WAL is probably atomic in > itself, .....", > > I am a bit confused here too about saying "atomic" to it, is that correct? > I haven't done anything about it, only replaced the "boolean flag" to > "recovery > state" in the attached patch. I don't think the atomic is correct, it's no more boolean so it is better we get rid of this part of the comment -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
