Re: Added missing invalidations for all tables publication

2021-09-12 Thread Amit Kapila
On Sat, Sep 11, 2021 at 11:58 PM Tom Lane wrote: > > Amit Kapila writes: > > On Wed, Sep 8, 2021 at 7:57 AM houzj.f...@fujitsu.com > > wrote: > >> I found that the patch cannot be applied to back-branches(v10-v14) cleanly, > >> so, I generate the patches for back-branches. Attached, all the patc

Re: Added missing invalidations for all tables publication

2021-09-11 Thread Tom Lane
Amit Kapila writes: > On Wed, Sep 8, 2021 at 7:57 AM houzj.f...@fujitsu.com > wrote: >> I found that the patch cannot be applied to back-branches(v10-v14) cleanly, >> so, I generate the patches for back-branches. Attached, all the patches have >> passed regression test. > Pushed! Shouldn't the

Re: Added missing invalidations for all tables publication

2021-09-08 Thread Amit Kapila
On Wed, Sep 8, 2021 at 7:57 AM houzj.f...@fujitsu.com wrote: > > > From Mon, Sep 6, 2021 1:56 PM Amit Kapila wrote: > > > On Tue, Aug 31, 2021 at 8:54 PM vignesh C wrote: > > > > Thanks for the comments, the attached v3 patch has the changes for > > > > the same. > > > > > > > > > > I think this

RE: Added missing invalidations for all tables publication

2021-09-07 Thread houzj.f...@fujitsu.com
> From Mon, Sep 6, 2021 1:56 PM Amit Kapila wrote: > > On Tue, Aug 31, 2021 at 8:54 PM vignesh C wrote: > > > Thanks for the comments, the attached v3 patch has the changes for > > > the same. > > > > > > > I think this bug should be fixed in back branches (till v10). OTOH, as > > this is not rep

RE: Added missing invalidations for all tables publication

2021-09-07 Thread houzj.f...@fujitsu.com
From Mon, Sep 6, 2021 1:56 PM Amit Kapila wrote: > On Tue, Aug 31, 2021 at 8:54 PM vignesh C wrote: > > Thanks for the comments, the attached v3 patch has the changes for the > > same. > > > > I think this bug should be fixed in back branches (till v10). OTOH, as this > is not > reported by an

Re: Added missing invalidations for all tables publication

2021-09-05 Thread Amit Kapila
On Tue, Aug 31, 2021 at 8:54 PM vignesh C wrote: > > On Tue, Aug 31, 2021 at 2:00 PM Kyotaro Horiguchi > wrote: > > > > Thanks for the comments, the attached v3 patch has the changes for the same. > I think this bug should be fixed in back branches (till v10). OTOH, as this is not reported by an

Re: Added missing invalidations for all tables publication

2021-08-31 Thread vignesh C
On Tue, Aug 31, 2021 at 2:00 PM Kyotaro Horiguchi wrote: > > At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C wrote in > > On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com > > wrote: > > Thanks for the comment, I have slightly modified the test case which > > will fail without the patch. Atta

Re: Added missing invalidations for all tables publication

2021-08-31 Thread Kyotaro Horiguchi
At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C wrote in > On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com > wrote: > Thanks for the comment, I have slightly modified the test case which > will fail without the patch. Attached v2 patch which has the changes > for the same. The test works f

Re: Added missing invalidations for all tables publication

2021-08-30 Thread vignesh C
On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com wrote: > > From Tuesday, August 31, 2021 1:10 AM vignesh C wrote: > > Hi, > > > > Relation invalidation was missing in case of create publication and drop > > publication of "FOR ALL TABLES" publication, added so that the publication > > info

RE: Added missing invalidations for all tables publication

2021-08-30 Thread houzj.f...@fujitsu.com
From Tuesday, August 31, 2021 1:10 AM vignesh C wrote: > Hi, > > Relation invalidation was missing in case of create publication and drop > publication of "FOR ALL TABLES" publication, added so that the publication > information can be rebuilt. Without these invalidation update/delete > operation