From Tuesday, August 31, 2021 1:10 AM vignesh C <vignes...@gmail.com> wrote: > Hi, > > Relation invalidation was missing in case of create publication and drop > publication of "FOR ALL TABLES" publication, added so that the publication > information can be rebuilt. Without these invalidation update/delete > operations on the relation will be successful in the publisher which will > later > result in conflict in the subscriber. > Thanks to Amit for identifying the issue at [1]. Attached patch has the fix > for the > same. > Thoughts?
I have one comment about the testcase in the patch. +-- Test cache invalidation FOR ALL TABLES publication +SET client_min_messages = 'ERROR'; +CREATE TABLE testpub_tbl4(a int); +CREATE PUBLICATION testpub_foralltables FOR ALL TABLES; +RESET client_min_messages; +-- fail missing REPLICA IDENTITY +UPDATE testpub_tbl4 set a = 2; +ERROR: cannot update table "testpub_tbl4" because it does not have a replica identity and publishes updates +HINT: To enable updating the table, set REPLICA IDENTITY using ALTER TABLE. +DROP PUBLICATION testpub_foralltables; The above testcases can pass without the code change in the patch, is it better to add a testcase which can show different results after applying the patch ? Best regards, Hou zj
