{
"emoji": "🙏",
"version": 1
}
On 2025/01/17 17:46, Ryo Kanbayashi wrote:
So, will you give creating the patch a try?
Yes. I try to write the patch for regression test of ecpg command
warning and error notice :)
Thanks!
BTW, How should we handle commit fest entry below?
"ecpg command does not warn COPY ... FROM STDIN
On Wed, Jan 15, 2025 at 1:34 AM Fujii Masao wrote:
>
>
>
> On 2025/01/12 18:27, Ryo Kanbayashi wrote:
> > Thank you for reviewing patch :)
> > The commit log matches with my recognition and has no problem.
>
> Pushed. Thanks!
>
> >>> check_patches.sh -> utility script for testing above two patches
On 2025/01/12 18:27, Ryo Kanbayashi wrote:
Thank you for reviewing patch :)
The commit log matches with my recognition and has no problem.
Pushed. Thanks!
check_patches.sh -> utility script for testing above two patches on
each target branches
Should we add a regression test to ensure ec
On Sun, Jan 12, 2025 at 12:56 PM Fujii Masao
wrote:
>
>
>
> On 2025/01/12 2:04, Ryo Kanbayashi wrote:
> > I wrote a patch for release v13 - v17 additionally and tested it for
> > each release branch :)
> > As a result, two patch is needed for this fix.
>
> Thanks for the patches! Barring any objec
On 2025/01/12 2:04, Ryo Kanbayashi wrote:
I wrote a patch for release v13 - v17 additionally and tested it for
each release branch :)
As a result, two patch is needed for this fix.
Thanks for the patches! Barring any objections,
I plan to commit them with the following commit log.
-
> On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi
> wrote:
>
> > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > Dear Tom, Fujii-san, Kuroda-san,
> > >
> > > I saw comments of yours and recognized that better fix is below.
> > >
> > > - Fix of first attached patch which does not change warning mes
On Fri, Jan 10, 2025 at 5:45 PM Ryo Kanbayashi wrote:
>
> On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi
> wrote:
> >
> > > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > > Dear Tom, Fujii-san, Kuroda-san,
> > > >
> > > > I saw comments of yours and recognized that better fix is below.
> > > >
On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi wrote:
>
> > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > Dear Tom, Fujii-san, Kuroda-san,
> > >
> > > I saw comments of yours and recognized that better fix is below.
> > >
> > > - Fix of first attached patch which does not change warning message
> On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > Dear Tom, Fujii-san, Kuroda-san,
> >
> > I saw comments of yours and recognized that better fix is below.
> >
> > - Fix of first attached patch which does not change warning message
> >
> > And I created patch entry of commitfest :)
> > https://commi
On 2025/01/09 20:34, Ryo Kanbayashi wrote:
Dear Tom, Fujii-san, Kuroda-san,
I saw comments of yours and recognized that better fix is below.
- Fix of first attached patch which does not change warning message
And I created patch entry of commitfest :)
https://commitfest.postgresql.org/52/54
Dear Tom, Fujii-san, Kuroda-san,
I saw comments of yours and recognized that better fix is below.
- Fix of first attached patch which does not change warning message
And I created patch entry of commitfest :)
https://commitfest.postgresql.org/52/5497/
What should I do additionally?
Do I need to
Dear Tom, Fujii-san,
> > ISTM that ecpg supports COPY TO STDOUT and includes the regression test
> "copystdout" for it. No?
>
> Oh right. (Pokes at it...) It looks like the backend accepts
> "FROM STDOUT" as a synonym for "FROM STDIN", so that's why this
> is checking for both spellings. But I
Fujii Masao writes:
> On 2025/01/09 0:42, Tom Lane wrote:
>> There's another problem: the correct syntax is COPY TO STDOUT,
>> and that won't trigger this warning either.
> ISTM that ecpg supports COPY TO STDOUT and includes the regression test
> "copystdout" for it. No?
Oh right. (Pokes at it
On 2025/01/09 0:42, Tom Lane wrote:
Fujii Masao writes:
On 2025/01/08 23:04, Ryo Kanbayashi wrote:
But it is not working.
ecpg command fails to notice though code like above exits on pgc code.
This issue seems to have been introduced in commit 3d009e45bd.
Indeed :-(
As for COPY FROM S
Fujii Masao writes:
> On 2025/01/08 23:04, Ryo Kanbayashi wrote:
> But it is not working.
> ecpg command fails to notice though code like above exits on pgc code.
> This issue seems to have been introduced in commit 3d009e45bd.
Indeed :-(
> As for COPY FROM STDOUT, while it's possible, mentioni
On 2025/01/08 23:04, Ryo Kanbayashi wrote:
But it is not working.
ecpg command fails to notice though code like above exits on pgc code.
This issue seems to have been introduced in commit 3d009e45bd. Before that,
as per my testing, ecpg successfully detected COPY FROM STDIN and reported
a wa
Kuroda-san, thank to your comment.
> > I found a code validation bug in master branch.
> >
> > Now, ecpg does not support 'EXEC SQL COPY ... FROM STDIN ... ;' and
> > code for warning it exits.
> >
> > https://github.com/postgres/postgres/blob/7b27f5fd36cb3270e8ac25aefd73b55
> > 2663d1392/src/inte
Dear Kanbayashi-san,
> I found a code validation bug in master branch.
>
> Now, ecpg does not support 'EXEC SQL COPY ... FROM STDIN ... ;' and
> code for warning it exits.
>
> https://github.com/postgres/postgres/blob/7b27f5fd36cb3270e8ac25aefd73b55
> 2663d1392/src/interfaces/ecpg/preproc/ecpg.a
19 matches
Mail list logo
