Re: Minor cleanups in the SSL tests

2024-09-03 Thread Daniel Gustafsson
> On 17 May 2024, at 09:58, Daniel Gustafsson wrote: > >> On 17 May 2024, at 07:57, Peter Eisentraut wrote: >> >> On 16.05.24 23:27, Daniel Gustafsson wrote: On 16 May 2024, at 11:43, Peter Eisentraut wrote: You might want to run your patch through pgperltidy. The result doesn't >>

Re: Minor cleanups in the SSL tests

2024-05-17 Thread Daniel Gustafsson
> On 17 May 2024, at 07:57, Peter Eisentraut wrote: > > On 16.05.24 23:27, Daniel Gustafsson wrote: >>> On 16 May 2024, at 11:43, Peter Eisentraut wrote: >>> You might want to run your patch through pgperltidy. The result doesn't >>> look bad, but a bit different than what you had crafted. >>

Re: Minor cleanups in the SSL tests

2024-05-16 Thread Peter Eisentraut
On 16.05.24 23:27, Daniel Gustafsson wrote: On 16 May 2024, at 11:43, Peter Eisentraut wrote: You might want to run your patch through pgperltidy. The result doesn't look bad, but a bit different than what you had crafted. Ugh, I thought I had but clearly had forgotten. Fixed now. appen

Re: Minor cleanups in the SSL tests

2024-05-16 Thread Daniel Gustafsson
> On 16 May 2024, at 11:43, Peter Eisentraut wrote: > You might want to run your patch through pgperltidy. The result doesn't look > bad, but a bit different than what you had crafted. Ugh, I thought I had but clearly had forgotten. Fixed now. > append_conf() opens and closes the file for eac

Re: Minor cleanups in the SSL tests

2024-05-16 Thread Peter Eisentraut
On 16.05.24 09:24, Daniel Gustafsson wrote: When writing a new SSL test for another patch it struck me that the SSL tests are doing configuration management without using the test framework API's. The attached patches cleans this up, no testcases are altered as part of this. 0001 makes the test

Minor cleanups in the SSL tests

2024-05-16 Thread Daniel Gustafsson
When writing a new SSL test for another patch it struck me that the SSL tests are doing configuration management without using the test framework API's. The attached patches cleans this up, no testcases are altered as part of this. 0001 makes the test for PG_TEST_EXTRA a top-level if statement no