> On 17 May 2024, at 09:58, Daniel Gustafsson <dan...@yesql.se> wrote: > >> On 17 May 2024, at 07:57, Peter Eisentraut <pe...@eisentraut.org> wrote: >> >> On 16.05.24 23:27, Daniel Gustafsson wrote: >>>> On 16 May 2024, at 11:43, Peter Eisentraut <pe...@eisentraut.org> wrote: >>>> You might want to run your patch through pgperltidy. The result doesn't >>>> look bad, but a bit different than what you had crafted. >>> Ugh, I thought I had but clearly had forgotten. Fixed now. >>>> append_conf() opens and closes the file for each call. It might be nice >>>> if it could accept a list. Or you can just pass the whole block as one >>>> string, like it was done for pg_ident.conf before. >>> The attached v2 pass the whole block as a here-doc which seemed like the >>> best >>> option to retain readability of the config. >> >> Works for me. > > Thanks for review. Once the tree opens up for v18 I'll go ahead with this.
This has now been pushed after a little bit of editorializing and another pgperltidy run. -- Daniel Gustafsson
