Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-07-15 Thread Jelte Fennema-Nio
On Mon, 14 Jul 2025 at 23:27, Aleksander Alekseev wrote: > Many thanks. I also noticed that cfbot doesn't show entries from the > *upcoming* commitfest. I believe it did before and according to the CF > application CI checks are executed for these patches, just not shown > on cfbot. Is it intentio

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-07-14 Thread Aleksander Alekseev
Hi, > > It seems like cfbot.cputube.org started to miss a *few* entries since > > CF started. Does it have anything to do with the CF application > > update? > > That's fixed now. Many thanks. I also noticed that cfbot doesn't show entries from the *upcoming* commitfest. I believe it did before a

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-07-02 Thread Jelte Fennema-Nio
On Wed, 2 Jul 2025 at 12:02, Aleksander Alekseev wrote: > It seems like cfbot.cputube.org started to miss a *few* entries since > CF started. Does it have anything to do with the CF application > update? That's fixed now.

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-07-02 Thread Aleksander Alekseev
Hi, > > > Ugh... Turns out it was a bug, there definitely should be a "New > > > patch" button on both the 19-1 and on the Drafts page. And there > > > was... but only if you were logged in as a staff user. > > > > There is now a "New patch" button on the CF entry page. Many thanks! > > I felt we

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-07-01 Thread vignesh C
On Thu, 26 Jun 2025 at 03:21, Aleksander Alekseev wrote: > > Hi, > > > Ugh... Turns out it was a bug, there definitely should be a "New > > patch" button on both the 19-1 and on the Drafts page. And there > > was... but only if you were logged in as a staff user. > > There is now a "New patch" but

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-25 Thread Aleksander Alekseev
Hi, > Ugh... Turns out it was a bug, there definitely should be a "New > patch" button on both the 19-1 and on the Drafts page. And there > was... but only if you were logged in as a staff user. There is now a "New patch" button on the CF entry page. Many thanks! > I had changed a field name to

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-25 Thread David G. Johnston
On Wed, Jun 25, 2025 at 10:56 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi, > > > > The new PG19 development cycle is starting soon. So that seemed like a > > > good excuse to make some big improvements to the commitfest app. > > > > These changes have now been deployed to produc

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-25 Thread Jelte Fennema-Nio
On Wed, 25 Jun 2025 at 20:29, Aleksander Alekseev wrote: > > Hi, > > > Fourth link down from the top of the link section - "Create a new > > commitfest entry" > > > > Adds it to 19-1; need to move it to Drafts if that is where it belongs. > > Found it. It was moved to the "Your personal dashboard

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-25 Thread Aleksander Alekseev
Hi, > Fourth link down from the top of the link section - "Create a new commitfest > entry" > > Adds it to 19-1; need to move it to Drafts if that is where it belongs. Found it. It was moved to the "Your personal dashboard" page. Previously I used the CF page thus I couldn't find it. Many thank

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-25 Thread Aleksander Alekseev
Hi, > > The new PG19 development cycle is starting soon. So that seemed like a > > good excuse to make some big improvements to the commitfest app. > > These changes have now been deployed to production. Please report any > problems, either as a reply or as a github issue. Firstly, many thanks fo

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-24 Thread David G. Johnston
; for Drafts the tag colors for Pg19-Drafts and PG19-1 are identical. They need to be different. When creating a new patch it should either be placed in Drafts first, and then moved if appropriate, or the user should choose (and be given an explanation of the decision factors behind that choi

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-23 Thread Jelte Fennema-Nio
On Mon, 23 Jun 2025 at 03:37, Tatsuo Ishii wrote: > And I found "Author" column is shown as "+4207-35" which does not seem > to be an author name. Likewise followings columns seem to show > inappropriate contents. Thanks for the report. That's fixed now (it was missing a header column for the new

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Tatsuo Ishii
> On Mon, 23 Jun 2025 at 03:37, Tatsuo Ishii wrote: >> And I found "Author" column is shown as "+4207-35" which does not seem >> to be an author name. Likewise followings columns seem to show >> inappropriate contents. > > Thanks for the report. That's fixed now (it was missing a header > column

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Tatsuo Ishii
> Sounds good to me. Unless there are big objections, I'll deploy this > on the 23rd. Sorry if this has been already reported or fixed. I tried "Personal Dashboard". https://commitfest.postgresql.org/me/ And I found "Author" column is shown as "+4207-35" which does not seem to be an author name.

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Jelte Fennema-Nio
On Sun, 22 Jun 2025 at 15:47, Peter Eisentraut wrote: > I don't know about this. This could become an ongoing source of > confusion, without any clear benefit. Either the draft and the "real" > commitfest are going to be indistinguishable, because they are just two > places to look for stuff to

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Jelte Fennema-Nio
On Mon, 16 Jun 2025 at 14:47, Jelte Fennema-Nio wrote: > > The new PG19 development cycle is starting soon. So that seemed like a > good excuse to make some big improvements to the commitfest app. These changes have now been deployed to production. Please report any problems, either as a reply or

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread David G. Johnston
her >> absent our policy they would mark it ready to commit or not. If they >> believe it is it should be moved to open, if no, it should remain in >> drafts. This is mostly like what happens today but with a clear >> delineation between reviews to help and reviews to ap

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Vik Fearing
to help and reviews to approve commit-ability. Otherwise, it’s a place where author patches can sit without having to be bumped to the next cf every other month and where an author patch can be ignored by everyone else not authoring it. I don't know about this. 

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-22 Thread Peter Eisentraut
what happens today but with a clear delineation between reviews to help and reviews to approve commit-ability. Otherwise, it’s a place where author patches can sit without having to be bumped to the next cf every other month and where an author patch can be ignored by everyone else not authoring

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-20 Thread David G. Johnston
would mark it ready to commit or not. If they believe it is it should be moved to open, if no, it should remain in drafts. This is mostly like what happens today but with a clear delineation between reviews to help and reviews to approve commit-ability. Otherwise, it’s a place where author patches

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-20 Thread Peter Eisentraut
On 16.06.25 14:47, Jelte Fennema-Nio wrote: # Draft CF There's now an additional Draft CF. People can move patches there as a way of not forgetting about them. CFBot will rerun these patches less frequently (exact behaviour TBD). Draft CFs are never "In Progress" and are open until the final CF

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-19 Thread Peter Eisentraut
On 18.06.25 22:57, Robert Treat wrote: I also wondered why you differentiated SQL script file vs archive in the change here: - of a cluster into an archive. The archive contains + of a cluster into an SQL script file or an archive. The output contains but then did not differentiate them h

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-18 Thread Robert Treat
On Tue, Jun 17, 2025 at 3:32 AM Peter Eisentraut wrote: > On 10.06.25 13:51, Ashutosh Bapat wrote: > > Since we are using "a PostgreSQL database" and "a PostgreSQL cluster" > > with pg_dump and pg_dumpall respectively, it makes sense to use the same > > wording for pg_restore. Th description at [1

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-18 Thread Jelte Fennema-Nio
On Wed, 18 Jun 2025 at 05:58, Peter Eisentraut wrote: > Can you explain the motivation for this change a bit more? A few main reasons (from important to unimportant): 1. For new/irregular contributors the old names were really not obvious IMO. It took me 3+ years to get the mental association wit

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-17 Thread Peter Eisentraut
On 16.06.25 14:47, Jelte Fennema-Nio wrote: And our already well-known commitfests for PG19 will be called as follows: - PG19-1 (previously 2025-07) - PG19-2 (previously 2025-09) - PG19-3 (previously 2025-11) - PG19-4 (previously 2026-01) - PG19-Final (previously 2026-03) The dates will be the

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-17 Thread Jelte Fennema-Nio
On Tue, 17 Jun 2025 at 06:21, Ashutosh Bapat wrote: > I like this as well. I feel "In Progress" doesn't convey that the > column contains the dates when the CFs are active. It can be easily > confused with "In progress" CF. How about just "Dates" or "Duration"? I decided to overhaul the table a b

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-17 Thread Peter Eisentraut
On 10.06.25 08:59, Peter Eisentraut wrote: The pg_dump and pg_dumpall help synopses could use some refinements. Here is a concrete patch.From 3e92c4ef2502e2664478423f2bcd1fbf59b8e7fd Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 17 Jun 2025 09:39:17 +0200 Subject: [PATCH] Improve

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-17 Thread Peter Eisentraut
On 10.06.25 13:51, Ashutosh Bapat wrote: Since we are using "a PostgreSQL database" and "a PostgreSQL cluster" with pg_dump and pg_dumpall respectively, it makes sense to use the same wording for pg_restore. Th description at [1] already does that, except it needs small tweaks like below: pg_

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-17 Thread Jelte Fennema-Nio
On Tue, 17 Jun 2025 at 06:41, Tom Lane wrote: > Yeah. I think it might be smarter to push these changes a bit earlier > than the 30th, maybe by a week? Better to file down any rough edges > before we start the new CF. Sounds good to me. Unless there are big objections, I'll deploy this on the 2

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-16 Thread Tom Lane
Ashutosh Bapat writes: > On Mon, Jun 16, 2025 at 6:48 PM Jelte Fennema-Nio wrote: >> The new PG19 development cycle is starting soon. So that seemed like a >> good excuse to make some big improvements to the commitfest app. My >> plan is to deploy these changes on the 30th of June. > Coinciding

Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-16 Thread Ashutosh Bapat
On Mon, Jun 16, 2025 at 6:48 PM Jelte Fennema-Nio wrote: > > The new PG19 development cycle is starting soon. So that seemed like a > good excuse to make some big improvements to the commitfest app. My > plan is to deploy these changes on the 30th of June. So that we can > start the new cycle fres

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-10 Thread Ashutosh Bapat
Hi Peter, On Tue, Jun 10, 2025 at 12:29 PM Peter Eisentraut wrote: > How about this to bring it all together: > > pg_dump --help: > pg_dump exports a PostgreSQL database as an SQL script or to other formats. > > pg_dumpall --help: > pg_dumpall exports a PostgreSQL datab

pg_dump/pg_dumpall help synopses and terminology

2025-06-10 Thread Peter Eisentraut
The pg_dump and pg_dumpall help synopses could use some refinements. PG17: pg_dump --help: pg_dump dumps a database as a text file or to other formats. pg_dumpall --help: pg_dumpall extracts a PostgreSQL database cluster into an SQL script file. man pages: pg_dump - extract a PostgreSQL

get speed help

2025-05-29 Thread David G. Johnston
On Thursday, May 29, 2025, Dias Thomas wrote: > Hi all, > if 2 records per second, add speed, 4 gb ram, 1 index, is it > faster than postgres? > > Why didn’t you just reply to the people who answered you on -general when you asked this same “question”? This is a list for discussing the de

get speed help

2025-05-29 Thread Dias Thomas
Hi all, if 2 records per second, add speed, 4 gb ram, 1 index, is it faster than postgres?

Re: HELP: SAVEPOINT feature cases

2025-04-15 Thread Greg Sabino Mullane
> > I am writing to inquire about the use cases for the SAVEPOINT feature. > Savepoints are used to implement ON_ERROR_ROLLBACK in psql. See: https://www.endpointdev.com/blog/2015/02/postgres-onerrorrollback-explained/ Cheers, Greg -- Crunchy Data - https://www.crunchydata.com Enterprise Postgre

HELP: SAVEPOINT feature cases

2025-04-14 Thread itumonohito
Dear hackers, I hope this email finds you well. I am writing to inquire about the use cases for the SAVEPOINT feature. I would appreciate it if you could provide some examples of scenarios where this functionality proves particularly useful. Thank you for your time and assistance. I look forwar

Re: HELP: SAVEPOINT feature cases

2025-04-14 Thread Kirill Reshke
On Mon, 14 Apr 2025 at 21:54, itumonohito wrote: > > Dear hackers, > > I hope this email finds you well. > > I am writing to inquire about the use cases for the SAVEPOINT feature. > > I would appreciate it if you could provide some examples of scenarios where > this functionality proves particula

Re: Adding comments to help understand psql hidden queries

2025-03-31 Thread Maiquel Grassi
Hi! I have read the discussion and would like to share my humble opinion. I believe that a visually appealing way to display the output on the screen is to ensure symmetry in the length of asterisks and description lines. I imagine someone looking at the screen and focusing on symmetrical details.

Re: Adding comments to help understand psql hidden queries

2025-03-31 Thread Maiquel Grassi
Hi! I have read the discussion and would like to share my humble opinion. I believe that a visually appealing way to display the output on the screen is to ensure symmetry in the length of asterisks and description lines. I imagine someone looking at the screen and focusing on symmetrical details.

Re: Adding comments to help understand psql hidden queries

2025-01-30 Thread David Christensen
On Sat, Jan 18, 2025 at 2:37 PM Tom Lane wrote: > > David Christensen writes: > > Any further concerns/issues with this patch that I can address to help > > move it forward? > > I got around to looking at this finally --- sorry that it's been on > the back burn

Re: Adding comments to help understand psql hidden queries

2025-01-18 Thread Tom Lane
David Christensen writes: > Any further concerns/issues with this patch that I can address to help > move it forward? I got around to looking at this finally --- sorry that it's been on the back burner for so long. I think this is basically a good idea but it still requires a lot

Re: help in allocating shared module within a module

2024-12-23 Thread Matthias van de Meent
On Mon, 23 Dec 2024, 18:32 Luca Ferrari, wrote: > > Hi all, > hope this is the right place to ask for, otherwise please point me in > the right resource. > I'm trying to develop a module that needs shared memory between > background workers. > > The _PG_init calls a function to reserve the shared

help in allocating shared module within a module

2024-12-23 Thread Luca Ferrari
Hi all, hope this is the right place to ask for, otherwise please point me in the right resource. I'm trying to develop a module that needs shared memory between background workers. The _PG_init calls a function to reserve the shared memory, which in turn calls RequestAddinShmemSpace, which seems

Re: psql: Fix \pset by adding missed xheader_width option to the help

2024-11-22 Thread Pavel Luzanov
On 22.11.2024 05:52, Michael Paquier wrote: On Thu, Nov 21, 2024 at 10:50:41PM +0300, Pavel Luzanov wrote: I found that the help for \pset command missed xheader_width option. Good catch. This is a mistake from a45388d6e098. The patch should have used HELP0() as this is a single variable

Re: psql: Fix \pset by adding missed xheader_width option to the help

2024-11-21 Thread Michael Paquier
On Thu, Nov 21, 2024 at 10:50:41PM +0300, Pavel Luzanov wrote: > I found that the help for \pset command missed xheader_width option. > Please, consider this small correction. Good catch. This is a mistake from a45388d6e098. The patch should have used HELP0() as this is a single variabl

psql: Fix \pset by adding missed xheader_width option to the help

2024-11-21 Thread Pavel Luzanov
I found that the help for \pset command missed xheader_width option. Please, consider this small correction. -- Pavel Luzanov Postgres Professional:https://postgrespro.com From a5f59e77f3caf5b6bbbfc441393da68999e9e9fc Mon Sep 17 00:00:00 2001 From: Pavel Luzanov Date: Thu, 21 Nov 2024 22:32:44

Not able to compile PG16 with custom flags in freebsd 14.1 - Please Help

2024-09-06 Thread Moksh Chadha
Hi I am trying to install Postgresql 16 on my freebsd 14.1 by compiling it hosted in an ec2 machine on AWS. I am using GCC13 to compile the binaries and I keep on running into *gcc13: fatal error: cannot read spec file './specs': Is a directory *Please Help here is the code of my bas

Re: Role Granting Issues in PostgreSQL: Need Help

2024-09-04 Thread Tom Lane
"David G. Johnston" writes: > On Wednesday, September 4, 2024, Muhammad Imtiaz > wrote: >> replication_expert | Cannot login > Those are not permissions, they are attributes, and attributes are not > inherited. Specifically: the NOLOGIN attribute on a role is a hard block on logging in with tha

Re: Role Granting Issues in PostgreSQL: Need Help

2024-09-04 Thread David G. Johnston
On Wednesday, September 4, 2024, Muhammad Imtiaz wrote: > > 1. Create a role with specific permissions > > CREATE ROLE rep_admin WITH LOGIN CREATEDB CREATEROLE REPLICATION; > > List of roles > Role name | Attributes >

Role Granting Issues in PostgreSQL: Need Help

2024-09-04 Thread Muhammad Imtiaz
Hi, I need to assign role permissions from one role to another. However, after granting the role, I see that the permission list for the target role has not been updated. For this process, I followed the PostgreSQL documentation available at PostgreSQL Role Membership

Re: Help Needed with Including External SQL Script in Extension Script

2024-07-26 Thread David G. Johnston
On Friday, July 26, 2024, Ayush Vatsa wrote: > > I wanted to modify the SQL script of an extension by creating multiple > objects within it. > My aim is to make minimal changes to the existing script. To achieve this, > I have created an > external script and am attempting to run it within the ext

Help Needed with Including External SQL Script in Extension Script

2024-07-26 Thread Ayush Vatsa
Hi PostgreSQL community, I wanted to modify the SQL script of an extension by creating multiple objects within it. My aim is to make minimal changes to the existing script. To achieve this, I have created an external script and am attempting to run it within the extension script using the \i comma

Re: Adding comments to help understand psql hidden queries

2024-06-11 Thread David Christensen
t; > -label = psprintf("QUERY (\\%s)", curcmd); > +label = psprintf(_("QUERY (\\%s)"), curcmd); Any further concerns/issues with this patch that I can address to help move it forward? David

Re: Help update PostgreSQL 13.12 to 13.14

2024-05-06 Thread Bruce Momjian
not finding V13.14. Please follow the link > below. > > https://www.postgresql.org/download/linux/redhat/ > > There is another way to avoid it by downloading the V13.14 on your > system and then install this version on your system which will upgrad

Re: Help update PostgreSQL 13.12 to 13.14

2024-05-05 Thread Kashif Zeeshan
son that it's not finding V13.14. Please follow the link below. >> >> https://www.postgresql.org/download/linux/redhat/ >> >> There is another way to avoid it by downloading the V13.14 on your system >> and then install this version on your system which will u

Help regarding figuring out routes in pgAdmin4

2024-05-04 Thread Ahmad Mehmood
Dear PostgreSQL Hackers, I hope this email finds you well. As I delve into the codebase, I've encountered some challenges understanding how routes are implemented within the application. As I navigate through the codebase, I've encountered some challenges understanding how routes are implemented

Re: Help update PostgreSQL 13.12 to 13.14

2024-04-29 Thread Kashif Zeeshan
upgrade your existing installation. Regards Kashif Zeeshan Bitnine Global > > El sáb, 27 abr 2024 a las 9:29, Kashif Zeeshan () > escribió: > >> Glad to be of help. >> pg_uprade is used with major version upgrade e.g. from PG13 to 14 etc >> >> Regards >> Kashif

Re: Help update PostgreSQL 13.12 to 13.14

2024-04-27 Thread Kashif Zeeshan
Glad to be of help. pg_uprade is used with major version upgrade e.g. from PG13 to 14 etc Regards Kashif Zeeshan Bitnine Global On Fri, Apr 26, 2024 at 10:47 PM •Isaac Rv wrote: > Hola, lo acabo de hacer, quedó bien luego detuve el servidor, aplique otra > vez el sudo yum update postgr

Re: Help update PostgreSQL 13.12 to 13.14

2024-04-26 Thread Kashif Zeeshan
estart the server. The data >>>> directory remains unchanged — minor upgrades are that simple.* >>>> >>>> >>>> Please follow the links below for more information. >>>> https://www.postgresql.org/docs/13/upgrading.html >>>> https://www.

Re: Help update PostgreSQL 13.12 to 13.14

2024-04-25 Thread Kashif Zeeshan
have a guide or >>> know how to perform an upgrade from PostgreSQL 13.12 to 13.14 on Linux? >>> I've searched in various places but haven't found any solid guides, and >>> truth be told, I'm a bit of a novice with PostgreSQL. Any help would be >>> appreciated. >>> >>

Re: Help update PostgreSQL 13.12 to 13.14

2024-04-25 Thread Kashif Zeeshan
t; Hello everyone, I hope you're doing well. Does anyone have a guide or know > how to perform an upgrade from PostgreSQL 13.12 to 13.14 on Linux? I've > searched in various places but haven't found any solid guides, and truth be > told, I'm a bit of a novice with PostgreSQL. Any help would be appreciated. >

Help update PostgreSQL 13.12 to 13.14

2024-04-25 Thread •Isaac Rv
Hello everyone, I hope you're doing well. Does anyone have a guide or know how to perform an upgrade from PostgreSQL 13.12 to 13.14 on Linux? I've searched in various places but haven't found any solid guides, and truth be told, I'm a bit of a novice with PostgreSQL. Any help would be appreciated.

Re: Adding comments to help understand psql hidden queries

2024-04-04 Thread David Christensen
On Thu, Apr 4, 2024 at 9:32 AM Peter Eisentraut wrote: > > On 03.04.24 19:16, David Christensen wrote: > > I removed _() in the output of the query/stars since there'd be no > > sensible existing translations for the constructed string, which > > included the query string itself. If we need it fo

Re: Adding comments to help understand psql hidden queries

2024-04-04 Thread Peter Eisentraut
On 03.04.24 19:16, David Christensen wrote: I removed _() in the output of the query/stars since there'd be no sensible existing translations for the constructed string, which included the query string itself. If we need it for the "QUERY" string, this could be added fairly easily, but the exist

Re: Adding comments to help understand psql hidden queries

2024-04-03 Thread David Christensen
I got Greg's blessing on squashing the commits down, and now including a v4 with additional improvements on the output formatting front. Main changes: - all generated comments are the same width - width has been bumped to 80 - removed _() functions for consumers of the new output functions This p

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread Greg Sabino Mullane
On Fri, Mar 22, 2024 at 11:39 AM David Christensen wrote: > I think it's easier to keep the widths balanced than constant (patch > version included here) Yeah, I'm fine with that, especially because nobody is translating it, nor are they likely to, to be honest. Cheers, Greg

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread David Christensen
On Fri, Mar 22, 2024 at 9:47 AM Greg Sabino Mullane wrote: > > On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut wrote: >> >> lines are supposed to align vertically. With your patch, the first line >> would have variable length depending on the command. > > > Yes, that is a good point. Aligning t

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread Greg Sabino Mullane
On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut wrote: > lines are supposed to align vertically. With your patch, the first line > would have variable length depending on the command. > Yes, that is a good point. Aligning those would be quite tricky, what if we just kept a standard width for t

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread Peter Eisentraut
On 21.03.24 18:31, David Christensen wrote: Thanks for the feedback. Enclosed is a v2 of this series(?) rebased and with that warning fixed; @Greg Sabino Mullane I just created a commit on your behalf with the message to hackers. I'm also creating a commit-fest entry for this thread. I don't

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread David Christensen
Created the CF entry in commitfest 48 but didn't see it was already in 47; closing the CFEntry in 48. (Doesn't appear to be a different status than "Withdrawn"...)

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread David Christensen
Hi Jim, Thanks for the feedback. Enclosed is a v2 of this series(?) rebased and with that warning fixed; @Greg Sabino Mullane I just created a commit on your behalf with the message to hackers. I'm also creating a commit-fest entry for this thread. Best, David v2-0002-Add-output-of-the-comma

Re: Adding comments to help understand psql hidden queries

2024-03-15 Thread Jim Jones
Hi Greg, hi David On 01.02.24 23:39, David Christensen wrote: > On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote: >> The use of the --echo-hidden flag in psql is used to show people the way >> psql performs its magic for its backslash commands. None of them has more >> magic than "\d re

Re: Adding comments to help understand psql hidden queries

2024-02-01 Thread David Christensen
On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote: > > The use of the --echo-hidden flag in psql is used to show people the way psql > performs its magic for its backslash commands. None of them has more magic > than "\d relation", but it suffers from needing a lot of separate queries to

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2024-01-10 Thread Magnus Hagander
com/task/4648506929971200?logs=build#L1217): > > Oops, sorry. Attached is a working third version of this patch. While I think Peters argument about one reading better than the other one, that does also increase the "help message bloat" mentioned by Michael. So I think we're

Re: pg_basebackup has an accidentaly separated help message

2023-12-31 Thread Kyotaro Horiguchi
At Tue, 26 Dec 2023 19:04:53 +0900, Michael Paquier wrote in > On Mon, Dec 25, 2023 at 05:07:28PM +0900, Kyotaro Horiguchi wrote: > > Yes. So, it turns out that they're found after they have been > > committed. > > No problem. I've just applied what you had. I hope this makes your > life a bi

Re: pg_basebackup has an accidentaly separated help message

2023-12-26 Thread Michael Paquier
On Mon, Dec 25, 2023 at 05:07:28PM +0900, Kyotaro Horiguchi wrote: > Yes. So, it turns out that they're found after they have been > committed. No problem. I've just applied what you had. I hope this makes your life a bit easier ;) -- Michael signature.asc Description: PGP signature

Re: pg_basebackup has an accidentaly separated help message

2023-12-25 Thread Kyotaro Horiguchi
At Mon, 25 Dec 2023 15:42:41 +0900, Michael Paquier wrote in > On Mon, Dec 25, 2023 at 02:39:16PM +0900, Kyotaro Horiguchi wrote: > > The attached patch contains both of the above fixes. > > Good catches, let's fix them. You have noticed that while translating > these new messages, I guess? Y

Re: pg_basebackup has an accidentaly separated help message

2023-12-24 Thread Michael Paquier
On Mon, Dec 25, 2023 at 02:39:16PM +0900, Kyotaro Horiguchi wrote: > The attached patch contains both of the above fixes. Good catches, let's fix them. You have noticed that while translating these new messages, I guess? -- Michael signature.asc Description: PGP signature

Re: pg_basebackup has an accidentaly separated help message

2023-12-24 Thread Kyotaro Horiguchi
a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c index b6ae6f2aef..49e97fcca8 100644 --- a/src/bin/pg_combinebackup/pg_combinebackup.c +++ b/src/bin/pg_combinebackup/pg_combinebackup.c @@ -669,8 +669,8 @@ help(const char *progname) printf(_(" -n, -

pg_basebackup has an accidentaly separated help message

2023-12-24 Thread Kyotaro Horiguchi
Hello. pg_basebackup.c: got the following message lines: > printf(_(" -i, --incremental=OLDMANIFEST\n")); > printf(_(" take incremental backup\n")); I'd suggest merging these lines as follows (and the attached patch). > + printf(_(" -i, --incremental=OL

Adding comments to help understand psql hidden queries

2023-12-11 Thread Greg Sabino Mullane
The use of the --echo-hidden flag in psql is used to show people the way psql performs its magic for its backslash commands. None of them has more magic than "\d relation", but it suffers from needing a lot of separate queries to gather all of the information it needs. Unfortunately, those queries

Re: about help message for new pg_dump's --filter option

2023-12-02 Thread Daniel Gustafsson
> On 2 Dec 2023, at 17:02, Alvaro Herrera wrote: > > On 2023-Nov-30, Kyotaro Horiguchi wrote: > >> Hello. >> >> Recently, a new --filter option was added to pg_dump. I might be >> wrong, but the syntax of the help message for this feels off. Is the >

Re: about help message for new pg_dump's --filter option

2023-12-02 Thread Alvaro Herrera
On 2023-Nov-30, Kyotaro Horiguchi wrote: > Hello. > > Recently, a new --filter option was added to pg_dump. I might be > wrong, but the syntax of the help message for this feels off. Is the > word 'on' not necessary after 'based'? > > > --filter=FI

Re: about help message for new pg_dump's --filter option

2023-11-30 Thread Daniel Gustafsson
> On 30 Nov 2023, at 02:52, Kyotaro Horiguchi wrote: > > At Thu, 30 Nov 2023 10:20:40 +0900 (JST), Kyotaro Horiguchi > wrote in >> Hello. >> >> Recently, a new --filter option was added to pg_dump. I might be >> wrong, but the syntax of the help message fo

Re: about help message for new pg_dump's --filter option

2023-11-29 Thread Kyotaro Horiguchi
At Thu, 30 Nov 2023 10:20:40 +0900 (JST), Kyotaro Horiguchi wrote in > Hello. > > Recently, a new --filter option was added to pg_dump. I might be > wrong, but the syntax of the help message for this feels off. Is the > word 'on' not necessary after 'bas

about help message for new pg_dump's --filter option

2023-11-29 Thread Kyotaro Horiguchi
Hello. Recently, a new --filter option was added to pg_dump. I might be wrong, but the syntax of the help message for this feels off. Is the word 'on' not necessary after 'based'? > --filter=FILENAMEinclude or exclude objects and data from dump >

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-31 Thread Michael Banck
ersion of this patch. Michael >From bc9eb46a49ee514236aabe42d9689a7c35b5bcd7 Mon Sep 17 00:00:00 2001 From: Michael Banck Date: Thu, 19 Oct 2023 11:37:11 +0200 Subject: [PATCH v3] pg_basebackup: Mention that spread checkpoints are the default in --help --- src/bin/pg_basebackup/pg_base

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-31 Thread Shlok Kyal
e default in > > > pg_basebackup, but noticed that --help does not specify which is which - > > > contrary to the reference documentation. > > > > > > So I propose the small attached patch to clarify that. > > > > > printf(_(" -c, --c

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-26 Thread Michael Banck
Hi, On Wed, Oct 25, 2023 at 04:36:41PM +0200, Peter Eisentraut wrote: > On 19.10.23 11:39, Michael Banck wrote: > > Hi, > > > > I believed that spread (not fast) checkpoints are the default in > > pg_basebackup, but noticed that --help does not specify which is

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-25 Thread Peter Eisentraut
On 19.10.23 11:39, Michael Banck wrote: Hi, I believed that spread (not fast) checkpoints are the default in pg_basebackup, but noticed that --help does not specify which is which - contrary to the reference documentation. So I propose the small attached patch to clarify that. > pri

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-20 Thread Aleksander Alekseev
Hi, > On Thu, Oct 19, 2023 at 10:30:04PM +0200, Michael Banck wrote: > > Hrm right, but those have multiple options and they do not enumerate > > them in the help string as do -F and -c - not sure what general project > > policy here is for mentioning defaults in --help,

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-19 Thread Michael Paquier
On Thu, Oct 19, 2023 at 10:30:04PM +0200, Michael Banck wrote: > Hrm right, but those have multiple options and they do not enumerate > them in the help string as do -F and -c - not sure what general project > policy here is for mentioning defaults in --help, I will check some of &g

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-19 Thread Michael Banck
Hi, On Thu, Oct 19, 2023 at 04:21:19PM +0300, Aleksander Alekseev wrote: > > I believed that spread (not fast) checkpoints are the default in > > pg_basebackup, but noticed that --help does not specify which is which - > > contrary to the reference documentation. > > &g

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-19 Thread Aleksander Alekseev
Hi, > I believed that spread (not fast) checkpoints are the default in > pg_basebackup, but noticed that --help does not specify which is which - > contrary to the reference documentation. > > So I propose the small attached patch to clarify that. You are right and I believe

[patch] pg_basebackup: mention that spread checkpoints are the default in --help

2023-10-19 Thread Michael Banck
Hi, I believed that spread (not fast) checkpoints are the default in pg_basebackup, but noticed that --help does not specify which is which - contrary to the reference documentation. So I propose the small attached patch to clarify that. Michael >From 2fc49eae5ccc82e144c3f683689757e014e33

Re: Make --help output fit within 80 columns per line

2023-10-06 Thread torikoshia
02 removed environment-variable-based defaults in psql --help. I have committed 0002 and a different implementation of 0001. I set the maximum line length to 95, which is the current maximum in use. Thanks! BTW as far as I investigated, the original 0002 patch failed because current meson doesn't

Re: Make --help output fit within 80 columns per line

2023-10-06 Thread Peter Eisentraut
like patch 0001? Agreed. It seems inconsistent with other commands. Patch 0002 removed environment-variable-based defaults in psql --help. I have committed 0002 and a different implementation of 0001. I set the maximum line length to 95, which is the current maximum in use. I'm open to

Re: Better help output for pgbench -I init_steps

2023-09-26 Thread Peter Eisentraut
On 22.09.23 22:01, Tristen Raab wrote: The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hello, I've reviewed all 4 of y

Re: Make --help output fit within 80 columns per line

2023-09-25 Thread torikoshia
more sensible defaults: $ wget --help | wc -L 110 $ gcloud --help | wc -L 122 $ yum --help | wc -L 122 git is an interesting one, as they force things through a pager for their help, but if you look at their raw help text files, they have plenty of times they go past 80 when needed: $ wc -L gi

  1   2   3   4   5   >