On 22.09.23 22:01, Tristen Raab wrote:
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hello,

I've reviewed all 4 of your patches, each one applies and builds correctly.

I think I prefer variant 2.  Currently, we only have 8 steps, so it might
be overkill to separate them out into a different option.

+1 to this from Peter. Variant 2 is nicely formatted with lots of information 
which I feel better solves the problem this patch is trying to address.

Committed variant 2. I just changed the initial capitalization of the sentences to be more consistent with the surrounding text.



Reply via email to