Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-07-06 Thread Yugo Nagata
On Wed, 4 Jul 2018 10:46:30 +0200 Peter Eisentraut wrote: > On 02.07.18 10:38, Daniel Gustafsson wrote: > >> On 29 Jun 2018, at 18:44, Tom Lane wrote: > > > >> +1 for shortening it as proposed by Peter. The existing arrangement > >> made sense when it was first written, when there were only ab

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-07-04 Thread Peter Eisentraut
On 02.07.18 10:38, Daniel Gustafsson wrote: >> On 29 Jun 2018, at 18:44, Tom Lane wrote: > >> +1 for shortening it as proposed by Peter. The existing arrangement >> made sense when it was first written, when there were only about three >> individual options IIRC. Now it's just confusing, especi

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-07-02 Thread Daniel Gustafsson
> On 29 Jun 2018, at 18:44, Tom Lane wrote: > +1 for shortening it as proposed by Peter. The existing arrangement > made sense when it was first written, when there were only about three > individual options IIRC. Now it's just confusing, especially since you > can't tell very easily whether an

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Daniel Gustafsson
> On 29 Jun 2018, at 18:44, Tom Lane wrote: > Now it's just confusing, especially since you > can't tell very easily whether any of the individual options were > intentionally omitted from the list. It will not get better with > more options, either. Agreed, that’s a good point. cheers ./danie

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Tom Lane
Daniel Gustafsson writes: >> On 29 Jun 2018, at 15:42, Peter Eisentraut >> wrote: >> While we're here, do people find this useful: >> >> >> INCLUDING ALL is an abbreviated form of >> INCLUDING COMMENTS INCLUDING CONSTRAINTS INCLUDING >> DEFAULTS INCLUDING IDENTITY INCLUDING INDEXES INCLUDING S

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Daniel Gustafsson
> On 29 Jun 2018, at 15:42, Peter Eisentraut > wrote: > > While we're here, do people find this useful: > > > INCLUDING ALL is an abbreviated form of > INCLUDING COMMENTS INCLUDING CONSTRAINTS INCLUDING > DEFAULTS INCLUDING IDENTITY INCLUDING INDEXES INCLUDING STATISTICS > INCLUD

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Peter Eisentraut
While we're here, do people find this useful: INCLUDING ALL is an abbreviated form of INCLUDING COMMENTS INCLUDING CONSTRAINTS INCLUDING DEFAULTS INCLUDING IDENTITY INCLUDING INDEXES INCLUDING STATISTICS INCLUDING STORAGE. Maybe something more like "... is an abbreviated f

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Yugo Nagata
On Fri, 29 Jun 2018 11:36:19 +0200 Daniel Gustafsson wrote: > > On 29 Jun 2018, at 09:14, Yugo Nagata wrote: > > > Thanks a lot. > > > > I updated the patch. > > This version looks good to me. You might want to add it to the CF to make > sure > it isn’t forgotten. > > cheers ./daniel Sure

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Daniel Gustafsson
> On 29 Jun 2018, at 09:14, Yugo Nagata wrote: > Thanks a lot. > > I updated the patch. This version looks good to me. You might want to add it to the CF to make sure it isn’t forgotten. cheers ./daniel

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-29 Thread Yugo Nagata
On Fri, 29 Jun 2018 08:39:01 +0200 Daniel Gustafsson wrote: > > On 29 Jun 2018, at 07:56, Yugo Nagata wrote: > > On Thu, 28 Jun 2018 16:22:15 -0700 > > "David G. Johnston" wrote: > > >> ​Maybe try something like: > >> > >> It is legal to specify the same option multiple times - e.g., "INCLUDI

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-28 Thread Daniel Gustafsson
> On 29 Jun 2018, at 07:56, Yugo Nagata wrote: > On Thu, 28 Jun 2018 16:22:15 -0700 > "David G. Johnston" wrote: >> ​Maybe try something like: >> >> It is legal to specify the same option multiple times - e.g., "INCLUDING >> option EXCLUDING option" - the outcome is whichever comes last in the

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-28 Thread Yugo Nagata
On Thu, 28 Jun 2018 16:22:15 -0700 "David G. Johnston" wrote: > On Thu, Jun 28, 2018 at 3:57 PM, Daniel Gustafsson wrote: Thank you for your reviewing! I attached the updated patch. > > > > On 27 Jun 2018, at 18:02, Yugo Nagata wrote: > > > > > I found that there isn't explanation about EXC

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-28 Thread David G. Johnston
On Thu, Jun 28, 2018 at 3:57 PM, Daniel Gustafsson wrote: > > On 27 Jun 2018, at 18:02, Yugo Nagata wrote: > > > I found that there isn't explanation about EXCLUDING in CREATE TABLE doc. > > Attached is a patch to add this. I would appreciate it if a native > English > > speaker comments on this

Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-28 Thread Daniel Gustafsson
> On 27 Jun 2018, at 18:02, Yugo Nagata wrote: > I found that there isn't explanation about EXCLUDING in CREATE TABLE doc. > Attached is a patch to add this. I would appreciate it if a native English > speaker comments on this. + If EXCLUDING option is specified The empty seems wrong. +

CREATE TABLE .. LIKE .. EXCLUDING documentation

2018-06-27 Thread Yugo Nagata
Hi, I found that there isn't explanation about EXCLUDING in CREATE TABLE doc. Attached is a patch to add this. I would appreciate it if a native English speaker comments on this. Regards, -- Yugo Nagata diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index