Re: [PATCH v1] Show whether tables are logged in \dt+

2019-05-03 Thread Rafia Sabih
On Sat, 27 Apr 2019 at 06:18, David Fetter wrote: > > On Fri, Apr 26, 2019 at 04:22:18PM +0200, Rafia Sabih wrote: > > On Fri, 26 Apr 2019 at 14:49, Rafia Sabih wrote: > > > > > > On Wed, 24 Apr 2019 at 10:30, Fabien COELHO wrote: > > > > > > > > > > > > Hello David, > > > > > > > > >>> I notice

Re: nRe: [PATCH v1] Show whether tables are logged in \dt+

2019-04-27 Thread Fabien COELHO
Hello David, Patch applies. There seems to be a compilation issue: describe.c:5974:1: error: expected declaration or statement at end of input } Also there is an added indentation problem: the size & description stuff have been moved left but it should still in the verbose case, and a } i

Re: nRe: [PATCH v1] Show whether tables are logged in \dt+

2019-04-27 Thread David Fetter
On Sat, Apr 27, 2019 at 09:19:57AM +0200, Fabien COELHO wrote: > > Hello David, > > Patch v3 applies, but compiles for me with a warning because the indentation > of the following size block has been changed: > > describe.c: In function ‘listTables’: > describe.c:3705:7: warning: this ‘if’ claus

nRe: [PATCH v1] Show whether tables are logged in \dt+

2019-04-27 Thread Fabien COELHO
Hello David, Patch v3 applies, but compiles for me with a warning because the indentation of the following size block has been changed: describe.c: In function ‘listTables’: describe.c:3705:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] else if (pset.sversion >=

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-26 Thread David Fetter
On Fri, Apr 26, 2019 at 04:22:18PM +0200, Rafia Sabih wrote: > On Fri, 26 Apr 2019 at 14:49, Rafia Sabih wrote: > > > > On Wed, 24 Apr 2019 at 10:30, Fabien COELHO wrote: > > > > > > > > > Hello David, > > > > > > >>> I noticed that there wasn't a bulk way to see table logged-ness in > > > >>> p

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-26 Thread Rafia Sabih
On Fri, 26 Apr 2019 at 14:49, Rafia Sabih wrote: > > On Wed, 24 Apr 2019 at 10:30, Fabien COELHO wrote: > > > > > > Hello David, > > > > >>> I noticed that there wasn't a bulk way to see table logged-ness in psql, > > >>> so I made it part of \dt+. > > >> > > >> Applies, compiles, works for me. >

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-26 Thread Rafia Sabih
On Wed, 24 Apr 2019 at 10:30, Fabien COELHO wrote: > > > Hello David, > > >>> I noticed that there wasn't a bulk way to see table logged-ness in psql, > >>> so I made it part of \dt+. > >> > >> Applies, compiles, works for me. > >> > >> ISTM That temporary-ness is not shown either. Maybe the persi

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-24 Thread Fabien COELHO
Hello David, I noticed that there wasn't a bulk way to see table logged-ness in psql, so I made it part of \dt+. Applies, compiles, works for me. ISTM That temporary-ness is not shown either. Maybe the persistence column should be shown as is? Temporariness added, but not raw. Ok, it is

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-23 Thread David Fetter
On Tue, Apr 23, 2019 at 07:03:58AM +0200, Fabien COELHO wrote: > > Hello David, > > > I noticed that there wasn't a bulk way to see table logged-ness in psql, > > so I made it part of \dt+. > > Applies, compiles, works for me. > > ISTM That temporary-ness is not shown either. Maybe the persiste

Re: [PATCH v1] Show whether tables are logged in \dt+

2019-04-22 Thread Fabien COELHO
Hello David, I noticed that there wasn't a bulk way to see table logged-ness in psql, so I made it part of \dt+. Applies, compiles, works for me. ISTM That temporary-ness is not shown either. Maybe the persistence column should be shown as is? Also I'd suggest that the column should be d

[PATCH v1] Show whether tables are logged in \dt+

2019-04-22 Thread David Fetter
>From 518efc003730c441663aae42c18d16f0908bd55d Mon Sep 17 00:00:00 2001 From: David Fetter Date: Mon, 22 Apr 2019 17:50:48 -0700 Subject: [PATCH v1] Show whether tables are logged in \dt+ To: hackers MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2.20.1" This is a mul