Re: [Commitfest 2022-07] Begins Now

On 7/22/22 16:03, Jacob Champion wrote: > On 7/15/22 16:42, Jacob Champion wrote: >> On 7/8/22 16:42, Jacob Champion wrote: >>> On 7/1/22 08:08, Jacob Champion wrote: It's been July everywhere on Earth for a few hours, so the July commitfest is now in progress: https://commi

Re: [Commitfest 2022-07] Begins Now

On Mon, Jul 18, 2022 at 1:44 PM Andres Freund wrote: > ISTM that you're trying to get patches to have zero reviewers if they need > more reviewers, because that can serve as a signal in the CF app. But to me > that's a bad proxy. Okay. I need to put some more thought into what it is that I really

Re: [Commitfest 2022-07] Begins Now

On 7/15/22 16:42, Jacob Champion wrote: > On 7/8/22 16:42, Jacob Champion wrote: >> On 7/1/22 08:08, Jacob Champion wrote: >>> It's been July everywhere on Earth for a few hours, so the July >>> commitfest is now in progress: >>> >>> https://commitfest.postgresql.org/38/ With one week remainin

Re: [Commitfest 2022-07] Begins Now

On 7/18/22 02:53, Alvaro Herrera wrote: On 2022-Jul-18, Aleksander Alekseev wrote: Hi hackers, If someone put a lot of review into a patchset a few months ago, they absolutely deserve credit. But if that entry has been sitting with no feedback this month, why is it useful to keep that Reviewe

Re: [Commitfest 2022-07] Begins Now

Hi, On 2022-07-18 13:34:52 -0700, Jacob Champion wrote: > On 7/18/22 12:32, Andres Freund wrote: > > I'm not following - I'm talking about the patch author needing a while to > > address the higher level feedback given by a reviewer. The author might put > > out a couple new versions, which each m

Re: [Commitfest 2022-07] Begins Now

On 7/18/22 12:32, Andres Freund wrote: > I'm not following - I'm talking about the patch author needing a while to > address the higher level feedback given by a reviewer. The author might put > out a couple new versions, which each might still benefit from review. In that > - pretty common imo - s

Re: [Commitfest 2022-07] Begins Now

Hi, On 2022-07-18 12:22:25 -0700, Jacob Champion wrote: > [dev hat] > > On 7/15/22 18:07, Andres Freund wrote: > > IDK, I've plenty times given feedback and it took months till it all was > > implemented. What's the point of doing further rounds of review until then? > > I guess I would wonder w

Re: [Commitfest 2022-07] Begins Now

[dev hat] On 7/15/22 18:07, Andres Freund wrote: > IDK, I've plenty times given feedback and it took months till it all was > implemented. What's the point of doing further rounds of review until then? I guess I would wonder why we're optimizing for that case. Is it helpful for that patch to stic

Re: [Commitfest 2022-07] Begins Now

On 7/15/22 16:42, Jacob Champion wrote: > If you have thoughts/comments on this approach, please share them! Okay, plenty of feedback to sift through here. [CFM hat] First of all: mea culpa. I unilaterally made a change that I had assumed would be uncontroversial; it clearly was not, and I inter

Re: [Commitfest 2022-07] Begins Now

On 2022-Jul-18, Aleksander Alekseev wrote: > Hi hackers, > > > > If someone put a lot of review into a patchset a few months ago, they > > > absolutely deserve credit. But if that entry has been sitting with no > > > feedback this month, why is it useful to keep that Reviewer around? > > As I re

Re: [Commitfest 2022-07] Begins Now

Hi hackers, > > If someone put a lot of review into a patchset a few months ago, they > > absolutely deserve credit. But if that entry has been sitting with no > > feedback this month, why is it useful to keep that Reviewer around? As I recall, several committers reported before that they use Rev

Re: [Commitfest 2022-07] Begins Now

Hi, On 2022-07-15 17:28:06 -0700, Jacob Champion wrote: > On 7/15/22 16:51, Andres Freund wrote: > > I'd make it dependent on whether there have been previous rounds of feedback > > or not. If somebody spent a good amount of time reviewing a patch > > previously, > > but then didn't review the ne

Re: [Commitfest 2022-07] Begins Now

On 7/15/22 16:51, Andres Freund wrote: > I'd make it dependent on whether there have been previous rounds of feedback > or not. If somebody spent a good amount of time reviewing a patch previously, > but then didn't review the newest version in the last few weeks, it doesn't > seem useful to remove

Re: [Commitfest 2022-07] Begins Now

Hi, On 2022-07-15 16:42:03 -0700, Jacob Champion wrote: > I started removing stale Reviewers fairly aggressively today, as > discussed in [1], but there was some immediate feedback and I have > paused that process for now. If you're wondering why you are no longer > marked as reviewer on a patch,

Re: [Commitfest 2022-07] Begins Now

On 7/8/22 16:42, Jacob Champion wrote: > On 7/1/22 08:08, Jacob Champion wrote: >> It's been July everywhere on Earth for a few hours, so the July >> commitfest is now in progress: >> >> https://commitfest.postgresql.org/38/ Halfway through! We are now at Needs review: 175 Wa

Re: [Commitfest 2022-07] Begins Now

Hi Jacob Abort Global temporary table https://commitfest.postgresql.org/36/2349/# Please move the Global Temporary table to check next month, that is at 202208. I need more time to process the existing issue. Thanks Wenjing > 2022年7月9日 07:42，Jacob

Re: [Commitfest 2022-07] Begins Now

On 7/1/22 08:08, Jacob Champion wrote: > It's been July everywhere on Earth for a few hours, so the July > commitfest is now in progress: > > https://commitfest.postgresql.org/38/ One week down, three to go. I forgot to put the overall status in the last email. We started the month with the f

[Commitfest 2022-07] Begins Now

Hello! It's been July everywhere on Earth for a few hours, so the July commitfest is now in progress: https://commitfest.postgresql.org/38/ New patches may be registered for the next commitfest in September. Pick some patches to review and have fun! Happy hacking, --Jacob