[dev hat] On 7/15/22 18:07, Andres Freund wrote: > IDK, I've plenty times given feedback and it took months till it all was > implemented. What's the point of doing further rounds of review until then?
I guess I would wonder why we're optimizing for that case. Is it helpful for that patch to stick around in an active CF for months? There's an established need for keeping a "TODO item" around and not letting it fall off, but I think that should remain separate in an application which seems to be focused on organizing active volunteers. And if that's supposed to be what Waiting on Author is for, then I think we need more guidance on how to use that status effectively. Some reviewers seem to use it as a "replied" flag. I think there's a meaningful difference between soft-blocked on review feedback and hard-blocked on new implementation. And maybe there's even a middle state, where the patch just needs someone to do a mindless rebase. I think you're in a better position than most to "officially" decide that a patch can no longer benefit from review. Most of us can't do that, I imagine -- nor should we. Thanks, --Jacob
