Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache

> > /* Pin the buffer and then release its spinlock */ > > PinBuffer_Locked(buf_hdr); > > > That spelling-out makes it obvious what’s happening. I think this makes sense, this is done in v8 which is attached to the email above. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache

Hi, Thank you for looking into this! And sorry for the late reply. On Mon, 12 May 2025 at 13:24, Amit Kapila wrote: > > On Mon, Apr 28, 2025 at 2:43 PM Nazir Bilal Yavuz wrote: > > > > Hi, > > > > On Fri, 25 Apr 2025 at 19:17, Xuneng Zhou wrote: > > >

Re: Speed up COPY FROM text/CSV parsing using SIMD

utesText() function, the improvement on the 4096 byte line length input [1] goes from 20% to 30%. --- I shared my ideas as a Feedback.txt file (.txt to stay off CFBot's radar for this thread). I hope these help, please let me know if you have any questions. -- Regards, Nazir Bilal Yavuz Mi

Re: Improve prep_buildtree

Hi, On Wed, 30 Jul 2025 at 21:56, Peter Eisentraut wrote: > > On 30.07.25 12:58, Nazir Bilal Yavuz wrote: > > > > That makes sense. I noticed one difference, patched prep_buildtree > > does not create a symbolic link for the top Makefile in the builddir. > > Ok, h

Re: Improve prep_buildtree

Hi, On Wed, 30 Jul 2025 at 12:32, Peter Eisentraut wrote: > > On 30.07.25 10:28, Nazir Bilal Yavuz wrote: > > On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut wrote: > >> > >> To fix this, I first tried to devise a way to detect whether a given > >> di

Re: Improve prep_buildtree

if the directory is a build directory [1]. I am just wondering if you tried this and found it complicated or did you try something else. [1] https://github.com/mesonbuild/meson/blob/b4d32763940ae67d1ed36952112b3d94ba9f03a7/mesonbuild/mcompile.py#L30C1-L35C82 -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

the other tests, > and we'd have more leverage over the timing of is_alive(). Default is > 180s. I think it makes sense to add this timeout, as it would be more in line with the other tests like you said. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

but not impossible. Do you think this edge case is not worth accounting for? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

Hi, On Thu, 24 Jul 2025 at 13:34, Nazir Bilal Yavuz wrote: > > Hi, > > On Tue, 22 Jul 2025 at 03:56, Michael Paquier wrote: > > > > On Mon, Jul 21, 2025 at 11:53:00AM +0300, Nazir Bilal Yavuz wrote: > > > I realized that we actually don't trim the file, w

Re: Making type Datum be 8 bytes everywhere

6 -b $type -T 150 test TPS results are: select-only: master: 215654 patched:215751 simple-update: master: 4454 patched:4446 tpcb-like: master: 4094 patched:4128 -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

Hi, On Tue, 22 Jul 2025 at 03:56, Michael Paquier wrote: > > On Mon, Jul 21, 2025 at 11:53:00AM +0300, Nazir Bilal Yavuz wrote: > > I realized that we actually don't trim the file, we do the opposite; > > read the file from both ends. Sorry for not realizing earlier

Re: Improve error reporting in 027_stream_regress test

n_log_helper() can't check if $lines_to_dump * 2 is bigger than the number of lines in the regression.diffs file. So, it can't decide whether or not to dump all of the regression.diffs. Would it be okay if we repeat some lines in both the head and tail lines? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

nk about adding both ``` trim_file() -> trims $n lines from head or tail of the file and returns the remaining lines. read_file_ends() -> returns $n lines from head or tail of the file. ``` although trim_file() will not be used in these particular patches? -- Regards, Nazir Bilal Yavuz Microsoft

Re: index prefetching

ramp up. It is always like distance is 1 and IO needed, so multiplying the distance by 2 -> distance = 2 but then the next block is cached, so decreasing the distance by 1 and distance is 1 again. [1] https://www.postgresql.org/message-id/aa46af80-5219-47e6-a7d0-7628106965a6%40vondra.me -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

Hi, On Thu, 17 Jul 2025 at 03:08, Michael Paquier wrote: > > On Wed, Jul 16, 2025 at 02:32:53PM +0300, Nazir Bilal Yavuz wrote: > > On Wed, 16 Jul 2025 at 04:39, Michael Paquier wrote: > >> Hmm. Is that actually useful as we know that the standby has been > >> sta

Re: Windows question: when is LC_MESSAGES defined?

Hi, On Thu, 17 Jul 2025 at 11:19, Dave Page wrote: > > On Thu, 17 Jul 2025 at 09:01, Nazir Bilal Yavuz wrote: >> >> x64: >> >> * I downloaded Dave Page's Windows gettext artifact from [2]. I am >> able to configure Postgres with nls being en

Re: Explicitly enable meson features in CI

Hi, On Wed, 16 Jul 2025 at 18:24, Jacob Champion wrote: > > On Wed, Jul 16, 2025 at 4:12 AM Nazir Bilal Yavuz wrote: > > > For me it looks like 'Meson Auto' can be confused with 'Autoconf'. We > > > can rename it as a 'Meson Auto Feature Detec

Re: Explicitly enable meson features in CI

Hi, On Wed, 16 Jul 2025 at 19:02, Andres Freund wrote: > > Hi, > > On 2025-07-16 14:12:22 +0300, Nazir Bilal Yavuz wrote: > > On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz wrote: > > > On Thu, 10 Jul 2025 at 20:12, Jacob Champion > > > wrote: > > &

Re: Windows question: when is LC_MESSAGES defined?

orking on Windows + MSVC but not sure about its current status. * Another option could be to download gettext [4] and then compile it locally. [1] https://gnuwin32.sourceforge.net/packages/gettext.htm [2] https://github.com/dpage/winpgbuild/actions/runs/16211024479 [3] https://vcpkg.io [4] https://www.gnu.org/software/gettext -- Regards, Nazir Bilal Yavuz Microsoft

Re: Improve error reporting in 027_stream_regress test

Hi, Thanks for looking into this! On Wed, 16 Jul 2025 at 04:39, Michael Paquier wrote: > > On Tue, Jul 01, 2025 at 10:57:11AM +0300, Nazir Bilal Yavuz wrote: > > On Mon, 30 Jun 2025 at 18:01, Andres Freund wrote: > >> One thing I don't yet like is that I think we sh

Re: Explicitly enable meson features in CI

Hi, On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz wrote: > > Hi, > > On Thu, 10 Jul 2025 at 20:12, Jacob Champion > wrote: > > > > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz > > wrote: > > > Andres off-list mentioned that if we explicitly en

Re: Explicitly enable meson features in CI

Hi, On Thu, 10 Jul 2025 at 20:12, Jacob Champion wrote: > > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz wrote: > > Andres off-list mentioned that if we explicitly enable features for > > *all* of the tasks, then none of the tasks will be testing the auto > > fe

Re: Explicitly enable meson features in CI

Hi, On Tue, 8 Jul 2025 at 12:10, Nazir Bilal Yavuz wrote: > > Hi, > > On Wed, 2 Jul 2025 at 10:22, Nazir Bilal Yavuz wrote: > > > > Also, libcurl is disabled in the OpenBSD CI task until the fix in this > > thread [1] is committed. > > This fix is committed

Re: Explicitly enable meson features in CI

Hi, On Wed, 2 Jul 2025 at 10:22, Nazir Bilal Yavuz wrote: > > Also, libcurl is disabled in the OpenBSD CI task until the fix in this > thread [1] is committed. This fix is committed in 7376e60854 so libcurl is enabled for OpenBSD in v4. -- Regards, Nazir Bilal Yavuz Micro

Re: C11 / VS 2019

We have the (allegedly) same VS version in Cirrus CI, and it's > never shown a problem like this. CI uses the latest VS 2019 (v16.11.48), it looks like buildfarm member drongo uses VS 2019 v16.3.1. I created a custom Windows VM with the same VS 2019 version (v16.3.1) at the drongo and CI failed with the same error [1]. [1] https://cirrus-ci.com/task/6271845944524800 -- Regards, Nazir Bilal Yavuz Microsoft

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

Hi, On Wed, 25 Jun 2025 at 13:45, Nazir Bilal Yavuz wrote: > > Hi, > > On Tue, 24 Jun 2025 at 23:46, Jacob Champion > wrote: > > > > On Tue, Jun 24, 2025 at 1:27 AM Nazir Bilal Yavuz > > wrote: > > > I think this is a good idea. Another point is t

Re: meson vs. llvm bitcode files

Hi, On Tue, 29 Apr 2025 at 11:23, Nazir Bilal Yavuz wrote: > > Hi, > > On Thu, 13 Mar 2025 at 13:11, Nazir Bilal Yavuz wrote: > > One thing I noticed is that gen_srcfiles['srcfiles'] seems wrong. > > gen_sources is a better name compared to gen_srcfiles. So,

Re: Explicitly enable meson features in CI

Hi, On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson wrote: > > > On 3 Jul 2025, at 15:50, Nazir Bilal Yavuz wrote: > > On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote: > > >> + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS

Re: Explicitly enable meson features in CI

Hi, Thank you for looking into this! On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote: > > > On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz wrote: > > On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote: > > >> Here is a sketch of what I mean: > >> >

Re: Explicitly enable meson features in CI

Hi, Thank you for looking into this! On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote: > > On 02.07.25 09:22, Nazir Bilal Yavuz wrote: > > One thing I’m unsure about the patch is that all these features are > > stored in the MESON_FEATURES environment variable in each tas

Explicitly enable meson features in CI

ed. [1] https://www.postgresql.org/message-id/CAOYmi%2BkdR218ke2zu74oTJvzYJcqV1MN5%3DmGAPqZQuc79HMSVA%40mail.gmail.com -- Regards, Nazir Bilal Yavuz Microsoft From 081b43e34d5247d8d9b10498473bb6d440f0008c Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Wed, 25 Jun 2025 11:14:26 +0300 Subject

Re: Improve error reporting in 027_stream_regress test

Hi, On Mon, 30 Jun 2025 at 18:01, Andres Freund wrote: > > Hi, > > On 2025-06-30 16:01:04 +0300, Nazir Bilal Yavuz wrote: > > This patch aims to improve 027_stream_regress test's regression test > > error reporting per Andres' suggestion [1]. > > Thank

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

Hi, On Mon, 30 Jun 2025 at 17:45, Jacob Champion wrote: > > On Wed, Jun 25, 2025 at 3:46 AM Nazir Bilal Yavuz wrote: > > I wanted to experiment with it. > > That was fast, thank you! > > > First, I got the current list of > > features from upstream, then

Improve error reporting in 027_stream_regress test

[1] https://www.postgresql.org/message-id/k46gdpibwaevxgb3cefgkl4weykcggal6evlbg5pcei4aswtli%40wrs732j5co3p -- Regards, Nazir Bilal Yavuz Microsoft From 8c1c69b42607b09dddc74ec25540b6afb48e0bd8 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Tue, 17 Jun 2025 16:08:20 +0300 Subject: [PATCH v1] Improve error

Re: Simplify VM counters in vacuum code

++; > } > > The flags is initialized as: > > uint8 flags = VISIBILITYMAP_ALL_VISIBLE; > > so the new if-condition is always true. I think we do not need to check visibility of the page here, as we already know that page was not all-visible due to LP_DEAD items. We can simply increment the vacrel->vm_new_visible_pages and check whether the page is frozen. -- Regards, Nazir Bilal Yavuz Microsoft

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

Hi, On Tue, 24 Jun 2025 at 23:46, Jacob Champion wrote: > > On Tue, Jun 24, 2025 at 1:27 AM Nazir Bilal Yavuz wrote: > > I think this is a good idea. Another point is that CI images and their > > packages are updated automatically, so it would be easier to catch if > > s

Re: Simplify VM counters in vacuum code

Hi, On Tue, 24 Jun 2025 at 18:12, Melanie Plageman wrote: > > On Tue, Jun 24, 2025 at 9:17 AM Melanie Plageman > wrote: > > > > On Tue, Jun 24, 2025 at 4:01 AM Nazir Bilal Yavuz > > wrote: > > > > > I think we do not need to check visibility of th

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

me catch my mistake earlier. I think this is a good idea. Another point is that CI images and their packages are updated automatically, so it would be easier to catch if something breaks when the VM is updated. -- Regards, Nazir Bilal Yavuz Microsoft

Re: minimum Meson version

Hi, On Thu, 19 Jun 2025 at 09:40, Nazir Bilal Yavuz wrote: > > Hi, > > On Wed, 18 Jun 2025 at 11:58, Peter Eisentraut wrote: > > > > On 17.06.25 19:36, Peter Eisentraut wrote: > > > meson.build currently says > > > > > > # We want < 0.56 f

Re: minimum Meson version

ror("Passing coroutines is forbidden, use tasks explicitly.") TypeError: Passing coroutines is forbidden, use tasks explicitly. /usr/lib/python3.13/asyncio/events.py:89: RuntimeWarning: coroutine 'Process.wait' was never awaited self._context.run(self._callback, *self._args) RuntimeWarning: Enable tracemalloc to get the object allocation traceback -- Regards, Nazir Bilal Yavuz Microsoft

Re: [PATCH] Add an ldflags_sl meson build option

d against the 17.4 release. The patch looks correct. +option('ldflags_sl', type: 'array', value: [], + description: 'Shared library ldflags') nitpick: I would suggest using the same description from autoconf build: 'extra linker flags for linking shared libraries only'. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

one of the two > could be manually triggered to save on resources. I think that is pretty doable. First we need to decide on a list of OS families, though. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

Hi, On Thu, 5 Jun 2025 at 11:27, Peter Eisentraut wrote: > > On 05.06.25 10:04, Nazir Bilal Yavuz wrote: > > Thomas Munro off-list mentioned that the Windows CI image is actually > > running on Server 2022, even though the task name still refers to > > Server 2019. He

Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

s://github.com/anarazel/pg-vm-images/pull/114 [2] https://cirrus-ci.com/build/5095727501672448 -- Regards, Nazir Bilal Yavuz Microsoft From 8bb0ba7db2cd56cf8d459b90df3643a8ee31c346 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 5 Jun 2025 10:29:06 +0300 Subject: [PATCH 1/2] ci: Updat

Re: Differential code coverage between 16 and HEAD

implementation is still a work in progress, and the code may be a bit messy :(. Please feel free to ask any questions! I am interested in this area, if you would like we can work on it together. [1] https://github.com/nbyavuz/postgres-code-coverage -- Regards, Nazir Bilal Yavuz Microsoft

Re: Proposal for enabling auto-vectorization for checksum calculations

-16" $ make -s -j8 world-bin $ make -j8 check-world should be enough. I was able to replicate it with these commands. I hope these help. [1] https://cirrus-ci.com/task/4834162550505472 -- Regards, Nazir Bilal Yavuz Microsoft

Re: PG 18 release notes draft committed

Hi, On Tue, 20 May 2025 at 16:52, Bruce Momjian wrote: > > On Tue, May 20, 2025 at 03:46:44PM +0300, Nazir Bilal Yavuz wrote: > > Hi, > > > > Thanks for working on this! > > > > On Fri, 2 May 2025 at 05:44, Bruce Momjian wrote: > > > > > >

Re: PG 18 release notes draft committed

the file copying method (Nazir Bilal Yavuz) +§ + A minor fix; I co-authored this with Thomas Munro, he is the actual author. -- Regards, Nazir Bilal Yavuz Microsoft

Re: fix: propagate M4 env variable to flex subprocess

the 'FLEX_TMP_DIR' part. I tried to search where the 'FLEX_TMP_DIR' part is added [2], it seems that this part is added while rebasing so there is no specific commit. [1] https://github.com/anarazel/postgres/pull/51 [2] https://github.com/anarazel/postgres/commit/cd817afd4ab006b90307a940d96b5116d649165c -- Regards, Nazir Bilal Yavuz Microsoft

Re: Fix a race condition in ConditionVariableTimedSleep()

CancelSleep() should not be called while waiting for the latch, right? If that is the case, does not the reproducer code violate this? -- Regards, Nazir Bilal Yavuz Microsoft

Re: meson vs. llvm bitcode files

Hi, On Thu, 13 Mar 2025 at 13:11, Nazir Bilal Yavuz wrote: > One thing I noticed is that gen_srcfiles['srcfiles'] seems wrong. > gen_sources is a better name compared to gen_srcfiles. So, I changed > it to gen_sources in v4. Rebase is needed due to b1720fe63f, v5 is att

Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache

> Would love to hear if this makes sense or or am I overlooking something here. > Thanks for any feedback! I think what you said makes sense and is correct if we only want to simulate a buffer’s dirty state for testing/debugging, but if we want to replicate usual steps to marking buffers as dir

Re: New committer: Jacob Champion

! Congratulations Jacob! -- Regards, Nazir Bilal Yavuz Microsoft

Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache

already reviewed the patches are CCed. [1] postgr.es/m/CAN55FZ0h_YoSqqutxV6DES1RW8ig6wcA8CR9rJk358YRMxZFmw%40mail.gmail.com -- Regards, Nazir Bilal Yavuz Microsoft From 06f12f6174c0b6e1c5beeb4c1a8f4b33b89cc158 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Fri, 4 Apr 2025 13:39:49 +0300

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

hat. I am okay to replace these loops with [1] to make it standart everywhere: [1] for (int buf = 0; buf < NBuffers; buf++) { BufferDesc *desc = GetBufferDescriptor(buf); -- Regards, Nazir Bilal Yavuz Microsoft

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

x27;d be happy to > work > on it). I think it looks useful, but I’m not too familiar with NUMA, so I’m not sure I can say much with confidence. Maybe someone else can chime in with a more solid take? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Adding NetBSD and OpenBSD to Postgres CI

GET to the NetBSD and OpenBSD CI tasks. [1] https://cirrus-ci.com/task/5126123371102208?logs=test_world#L144 -- Regards, Nazir Bilal Yavuz Microsoft From 0a265615e7bd9d6da2cbf1d7edfbe68a8bdf39f1 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Tue, 8 Apr 2025 14:21:42 +0300 Subject: [PATC

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

Hi, On Tue, 8 Apr 2025 at 02:29, Andres Freund wrote: > On 2025-04-07 19:37:50 +0300, Nazir Bilal Yavuz wrote: > > > > > > + relation_close(rel, AccessExclusiveLock); > > > > > > > > > > Hm. Why are we dropping the lock here early? It's

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

Hi, On Mon, 7 Apr 2025 at 16:38, Andres Freund wrote: > > Hi, > > On 2025-04-04 18:36:57 +0300, Nazir Bilal Yavuz wrote: > > v6 is attached. Additional changes prior to v5: > > > > * Tests are added. > > I don't think the mark-dirty stuff is quite ready

Re: ci: Allow running mingw tests by default via environment variable

rebasing them, I realized that we use 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' for all branches. So, we don't have per branch 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' configuration option. Is that a problem? -- Regards, Nazir Bilal Yavuz Microsoft From c872f537375416289d3fdc302716403266899c1f Mon Sep

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

need to do this. I see EvictUnpinnedBuffer() as a central place that checks all conditions. If we add this pre-check then we should not do the same check in the EvictUnpinnedBuffer(), creating this logic would add unnecessary complexity to EvictUnpinnedBuffer(). I addressed these reviews in v3. I will share the patches in my next reply. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Using read stream in autoprewarm

Hi, Thank you for looking into this! On Sat, 29 Mar 2025 at 23:10, Melanie Plageman wrote: > > On Fri, Nov 29, 2024 at 6:20 AM Nazir Bilal Yavuz wrote: > > > > v4 is attached. > > I've started looking at this version. What I don't like about this > structu

Re: Using read stream in autoprewarm

hanges, we do not check if it is changed from the database oid = 0. Handling this might require some structural changes. > What do you think? I think what you said is right but the current version of the patch looks more complicated to me. I may be biased because I do not like do-while loops and goto statements. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

Hi, Thanks for the review! On Wed, 2 Apr 2025 at 20:06, Andres Freund wrote: > > Hi, > > On 2025-03-31 19:49:25 +0300, Nazir Bilal Yavuz wrote: > > > After this discussion, I think it would be helpful if one of the more > > > experienced > > > hackers c

Re: Using read stream in autoprewarm

Hi, On Fri, 4 Apr 2025 at 10:59, Daniel Gustafsson wrote: > > This patch is already marked Ready for Committer and I concur with that. Same on my end, v14 LGTM. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Using read stream in autoprewarm

Hi, On Wed, 2 Apr 2025 at 01:36, Melanie Plageman wrote: > > On Tue, Apr 1, 2025 at 8:50 AM Nazir Bilal Yavuz wrote: > > > > I am attaching v8, which is an updated version of the v7. I tried to > > get rid of these local variables and refactored code to make logic

Re: Using read stream in autoprewarm

Hi, On Wed, 2 Apr 2025 at 18:54, Melanie Plageman wrote: > > On Wed, Apr 2, 2025 at 6:26 AM Nazir Bilal Yavuz wrote: > > > > On Wed, 2 Apr 2025 at 01:36, Melanie Plageman > > wrote: > > > > > > I know you mentioned off-list that you don't

Re: Using read stream in autoprewarm

tforward instead of going back and forth. 0001 and 0002 are v8. 0003 is another refactoring attempt to make code more straightforward. I did not squash 0003 to previous patches as you might not like it. -- Regards, Nazir Bilal Yavuz Microsoft v8-0001-Optimize-autoprewarm-with-read-streams.patch

Re: Using read stream in autoprewarm

Hi, Thank you for looking into this! On Mon, 31 Mar 2025 at 17:42, Melanie Plageman wrote: > > On Sun, Mar 30, 2025 at 10:01 AM Nazir Bilal Yavuz wrote: > > > > > Some review feedback on your v4: I don't think we need the > > > rs_have_free_buffer

Re: Using read stream in autoprewarm

Hi, On Mon, 31 Mar 2025 at 21:15, Melanie Plageman wrote: > > On Mon, Mar 31, 2025 at 12:27 PM Nazir Bilal Yavuz wrote: > > > > I worked on an alternative approach, I refactored code a bit. It does > > not traverse the list two times and I think the code is more suitable

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

y for sure about that. And in that > context, I'd > suggest referring to that awesome statement in the documentation: "If in > doubt, > functions should be labeled as UNSAFE, which is the default." You may be right. I thought they are parallel safe as we acquire the buffer he

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

fercache_mark_dirty(): > Maybe edit the comment to: "Try to mark a shared buffer as dirty."? Done. > Maybe edit the elog text to: "bad shared buffer ID" - just to clarify > the case when > provided buffer number is negative (local buffer number). Although I think

Re: Draft for basic NUMA observability

Hi, Thank you for working on this! On Wed, 19 Mar 2025 at 12:06, Jakub Wartak wrote: > > On Tue, Mar 18, 2025 at 3:29 PM Bertrand Drouvot > wrote: > > Hi! v15 attached, rebased, CI-tested, all fixed incorporated. This needs to be rebased after 8eadd5c73c. -- Regards, Na

Re: read stream on amcheck

_NONE case and &rsdata for the rest. Example patch is attached, heapamcheck_rs_perblock_data is added to typedefs.list too. -- Regards, Nazir Bilal Yavuz Microsoft From 642a01c6298742879cefac1197d466b6fec5df7f Mon Sep 17 00:00:00 2001 From: Matheus Alcantara Date: Fri,

Re: CREATE DATABASE with filesystem cloning

Hi, Rebased version of the patch is attached. -- Regards, Nazir Bilal Yavuz Microsoft From d2eb46fb18258931f65e2b01ac6b406255f3c575 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz Date: Thu, 8 Aug 2024 15:01:48 +0300 Subject: [PATCH v10] Introduce file_copy_method GUC This GUC can be set to

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

ow that flush has happened, we just do not know if the buffer is flushed by us or someone else. [1] https://postgr.es/m/flat/76a550315baef9d7424b70144f1c6a2d%40postgrespro.ru -- Regards, Nazir Bilal Yavuz Microsoft

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

d it does not guarantee that it has > been > written to disk. I think flushed means 'passing the buffer contents to the kernel' in the Postgres context (as it is explained in the FlushBuffer()). We know that flush has happened, we just do not know if the buffer is flushed by us o

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

Hi, On Fri, 21 Mar 2025 at 01:25, Joseph Koshakow wrote: > > Hi I am working with Aidar to give a review and I am also a beginner > reviewer. Thank you so much for the review! > > From 813e5ec0da4c65970b4b1ce2ec2918e4652da9ab Mon Sep 17 00:00:00 2001 > > From: Nazir Bilal

Re: Improve monitoring of shared memory allocations

gh we assume both nbuckets and num_partition initialized as the same type, (*nbuckets) <<= 1 will cause an infinite loop if num_partition is bigger than MAX_TYPE / 2. So I think that the solution is to confirm that num_partition < MAX_NBUCKETS_TYPE / 2, what do you think? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

hed a trivial patch. LGTM. -- Regards, Nazir Bilal Yavuz Microsoft

Re: [PoC] Federated Authn/z with OAUTHBEARER

on to server on socket "/tmp/xZKYtq40nL/.s.PGSQL.21400" failed: failed to obtain access token: Unsupported protocol (libcurl: Received HTTP/0.9 when not allowed) [11:09:56.548] # ' [11:09:56.548] # matches '(?^:connection to database failed)' [11:09:56.548] # Looks like you failed 2 tests of 121. [11:09:56.548] [11:09:56.548] (test program exited with status code 2) [1] https://cirrus-ci.com/task/4621590844932096 -- Regards, Nazir Bilal Yavuz Microsoft

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

pg_buffercache_evict_all() functions do not necessarily mean these buffers are flushed by these functions. Remaining questions from the v1: On Wed, 12 Mar 2025 at 19:15, Nazir Bilal Yavuz wrote: > On Mon, 17 Feb 2025 at 19:59, Andres Freund wrote: > > On 2024-12-25 15:57:34 +0300, Nazir Bilal Ya

Re: per backend WAL statistics

Hi, On Mon, 10 Mar 2025 at 17:43, Bertrand Drouvot wrote: > On Mon, Mar 10, 2025 at 03:08:49PM +0300, Nazir Bilal Yavuz wrote: > > > I think that every time we flush IO or WAL stats, we want(?) to flush > > backend stats as well, > > Yeah, I think that's happening a

Re: meson vs. llvm bitcode files

well. One thing I noticed is that gen_srcfiles['srcfiles'] seems wrong. gen_sources is a better name compared to gen_srcfiles. So, I changed it to gen_sources in v4. -- Regards, Nazir Bilal Yavuz Microsoft From 578fbb407ce89293c8c955179e61b10aadc1709f Mon Sep 17 00:00:00 2001 From: Andr

Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

Hi, On Mon, 17 Feb 2025 at 19:59, Andres Freund wrote: > > Hi, Thanks for the review! And sorry for the late reply. > On 2024-12-25 15:57:34 +0300, Nazir Bilal Yavuz wrote: > > So, this patchset extends pg_buffercache with 3 functions: > > > > 1- pg_buffercach

Re: meson vs. llvm bitcode files

should get all or some of the generated backend sources > compiled to bitcode, similar to contrib modules. I think we can do this. I added other backend sources like you did in the PR but attached it as another patch (0007) because I wanted to hear other people's opinions on that first.

Re: per backend WAL statistics

code and did not find any example of that but I just wanted to be sure. If there is a case like that, then pgstat_backend_wal_have_pending() needs to check wal_bytes instead of wal_records. -- Regards, Nazir Bilal Yavuz Microsoft

Re: meson vs. llvm bitcode files

Hi, On Thu, 5 Sept 2024 at 12:24, Nazir Bilal Yavuz wrote: > > I found that Andres shared a patch > (v17-0021-meson-Add-LLVM-bitcode-emission.patch) a while ago [1]. Andres and I continued to work on that. I think the patches are in sharable state now and I wanted to hear opinio

Upgrade FreeBSD CI images to 14.2

upstream. Any kind of feedback would be appreciated. [1] https://github.com/anarazel/pg-vm-images/commit/3f2d728299808e76ce23b9b12ccfec944c86e318 [2] https://github.com/anarazel/pg-vm-images/commit/f1ea53c94ab864feb7c23d609bf85f0a1d568c9d -- Regards, Nazir Bilal Yavuz Microsoft From

Re: ci: Allow running mingw tests by default via environment variable

Hi, On Tue, 4 Mar 2025 at 03:28, Thomas Munro wrote: > > On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > > I propose that we instead run the task automatically if > > > $REPO_MINGW_TRIGGER_B

Re: Adding NetBSD and OpenBSD to Postgres CI

used 5G on /dev/sd0j +#swapon /dev/sd0j # fails with ENXIO... what am I missing? I think I found the problem, sd0j's fstype is not a swap. It worked like that: $ disklabel -E sd0 $ umount /usr/obj $ disklabel -E sd0 # prompts are: m -> j -> \n -> \n -> swap -> w -> q $ di

Re: read stream on amcheck

, LGTM. -- Regards, Nazir Bilal Yavuz Microsoft

Re: per backend WAL statistics

'll add it in the new patch serie for this thread (that simplifies the new > pg_stat_wal_build_tuple() among other things) unless Nazir beat me to it. > > [2]: https://www.postgresql.org/message-id/Z6L3ZNGCljZZouvN%40paquier.xyz I am working on some other stuff right now. Please feel

Re: Adding NetBSD and OpenBSD to Postgres CI

lse. Sure, I will work on this. Thank you for mentioning it. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

g is similar to that. On Thu, 6 Feb 2025 at 10:32, Bertrand Drouvot wrote: > > s/and the primary WAL some writes/and the primary some WAL writes/ I am not a native speaker but 'primary writes some WAL with its checkpointer' sounds better to me. -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

pgstat_tracks_io_op() and pgstat_tracks_io_object(), do you mean converting if statements to switch statements or something else? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

y -> ReadCheckpointRecord -> ReadRecord -> XLogPrefetcherReadRecord -> lrq_complete_lsn -> lrq_prefetch -> lrq->next = XLogPrefetcherNextBlock -> XLogReadAhead -> XLogDecodeNextRecord -> ReadPageInternal -> state->routine.page_read = XLogPageRead() ''' Is there a chance that the function chain above does not get triggered while running the stats.sql test? -- Regards, Nazir Bilal Yavuz Microsoft

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Tue, 4 Feb 2025 at 17:29, Nazir Bilal Yavuz wrote: > > Thanks! My benchmark results are the same [1]. I could not see the > noticable difference between master and patched version. I run the > benchmark a couple of times, sometimes the patched version, sometimes the > ma

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Tue, 4 Feb 2025 at 10:55, Michael Paquier wrote: > > On Mon, Feb 03, 2025 at 02:34:29PM +0300, Nazir Bilal Yavuz wrote: > > On Mon, 3 Feb 2025 at 11:50, Bertrand Drouvot < bertranddrouvot...@gmail.com> wrote: > >> === 1 > >> > >>

Re: Show WAL write and fsync stats in pg_stat_io

Hi, On Mon, 3 Feb 2025 at 11:50, Bertrand Drouvot wrote: > > Hi, > > On Mon, Feb 03, 2025 at 01:07:26PM +0900, Michael Paquier wrote: > > On Fri, Jan 31, 2025 at 11:29:31AM +0300, Nazir Bilal Yavuz wrote: > > > On Wed, 29 Jan 2025 at 18:16, Bertrand Drouvot > >

  1   2   3   4   >