Hi, Thank you for looking into this! And sorry for the late reply.
On Fri, 16 May 2025 at 10:58, Xuneng Zhou <xunengz...@gmail.com> wrote: > > Hey, > > I noticed a couple of small clarity issues in the current version of patch > for potential clean up: > > 1. Commit message wording I changed the commit message. I made it very similar to the commit message in dcf7e1697b. > We currently have: > > PinBuffer_Locked(desc); /* releases spinlock */ > > Folks who’re unfamiliar with this function might get confused. Maybe we could > use the one in GetVictimBuffer: > > > /* Pin the buffer and then release its spinlock */ > > PinBuffer_Locked(buf_hdr); > > > That spelling-out makes it obvious what’s happening. I think this makes sense, this is done in v8 which is attached to the email above. -- Regards, Nazir Bilal Yavuz Microsoft
