Re: pg_basebackup and error messages dependent on the order of the arguments

>> My point was not so much about --compress but rather giving a good error >> message. >Right, and my point was that the issue is bigger than --compress. >For example, you get exactly the same misbehavior with >$ pg_basebackup --checkpoint=fast --format=t -d --pgdata=/var/tmp/dummy >pg_baseback

Re: pg_basebackup and error messages dependent on the order of the arguments

>I wrote: >> As this example shows, we really ought to validate the compression >> argument on sight in order to get sensible error messages. The >> trouble is that for server-side compression the code wants to just >> pass the string through to the server and not form its own opinion >> as to whe

pg_basebackup and error messages dependent on the order of the arguments

Hi, shouldn't this give the same error message? $ pg_basebackup --checkpoint=fast --format=t --compress --pgdata=/var/tmp/dummy pg_basebackup: error: must specify output directory or backup target pg_basebackup: hint: Try "pg_basebackup --help" for more information. $ pg_basebackup --pgdata=/var

Re: src/backend/optimizer/util/plancat.c -> Is this correct English

>>I think it's fine. It could also be phrased like this: > >We do not need to lock the relation since... That's what I would have expected. But, as said, maybe this only sounds strange to me. Regards Daniel

src/backend/optimizer/util/plancat.c -> Is this correct English

Hi, just came across this: src/backend/optimizer/util/plancat.c -> Is this correct English? -> We need not lock the relation since it was already locked ... I am not a native speaker, but this sounds strange. Regards Daniel?

Re: type in basebackup_incremental.c ?

>Sent: Thursday, April 11, 2024 12:15 >To: Daniel Westermann (DWE) >Cc: PostgreSQL Hackers >Subject: Re: type in basebackup_incremental.c ? > >> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) >> wrote: >> >> Hi, >> >> /* >> * we expe

type in basebackup_incremental.c ?

Hi, /* * we expect the find the last lines of the manifest, including the checksum, * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental * parse step if we are about to overflow MAX_CHUNK bytes. */ Shouldn't this be: /* * we expect to find the last lines of the manifest,.

Re: Incorrect cost for MergeAppend

Hi, >Since we have a minor coming up very soon, I think it's not a good idea >to backpatch right now. Maybe you can push to master now, and consider >whether to backpatch later. >The problem is -- if somebody has an application that gets good plans >with the current cost model, and you change th

Compiler warning on Debian 12, PostgreSQL 16 Beta3

Hi, I've just noticed this warning when building on Debian 12: In file included from /usr/lib/llvm-14/include/llvm/Analysis/ModuleSummaryAnalysis.h:17, from llvmjit_inline.cpp:51: /usr/lib/llvm-14/include/llvm/IR/ModuleSummaryIndex.h: In constructor ‘llvm::ModuleSummaryIndex::M

Typo in src/backend/access/nbtree/README?

Hi, I am not a native English speaker, but shouldn't there be a "to" before "detect"? These two additions make it possible detect a concurrent page split Regards Daniel

pg_upgrade, tables_with_oids.txt -> tables_with_oids.sql?

Hi, as I've just upgraded an instance which contained tables "WITH OIDS" I wonder if it would make sense if pg_upgrade directly creates a script to fix those. I know it is easy to that with e.g. sed over tables_with_oids.txt but it would be more convenient to have the script generated directly.

Re: Changing "Hot Standby" to "hot standby"

>Looks the same as v5 for me, that applies the same consistency rules >everywhere in the docs.  So applied this one. Thank you, Michael

Re: Changing "Hot Standby" to "hot standby"

t;documentation and then continue with the other >>places. >Attached a new version which also modifies amcheck.sgml, config.sgml, >protocol.sgml, and mvcc.sgml accordingly. Regards Daniel From: Daniel Westermann (DWE) Sent: Wednesday, March 9, 2022 15:15 To: Michael Paquier Cc

Re: Changing "Hot Standby" to "hot standby"

>>Hmm.  Outside the title that had better use upper-case characters for >>the first letter of each word, I can see references to the pattern you >>are trying to eliminate in amcheck.sgml (1), config.sgml (3), >>protocol.sgml (3) and mvcc.sgml (1).  Shouldn't you refresh these as >>well if the point

Re: Changing "Hot Standby" to "hot standby"

Hi Michael, >On Wed, Mar 09, 2022 at 07:45:32AM +0000, Daniel Westermann (DWE) wrote: >> Thanks for having a look. Done that way. >Hmm.  Outside the title that had better use upper-case characters for >the first letter of each word, I can see references to the pattern you

Re: Changing "Hot Standby" to "hot standby"

>I think one more small change... >    A standby server can also be used for read-only queries, in which case >-   it is called a Hot Standby server. See for >+   it is called a hot standby server. See for >    more information. >    A standby server can also be used for read-only queries, in w

Re: Changing "Hot Standby" to "hot standby"

>>> Thanks for having a look. Are you suggesting to change it like this? >>> -Hot Standby is the term used to describe the ability to connect to >>> +Hot standby is the term used to describe the ability to connect to >>Yes. Isn't it the right form of a sentence? I've created and entry in

Re: Changing "Hot Standby" to "hot standby"

>> Thanks for having a look. Are you suggesting to change it like this? >> -    Hot Standby is the term used to describe the ability to connect to >> +    Hot standby is the term used to describe the ability to connect to >Yes.  Isn't it the right form of a sentence? Done like that. Regards Dani

Re: Changing "Hot Standby" to "hot standby"

Hi Kyotaro, >>    >>-    Hot Standby is the term used to describe the ability to connect to >>+    hot standby is the term used to describe the ability to connect to >They look like decapitalizing the first word in a sentsnce. Thanks for having a look. Are you suggesting to change it like this?

Re: Changing "Hot Standby" to "hot standby"

Hi Aleksander, > Pretty sure that for titles we should keep English capitalization rules. Done like that. Thanks for taking a look. Regards Danieldiff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml index b5b6042104..08eb1ad946 100644 --- a/doc/src/sgml/high-ava

Changing "Hot Standby" to "hot standby"

Hi, with reference to the discussion in docs: https://www.postgresql.org/message-id/flat/2221339.1645896597%40sss.pgh.pa.us#5a346c15ec2edbe8fcc93a1ffc2a7c7d Here is a patch that changes "Hot Standby" to "hot standby" in high-availability.sgml, so we have a consistent wording. Thoughts? There a

Re: faulty link

>The provided link >   https://www.postgresql.org/docs/release/ >leads to >   https://www.postgresql.org/docs/release/14.2/ >which gives 'Not Found' for me (Netherlands) Works fine for me in Germany Regards Daniel

Are we missing a dot in initdb's output?

Hi, this is more a cosmetic concern, but anyway: running initdb gives this output: ... creating configuration files ... ok running bootstrap script ... ok performing post-bootstrap initialization ... ok syncing data to disk ... ok initdb: warning: enabling "trust" authentication for local connec

Re: Should AT TIME ZONE be volatile?

>Laurenz Albe writes: >> On Thu, 2021-11-11 at 09:52 -0500, Tom Lane wrote: >>> Yup.  If we had reliable ways to detect changes in this sort of >>> environment-supplied data, maybe we could do something about it >>> (a la the work that's been happening on attaching collation versions >>> to indexe

Re: Tab completion for "create unlogged" a bit too lax?

>On Tue, Aug 24, 2021 at 11:32:14AM +0000, Daniel Westermann (DWE) wrote: >> tab completion for "create unlogged" gives this: >> >> postgres=# create unlogged >> MATERIALIZED VIEW  TABLE   >> >> Given that a materialized table can not be unlogge

Tab completion for "create unlogged" a bit too lax?

Hi, tab completion for "create unlogged" gives this: postgres=# create unlogged MATERIALIZED VIEW TABLE Given that a materialized table can not be unlogged: postgres=# create unlogged materialized view mv1 as select 1; ERROR: materialized views cannot be unlogged Should this really show

Re: Small typo in variable.c

>On Tue, Jul 27, 2021 at 10:04:36AM +0000, Daniel Westermann (DWE) wrote: >> there is a typo in variable.c. >> Attached a small fix for this. >"iff" stands for "if and only if". Ah, good to know. Thx Regards Daniel

Small typo in variable.c

Hi, there is a typo in variable.c. Attached a small fix for this. Regards Danieldiff --git a/src/bin/psql/variables.c b/src/bin/psql/variables.c index 92a34f870f..538b83ddd9 100644 --- a/src/bin/psql/variables.c +++ b/src/bin/psql/variables.c @@ -361,7 +361,7 @@ SetVariableHooks(VariableSpace spa

Re: check_function_bodies: At least the description seems wrong, since we have prodedures

>> It's possible the parameter name also appears in documentation for >> out-of-tree PLs, as each PL's validator function determines what >> "check_function_bodies" really means in that setting. >That parameter is also set explicitly in pg_dump output, so we >can't rename it without breaking exist

check_function_bodies: At least the description seems wrong, since we have prodedures

Hi, check_function_bodies has this description: postgres=# select short_desc from pg_settings where name = 'check_function_bodies'; short_desc --- Check function bodies during CREATE FUNCTION. (1 row) This is not

Another small guc.c fix

Hi, all "short_desc" end with a dot, except these: - Prefetch referenced blocks during recovery - Prefetch blocks that have full page images in the WAL Attached patch adds a dot to these as well. Regards Danieldiff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 46f1d6

Small typo in guc.c

Hi, there is a small typo in guc.c. Attached patch fixes this. Regards Danieldiff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 090abdad8b..46f1d6406f 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1320,7 +1320,7 @@ static struct confi

Re: src/tutorial/funcs.source: Wrong comment?

"Daniel Westermann (DWE)" writes: >> in "src/tutorial/funcs.source" there is this block: >> ... >> Actually it does work and I do not see a reason why this still should be >> commented. Thoughts? >Agreed and done. Thanks, Tom

src/tutorial/funcs.source: Wrong comment?

Hi, in "src/tutorial/funcs.source" there is this block: - -- Creating SQL Functions with multiple SQL statements -- you can also create functions that do more than just a SELECT. -- -- 14MAR99 Clark Evans: Does not quite work, commented out for now. -- --

Re: Parallel copy

On 27/10/2020 15:36, vignesh C wrote: >> Attached v9 patches have the fixes for the above comments. >I did some testing: I did some testing as well and have a cosmetic remark: postgres=# copy t1 from '/var/tmp/aa.txt' with (parallel 10); ERROR: value 10 out of bounds for option

Re: Wrong example in the bloom documentation

>I figured it out --- you have to use the larger generate_series value to >get the parallel output.  I have adjusted all the docs back to 9.6 to >show accurate output for that version, and simplified the query >ordering --- patch to master attached.  The other releases are similar. >Daniel, please

Re: Wrong example in the bloom documentation

On Fri, Oct  9, 2020 at 11:08:32AM -0400, Bruce Momjian wrote: > On Fri, Oct  9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote: > > Hi Bruce, Tom, > > > > On Thu, Oct  8, 2020 at 03:43:32PM -0400, Tom Lane wrote: > > >> "Daniel Westermann (DWE)&qu

Re: Wrong example in the bloom documentation

Hi Bruce, Tom, On Thu, Oct  8, 2020 at 03:43:32PM -0400, Tom Lane wrote: >> "Daniel Westermann (DWE)" writes: >> >> I was hoping someone more experienced with this would comment, but >> >> seeing none, I will apply it in a day or two to all supported ver

Re: Wrong example in the bloom documentation

Hi Bruce, >On Thu, Oct 8, 2020 at 06:34:32AM +0000, Daniel Westermann (DWE) wrote: >> Hi, >> >> as this does not get any attention on the docs-list, once again here. >> Any thoughts on this? >I was hoping someone more experienced with this would comment, but >

Wrong example in the bloom documentation

Hi, as this does not get any attention on the docs-list, once again here. Any thoughts on this? Regards Daniel From: Daniel Westermann (DWE) Sent: Sunday, September 27, 2020 17:58 To: Pg Docs Subject: Wrong example in the bloom documentation   Hi, I've briefly discussed this with

Re: Wrong sentence in the README?

"Daniel Westermann (DWE)" writes: >> in the README, top level, there is this: >> PostgreSQL has many language interfaces, many of which are listed here: >> https://www.postgresql.org/download >> I don't think the download page lists any language inter

Wrong sentence in the README?

Hi, in the README, top level, there is this: PostgreSQL has many language interfaces, many of which are listed here: https://www.postgresql.org/download I don't think the download page lists any language interfaces or do I miss something? Regards Daniel

Re: Fw: Documentation fix for adding a column with a default value

>>The suggested change pares down the "Tip" to more of a brief "Note", which >>IMHO is a bit >>terse for that section of the documentation (which has more of a tutorial >>character), >>and the contents of the original tip basically still apply for volatile >>default values >>anyway. >> >>I've at

Re: Fw: Documentation fix for adding a column with a default value

>> Seems the first mail didn't make it ... >Actually it did, I was about to reply to it :) > >The suggested change pares down the "Tip" to more of a brief "Note", which >IMHO is a bit >terse for that section of the documentation (which has more of a tutorial >character), >and the contents of th

Fw: Documentation fix for adding a column with a default value

>__ >From: Daniel Westermann (DWE) >Sent: Monday, July 15, 2019 13:01 >To: pgsql-hack...@postgresql.org >Subject: Documentation fix for adding a column with a default value > >Hi, > >the tip in the "Adding a column" section

Documentation fix for adding a column with a default value

Hi, the tip in the "Adding a column" section is not true anymore since PostgreSQL 11: https://www.postgresql.org/docs/current/ddl-alter.html#DDL-ALTER-ADDING-A-COLUMN Attached a patch proposal for this. Regards Daniel diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml ind