>> It's possible the parameter name also appears in documentation for
>> out-of-tree PLs, as each PL's validator function determines what
>> "check_function_bodies" really means in that setting.

>That parameter is also set explicitly in pg_dump output, so we
>can't rename it without breaking existing dump files.

>Admittedly, guc.c does have provisions for substituting new names
>if we rename some parameter.  But I'm not in a hurry to create
>more instances of that behavior; the potential for confusion
>seems to outweigh any benefit.

>+1 for updating the description though.  We could s/function/routine/
>where space is tight.

Thanks for your inputs. Attached a proposal which updates the description.

Regards
Daniel
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index ca378bd6af..d0a51b507d 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -1759,7 +1759,7 @@ static struct config_bool ConfigureNamesBool[] =
 	},
 	{
 		{"check_function_bodies", PGC_USERSET, CLIENT_CONN_STATEMENT,
-			gettext_noop("Check function bodies during CREATE FUNCTION."),
+			gettext_noop("Check routine bodies during CREATE FUNCTION and CREATE PROCEDURE."),
 			NULL
 		},
 		&check_function_bodies,

Reply via email to