Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET

On Mon, 17 Mar 2025 at 13:53, Michael Paquier wrote: > So, here is attached a counter-proposal, where we can simply added a > counter tracking a node count in _jumbleNode() to add more entropy to > the mix, incrementing it as well for NULL nodes. I had a look at this and it seems the main differe

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Tue, Mar 18, 2025 at 12:07 PM David G. Johnston wrote: > > On Monday, March 17, 2025, Shubham Khanna wrote: >> >> >> I have added validation for "all" to address both issues at once. >> > > Usage needs to be changed to refer to object types and we should try and > specify which are valid ther

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Monday, March 17, 2025, Shubham Khanna wrote: > > I have added validation for "all" to address both issues at once. > > Usage needs to be changed to refer to object types and we should try and specify which are valid there too. The sgml docs need to mention “all” as a valid value and what it

Re: pgsql: Avoid invalidating all RelationSyncCache entries on publication

On Mon, Mar 17, 2025 at 9:35 PM Robert Haas wrote: > > On Thu, Mar 13, 2025 at 12:00 AM Amit Kapila wrote: > > Avoid invalidating all RelationSyncCache entries on publication rename. > > > > On Publication rename, we need to only invalidate the RelationSyncCache > > entries corresponding to relat

Optimize truncation logic to reduce AccessExclusive lock impact

Hi hackers, We've encountered an issue where autovacuum holds an AccessExclusive lock for an extended period when attempting to truncate heap tables. The root cause appears to be the way autovacuum handles block truncation, specifically when scanning shared buffers during smgrtruncate. This issue

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Tue, Mar 18, 2025 at 5:48 AM David G. Johnston wrote: > > On Mon, Mar 17, 2025 at 4:01 PM Euler Taveira wrote: >> >> On Mon, Mar 17, 2025, at 9:34 AM, Shubham Khanna wrote: >> >> I have incorporated the "--remove/-r" parameter in the attached patch, >> as it seems more intuitive and straightfo

Re: pg_recvlogical requires -d but not described on the documentation

On Monday, March 17, 2025, Fujii Masao wrote: > > On 2025/03/12 14:59, David G. Johnston wrote: > >> On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) < >> kuroda.hay...@fujitsu.com > wrote: >> >> >> OK, so I will exclude the point in the thread. The patc

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Tue, Mar 18, 2025 at 4:31 AM Euler Taveira wrote: > > On Mon, Mar 17, 2025, at 9:34 AM, Shubham Khanna wrote: > > I have incorporated the "--remove/-r" parameter in the attached patch, > as it seems more intuitive and straightforward for users. > The attached patch contains the latest changes.

Re: Fix couple of typos

On Tue, Mar 18, 2025 at 8:49 AM vignesh C wrote: > > On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat > wrote: > > > > On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila wrote: > > > > > > On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote: > > > > > > > > While reviewing another patch, I found a couple of t

Re: Vacuum statistics

On 17.03.2025 09:42, vignesh C wrote: On Thu, 27 Feb 2025 at 23:30, Alena Rybakina wrote: Hi! On 17.02.2025 17:46, Alena Rybakina wrote: On 04.02.2025 18:22, Alena Rybakina wrote: Hi! Thank you for your review! On 02.02.2025 23:43, Alexander Korotkov wrote: On Mon, Jan 13, 2025 at 3:26 PM

Re: Re: proposal: schema variables

Hi po 17. 3. 2025 v 21:53 odesílatel Marcos Pegoraro napsal: > Em seg., 17 de mar. de 2025 às 15:33, Pavel Stehule < > pavel.steh...@gmail.com> escreveu: > >> I was asked for sending a reduced patchset >> > > Would be good to explain what this reduced patchset is. > Complete patch contains this

Re: making EXPLAIN extensible

> You only > need the second hook if you want to check the values of options > against the values of other options. +1 I did not think of adding a new hook, because there must be a really good reason to add a new hook. I think it's justified for this case. It's better than my approach since the ex

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

On Mon, Mar 17, 2025 at 8:02 PM Robert Haas wrote: > > On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada wrote: > > I've confirmed the issue and attached a patch to fix it. > > Cool. The commit message refers to 003_char_signedness, but the test > name is 005, not 003. Thank you for reviewing the

Re: Forbid to DROP temp tables of other sessions

Hi, On Tue, Mar 18, 2025 at 2:36 AM David G. Johnston wrote: > > "I want to give a better error message" is not a good enough reason to change > this long-standing behavior in a back-patchable bug fix. > and I do not agree that it is an improvement worth making in HEAD. OK, In this case I'd

RE: long-standing data loss bug in initial sync of logical replication

Dear hackers, Attached patch set contains proper commit message. It briefly describes the background and handlings. Regarding the PG13, the same commit message is used for 0001. 0002 is still rough. Renamed backpatches to .txt, to make cfbot happy. Thanks Hou working for it. Best regards, Haya

Re: Update Unicode data to Unicode 16.0.0

On Mon, 17 Mar 2025 at 23:03, Jeff Davis wrote: > > On Sun, 2025-03-16 at 19:10 +0530, vignesh C wrote: > > We currently have two Commitfest entries for the same thread at [1] > > and [2]. Are both still necessary, or can we consolidate tracking > > into > > a single entry? > > I'm fine removing m

Re: support fix query_id for temp table

On Mon, Mar 17, 2025 at 10:38:36PM +0100, Christoph Berg wrote: > Here's that patch with regression tests added. I would think changing > this would be a big usability improvement for anyone using temp tables > a lot. Not the first time I am seeing this argument this month. It is the second time.

Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row

On Wed, Mar 12, 2025 at 4:26 PM Jim Jones wrote: > > >> 2) Inconsistent terminology. Invalid values in "on_error set_to_null" > >> mode are names as "erroneous", but as "invalid" in "on_error stop" mode. > >> I don't want to get into the semantics of erroneous or invalid, but > >> sticking to one

Re: Fix couple of typos

On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat wrote: > > On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila wrote: > > > > On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote: > > > > > > While reviewing another patch, I found a couple of typos: > > > 1) subid should have been pubid in AlterPublicationOwner

Re: Add Pipelining support in psql

On Mon, Mar 17, 2025 at 10:50:50AM +0100, Anthonin Bonnefoy wrote: > 0001: This introduces the \sendpipeline meta-command and forbid \g in > a pipeline. This is to fix the formatting options of \g that are not > supported in a pipeline. - count - 4 -(1 row) This removal done in the

Re: Allow io_combine_limit up to 1MB

Here's a new version that also adjusts the code that just landed in da722699: - /* -* Each IO handle can have an PG_IOV_MAX long iovec. -* -* XXX: Right now the amount of space available for each IO is PG_IOV_MAX. -* While it's tempting to use the io_combine_l

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada wrote: > I've confirmed the issue and attached a patch to fix it. Cool. The commit message refers to 003_char_signedness, but the test name is 005, not 003. -- Robert Haas EDB: http://www.enterprisedb.com

Re: vacuumdb changes for stats import/export

> > > While preparing this for commit, I noticed that the expression index part > of the query was disregarding attstattarget. To fix, I've modified that > part to look at the index's pg_attribute entries. > +1, should have been there all along.

Re: vacuumdb changes for stats import/export

On Fri, Mar 14, 2025 at 02:05:30PM -0500, Nathan Bossart wrote: > If no feedback or objections materialize, I'm planning to commit these > early next week. While preparing this for commit, I noticed that the expression index part of the query was disregarding attstattarget. To fix, I've modified

Re: maintenance_work_mem = 64kB doesn't work for vacuum

On Tue, 18 Mar 2025 at 05:49, Masahiko Sawada wrote: > I've attached the patch. I added the minimum regression tests for that. I think the change to vacuumlazy.c is ok. The new test you've added creates a table called pvactst2 but then adds a test that uses the pvactst table. Did you mean to ski

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela escreveu: > > > Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera < > alvhe...@alvh.no-ip.org> escreveu: > >> On 2025-Mar-07, Álvaro Herrera wrote: >> >> > Anyway, my version of this is attached. It fixes the problems with your >> > patch, but

Re: optimize file transfer in pg_upgrade

On Mon, Mar 17, 2025 at 04:04:45PM -0400, Robert Haas wrote: > On Mon, Mar 17, 2025 at 3:34 PM Nathan Bossart > wrote: >> * Once committed, I should update one of my buildfarm animals to use >> PG_TEST_PG_UPGRADE_MODE=--swap. > > It would be better if we didn't need a separate buildfarm animal

Re: dsm_registry: Add detach and destroy features

Regression test failed because I didn't add an extra new line in the expected file. 2025년 3월 17일 (월) 오전 9:55, Sungwoo Chang 님이 작성: > > There was a minor typo in the test module. I built and ran the > test_dsm_registry extension before submitting the patch but perhaps it > got mixed up with an olde

Re: Separate GUC for replication origins

On Mon, Mar 17, 2025, at 8:44 PM, Masahiko Sawada wrote: > I would suggest putting the new max_active_replication_origins after > max_parallel_apply_workers_per_subscription as both > max_sync_workers_per_subscription and > max_parallel_apply_workers_per_subscription are related to > max_logical_re

Re: Statistics Import and Export

On Mon, Mar 17, 2025 at 07:24:46PM -0400, Corey Huinker wrote: > On Mon, Mar 17, 2025 at 10:24 AM Nathan Bossart > wrote: >> I'm assuming that writing a completely different TOC on the second pass >> would corrupt the dump file. Perhaps we could teach it to skip stats >> entries on the second pas

Re: Support a wildcard in backtrace_functions

On Wed, 26 Feb 2025 at 16:40, Tom Lane wrote: > If there's no place where > that can plausibly be done, maybe you don't need the typedef after > all? Makes sense, I removed the unused LogBacktraceVerbosity typedef now. It caused a rebase conflict just now, so this also solves that. From 579ac166a

Re: Add semi-join pushdown to postgres_fdw

Hi Alexander, On Mon, 4 Dec 2023 at 07:22, Alexander Korotkov wrote: > > > Now, I think this looks good. I'm going to push this if no objections. After this commit, I began seeing an unexpected ERROR - see this bug-report. https://www.postgresql.org/message-id/18852-fb75b88160678f78%40postgresq

Re: Add semi-join pushdown to postgres_fdw

Hi, Robins! On Tue, Mar 18, 2025 at 2:20 AM Robins Tharakan wrote: > On Mon, 4 Dec 2023 at 07:22, Alexander Korotkov wrote: > > > > > > Now, I think this looks good. I'm going to push this if no objections. > > After this commit, I began seeing an unexpected ERROR - see this bug-report. > https

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Mon, Mar 17, 2025 at 4:01 PM Euler Taveira wrote: > On Mon, Mar 17, 2025, at 9:34 AM, Shubham Khanna wrote: > > I have incorporated the "--remove/-r" parameter in the attached patch, > as it seems more intuitive and straightforward for users. > The attached patch contains the latest changes. >

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

On Tue, 11 Mar 2025 at 16:53, Peter Geoghegan wrote: > > On Sat, Mar 8, 2025 at 11:43 AM Peter Geoghegan wrote: > > I plan on committing this one soon. It's obviously pretty pointless to > > make the BTMaxItemSize operate off of a page header, and not requiring > > it is more flexible. > > Commit

Re: md.c vs elog.c vs smgrreleaseall() in barrier

Hi, On 2025-03-14 12:57:51 +1300, Thomas Munro wrote: > On Fri, Mar 14, 2025 at 12:23 PM Andres Freund wrote: > > > > 3. Considering errfinish()'s stated goal, a sort of backstop to help > > > you cancel looping message-spewing code only, I wonder if we should > > > just restrict the kinds of i

Re: RFC: Allow EXPLAIN to Output Page Fault Information

On Mon, 10 Feb 2025 at 14:23, torikoshia wrote: > Thanks for reviewing the patch and comments! > Fixed issues you pointed out and attached v2 patch. This patch needs a rebase, because it's failing to compile currently. So I marked this as "Waiting on Author" in the commitfest app.

Re: Separate GUC for replication origins

On Thu, Mar 13, 2025 at 5:55 PM Euler Taveira wrote: > > On Thu, Mar 13, 2025, at 11:10 AM, vignesh C wrote: > > Few comments: > > > Thanks for taking a look. > > 1) After selecting max_active_replication_origins setting in the > SELECT query having order by, the first record returned will be the

Re: Separate GUC for replication origins

On Fri, Mar 14, 2025, at 5:48 AM, vignesh C wrote: > 1) Should we add a test case to verify that if > max_active_replication_origins is set to -1, it will use > max_replication_slots value: I don't think so. I added the following assert to test exactly this condition. if (max_active_repli

Re: ecdh support causes unnecessary roundtrips

On Thu, Mar 13, 2025 at 2:41 PM Daniel Gustafsson wrote: > OpenSSL 3.4 also doesn't like it and AFAICT neither does the upcoming 3.5, > just > haven't had the cycles yet to ship out a new patch with all the time-consuming > testing it requires =) Here is a squash fix to change the capitalization

Re: dblink: Add SCRAM pass-through authentication

On Mon, Mar 17, 2025 at 11:54 AM Matheus Alcantara wrote: > > If the check functions aren't going to check those because it's > > unnecessary, then that's fine, but then the comments should be > > adjusted. > > > Ok, now I get all of your points. I've misinterpreted your comments, > sorry about th

Re: Statistics Import and Export

On Mon, Mar 17, 2025 at 10:24 AM Nathan Bossart wrote: > On Sun, Mar 16, 2025 at 05:32:15PM -0400, Corey Huinker wrote: > >> > >> * The custom format actually does two WriteToc() calls, and since these > >> patches move the queries to this part of pg_dump, it means we'll run > all > >> the qu

Re: Update Unicode data to Unicode 16.0.0

On Sat, 2025-03-15 at 12:15 -0400, Tom Lane wrote: > In fact, on the analogy of timezones, I think we should not only > adopt newly-published Unicode versions pretty quickly but push > them into released branches as well. That approach suggests that we consider something like my previous STRICT_UN

Re: Bump soft open file limit (RLIMIT_NOFILE) to hard limit on startup

On Mon Feb 24, 2025 at 12:01 PM CET, Jelte Fennema-Nio wrote: Right after pressing send I realized I could remove two more useless lines... Rebased patchset attached (trivial conflict against pg_noreturn changes). From 249ebbac1b6c01b99795cfe9b0201ab7ee6bacfa Mon Sep 17 00:00:00 2001 From: Jel

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

On Mon, Mar 17, 2025 at 10:20 AM Robert Haas wrote: > > On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada > wrote: > > pg_upgrade: Preserve default char signedness value from old cluster. > > Hi, > > I noticed that after running 'meson test --suite setup --suite > pg_upgrade', the file delete_old_

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 02:21, Jelte Fennema-Nio wrote: > > The next commitfest app release is planned for March 18th I deployed the latest release of the commitfest app. Below is a changelog that's slightly updated. 1. Major change: There's a new /me page which shows a dashboard of open patches w

Re: BitmapHeapScan streaming read user and prelim refactoring

On Mon, Mar 17, 2025 at 2:55 PM Andres Freund wrote: > > On 2025-03-17 14:52:02 -0400, Melanie Plageman wrote: > > I don't feel strongly that we need to be as rigorous for > > maintenance_io_concurrency, but I'm also not sure 160 seems reasonable > > (which would be the same ratio as before). > >

Re: support fix query_id for temp table

Re: Michael Paquier > On Thu, Feb 01, 2024 at 07:37:32AM +, ma lz wrote: > > session 1: > > create temp table ttt ( a int ); > > insert into ttt values(3); -- query_id is XXX from > > pg_stat_activity > > > > session 2: > > create temp table ttt ( a int ); > > insert

Re: AIO v2.5

On Fri, Mar 14, 2025 at 3:43 PM Andres Freund wrote: > > Open items: > > - Right now effective_io_concurrency cannot be set > 0 on Windows and other > platforms that lack posix_fadvise. But with AIO we can read ahead without > posix_fadvise(). > > It'd not really make anything worse than tod

Re: Re: proposal: schema variables

Em seg., 17 de mar. de 2025 às 15:33, Pavel Stehule escreveu: > I was asked for sending a reduced patchset > Would be good to explain what this reduced patchset is. Complete patch contains this and that Reduced patch contains only this. Regards Marcos

Re: Make COPY format extendable: Extract COPY TO format implementations

On Tue, Mar 4, 2025 at 4:06 PM Sutou Kouhei wrote: > > Hi, > > In > "Re: Make COPY format extendable: Extract COPY TO format implementations" > on Mon, 3 Mar 2025 11:06:39 -0800, > Masahiko Sawada wrote: > > > I agree with the fix and the patch looks good to me. I've updated the > > commit

Re: Add -k/--link option to pg_combinebackup

On Mon, Mar 17, 2025 at 2:17 PM Nathan Bossart wrote: > I think koel might complain. pgindent on my machine yields the following: Indeed, it did. I still think it's a mistake to have testing for this in the buildfarm and not in 'meson test' or CI. -- Robert Haas EDB: http://www.enterprisedb.co

Re: Forbid to DROP temp tables of other sessions

On Mon, Mar 17, 2025 at 10:58 AM Daniil Davydov <3daniss...@gmail.com> wrote: > > Please see v4 patch (only comment change). > > /* - * For missing_ok, allow a non-existent schema name to - * return InvalidOid. + * We don't allow users to access temp tables of other + * sessions (consider adding

Re: optimize file transfer in pg_upgrade

On Mon, Mar 17, 2025 at 3:34 PM Nathan Bossart wrote: > * Once committed, I should update one of my buildfarm animals to use > PG_TEST_PG_UPGRADE_MODE=--swap. It would be better if we didn't need a separate buildfarm animal to test this, because that means you won't get notified by local testin

Re: ZStandard (with dictionaries) compression support for TOAST compression

On Fri, Mar 7, 2025 at 8:36 PM Nikhil Kumar Veldanda wrote: > struct/* Extended compression format */ > { > uint32va_header; > uint32va_tcinfo; > uint32va_cmp_alg; > uint32va_cmp_dictid; > charva_data[FLEXIBLE_ARRAY_MEMBER]; >

Re: optimize file transfer in pg_upgrade

On Wed, Mar 05, 2025 at 08:34:37PM -0600, Nathan Bossart wrote: > Thank you, Greg and Robert, for sharing your thoughts. With that, here's > what I'm considering to be a reasonably complete patch set for this > feature. This leaves about a month for rigorous testing and editing, so > I'm hopeful

Re: Forbid to DROP temp tables of other sessions

On Mon, Mar 17, 2025 at 10:58 AM Daniil Davydov <3daniss...@gmail.com> wrote: > 2) Is this really the implementation detail that we want to hide from the > user? User can just run "select pg_my_temp_schema();" and see that > there is no temp schema in the current session. > No ordinary user uses

Re: optimize file transfer in pg_upgrade

On Wed, Mar 5, 2025 at 03:40:52PM -0500, Greg Sabino Mullane wrote: > On Wed, Mar 5, 2025 at 2:43 PM Nathan Bossart > wrote: > > One other design point I wanted to bring up is whether we should bother > generating a rollback script for the new "swap" mode.  In short, I'm > wondering

Re: pg_stat_statements and "IN" conditions

On 2025-Mar-17, Álvaro Herrera wrote: > You can see my patch on top of yours here: > https://github.com/alvherre/postgres/commits/query_id_squash_values/ > and the CI run here: > https://cirrus-ci.com/build/5660053472018432 Heh, this blew up on bogus SGML markup :-( Fixed and running again: http

Re: pg_stat_statements and "IN" conditions

On 2025-Feb-14, Dmitry Dolgov wrote: > This should do it. The last patch for today, otherwise I'll probably add > more bugs than features :) Thank you. I've spent some time with this patch in the last few days, and I propose a few changes. I renamed everything from "merge" to "squash"; apart fr

Re: dead code in pg_upgrade

On Mon, Mar 17, 2025 at 01:56:49PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> I noticed that the condition it's referring to >> if (strlen(old_cluster.tablespace_suffix) == 0) >> doesn't appear to have been reachable since support for upgrading from >> pre-9.2 was removed in v

Re: BitmapHeapScan streaming read user and prelim refactoring

Hi, On 2025-03-17 14:52:02 -0400, Melanie Plageman wrote: > I don't feel strongly that we need to be as rigorous for > maintenance_io_concurrency, but I'm also not sure 160 seems reasonable > (which would be the same ratio as before). I'd lean towards just setting them to the same value for now.

Re: dblink: Add SCRAM pass-through authentication

On Mon, Mar 17, 2025 at 1:49 PM Jacob Champion wrote: > > On Thu, Mar 13, 2025 at 2:38 PM Matheus Alcantara > wrote: > > I thought about this; The problem is that at this point, the scram keys > > on connection options are base64 encoded (see appendSCRAMKeysInfo), so > > we can't compare with the

Re: BitmapHeapScan streaming read user and prelim refactoring

On Mon, Mar 17, 2025 at 3:44 AM Jakub Wartak wrote: > > dunno, I've just asked if it isn't suspicious to anyone except me else > that e_io_c > m_io_c rather than e_io_c <= m_io_c. My understanding > was always that to tune max IO queue depth you would do this: > a. up to N backends (up to max_conn

Re: Add -k/--link option to pg_combinebackup

On Mon, Mar 17, 2025 at 02:10:14PM -0400, Robert Haas wrote: > Now, to see if the buildfarm explodes... I think koel might complain. pgindent on my machine yields the following: diff --git a/src/bin/pg_combinebackup/copy_file.c b/src/bin/pg_combinebackup/copy_file.c index 97ecda5a66d..b0c94f6ee

Re: Add -k/--link option to pg_combinebackup

On Thu, Mar 6, 2025 at 6:18 AM Israel Barth Rubio wrote: > > I'm happy with this now, so barring objections or complaints from CI, > > I plan to commit it soon. > > Great, thank you! "Soon" ended up being somewhat later than planned, because I've been out of town, but done now. Now, to see if th

Re: Update Unicode data to Unicode 16.0.0

Jeff Davis writes: > That was discussed a few times, but: > (a) That doesn't exactly solve the problem, because people still need > indexes on LOWER() or CASEFOLD(); and > (b) If we change IMMUTABLE to mean "returns the same results on every > platform for all time", that would be too strict for

Re: Forbid to DROP temp tables of other sessions

Hi, On Mon, Mar 17, 2025 at 10:09 PM David G. Johnston wrote: > > On Monday, March 17, 2025, Daniil Davydov <3daniss...@gmail.com> wrote: >> >> >> > >> > 2."you have not any temporary relations" --> "you have no any temporary >> > relations" >> I am not an English speaker, but it seems that "have

Re: dead code in pg_upgrade

Nathan Bossart writes: > I noticed that the condition it's referring to > if (strlen(old_cluster.tablespace_suffix) == 0) > doesn't appear to have been reachable since support for upgrading from > pre-9.2 was removed in v15 (commit e469f0a). Before then, this case seems > to have on

Re: Update Unicode data to Unicode 16.0.0

On Sun, 2025-03-16 at 19:10 +0530, vignesh C wrote: > We currently have two Commitfest entries for the same thread at [1] > and [2]. Are both still necessary, or can we consolidate tracking > into > a single entry? I'm fine removing my CF entry, but unfortunately there's no "withdrawn -- duplicate

dead code in pg_upgrade

While trying to decipher this comment: /* * Do the old cluster's per-database directories share a directory * with a new version-specific tablespace? */ I noticed that the condition it's referring to if (strlen(o

Re: Update Unicode data to Unicode 16.0.0

On Sat, 2025-03-15 at 18:23 -0700, Jeremy Schneider wrote: > Is the simple answer that functions & clauses related to both time > zones and character semantics should just all be considered STABLE > instead of IMMUTABLE? That was discussed a few times, but: (a) That doesn't exactly solve the prob

Re: Restrict copying of invalidated replication slots

On Sun, Mar 9, 2025 at 11:16 PM Shlok Kyal wrote: > > On Fri, 28 Feb 2025 at 08:56, Amit Kapila wrote: > > > > On Fri, Feb 28, 2025 at 5:10 AM Masahiko Sawada > > wrote: > > > > > > On Thu, Feb 27, 2025 at 12:52 AM Amit Kapila > > > wrote: > > > > > > > > On Thu, Feb 27, 2025 at 10:47 AM Masa

Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

On Thu, Mar 13, 2025 at 10:56 AM Andres Freund wrote: > > Given the choice between a usually-working PAM module with known > > architectural flaws, and not having PAM at all, I think many users > > would rather continue using what's working for them. > > authentication_timeout currently doesn't re

Re: Statistics Import and Export

On Sun, Mar 16, 2025 at 05:32:15PM -0400, Corey Huinker wrote: >> >> * The custom format actually does two WriteToc() calls, and since these >> patches move the queries to this part of pg_dump, it means we'll run all >> the queries twice. The comments around this code suggest that the second >

Re: plperl version on the meson setup summary screen

On 2025-03-17 Mo 4:43 AM, Zharkov Roman wrote: On 2025-03-14 13:08, vignesh C wrote: One suggestion, there are many other external libraries for which we don't display the version, can we include the version for them too: Hello, We have seven "libraries" whose versions meson does not show: b

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada wrote: > pg_upgrade: Preserve default char signedness value from old cluster. Hi, I noticed that after running 'meson test --suite setup --suite pg_upgrade', the file delete_old_cluster.sh is left behind in the source directory, which should not ha

Re: Incorrect result of bitmap heap scan.

Hi, On 2025-03-17 16:17:03 +0100, Matthias van de Meent wrote: > As I understand it, Andres agrees that the feature is unsalvageable in > backbranches ("don't think there's a realistic way to fix it"). Andres > then continues to elaborate that even if the feature were salvageable, > it wouldn't co

Re: Forbid to DROP temp tables of other sessions

On Sunday, March 16, 2025, Daniil Davydov <3daniss...@gmail.com> wrote: > Hi, > > On Sun, Mar 16, 2025 at 7:53 PM vignesh C wrote: > > I noticed that the following Andrey's comment regarding the isolation > > test from [1] and Andres's comment from [2] are pending. I'm changing > > the commitfes

Re: Forbid to DROP temp tables of other sessions

Hi, On Mon, Mar 17, 2025 at 8:29 PM Steven Niu wrote: > > If the (relation->relpersistence == RELPERSISTENCE_TEMP) can ensure the > myTempNamespace is always valid, then my comment can be ignored. No, even if we see a temporary table in RangeVarGetRelidExtended, MyTempNamespace still can be `Inv

Re: Skip collecting decoded changes of already-aborted transactions

On Thu, Mar 13, 2025 at 10:04 PM Hayato Kuroda (Fujitsu) wrote: > > Dear hackers, > > I hope I'm in the correct thread. In abfb296, rbtxn_skip_prepared() was > removed from > SnapBuildDistributeNewCatalogSnapshot(). ISTM it was an only caller of the > function. > > Is it an intentional for exter

Re: Prune partitions by ScalarArrayOpExpr with an array parameter (partkey = ANY($1))

po 17. 3. 2025 v 14:28 odesílatel Andrei Lepikhov napsal: > Hi, > > As I see, initial pruning doesn't work in the case when a > ScalarArrayOpExpr contains a parameter as the RHS of the expression, > like following: > > partkey = ANY($1) > > As colleagues say, it is quite typical to use stored pro

RE: AIX support

Hi Team, Here are the updates on the meson on AIX. Our team had pushed the fixes meson github here … https://github.com/mesonbuild/meson/pull/14335 #14335 Enhance AIX shared library build to use an export List.

Re: Some read stream improvements

Hi, On 2025-03-14 22:03:15 +1300, Thomas Munro wrote: > I have pushed the new pin limit patches, after some more testing and > copy editing. I dropped an unnecessary hunk (in read_stream_reset(), a > change I'd like to make but it didn't belong in this commit) and > dropped the word "Soft" from Ge

Re: Unify a recently-added inconsisnt message

Kyotaro Horiguchi writes: > I noticed that the recent commit cd3c45125d2 introduced the following > three inconsistent messages at the same time: > pg_dump.c: > + printf(_(" --no-policiesdo not dump row security > policies\n")); > pg_dumpall.c: > + printf(_(" --no-po

Re: dblink: Add SCRAM pass-through authentication

On Thu, Mar 13, 2025 at 2:38 PM Matheus Alcantara wrote: > I thought about this; The problem is that at this point, the scram keys > on connection options are base64 encoded (see appendSCRAMKeysInfo), so > we can't compare with the values stored on MyProcPort. I don't think that's necessary -- th

Re: maintenance_work_mem = 64kB doesn't work for vacuum

On Mon, Mar 10, 2025 at 2:53 AM David Rowley wrote: > > On Mon, 10 Mar 2025 at 17:22, Masahiko Sawada wrote: > > Regarding that patch, we need to note that the lpdead_items is a > > counter that is not reset in the entire vacuum. Therefore, with > > maintenance_work_mem = 64kB, once we collect at

Re: Draft for basic NUMA observability

Hi, On Mon, Mar 17, 2025 at 08:28:46AM +0100, Jakub Wartak wrote: > On Fri, Mar 14, 2025 at 1:08 PM Bertrand Drouvot > wrote: > > > > I did prepare a patch file (attached as .txt to not disturb the cfbot) to > > apply > > on top of v11 0002 (I just rebased it a bit so that it now applies on top

Re: pgsql: Avoid invalidating all RelationSyncCache entries on publication

On Thu, Mar 13, 2025 at 12:00 AM Amit Kapila wrote: > Avoid invalidating all RelationSyncCache entries on publication rename. > > On Publication rename, we need to only invalidate the RelationSyncCache > entries corresponding to relations that are part of the publication being > renamed. > > As pa

Re: libpq: Process buffered SSL read bytes to support records >8kB on async API

On Sun, Mar 16, 2025 at 6:14 AM vignesh C wrote: > @Jacob, could you find some time to wrap this up? This will help us > assess whether it can be refined into a committable state soon. This is a bug report that likely requires backpatching; feature freeze should not be an issue here. Thanks, --J

Re: 64 bit numbers vs format strings

Thomas Munro writes: > On Mon, Mar 17, 2025 at 8:09 PM Tom Lane wrote: >> Hmm, I find that comment fairly scary. How do we know that the >> runtime library actually gets this right on every supported platform? > I don't know too much about libintl and its history other than what > I've looked u

Re: Adding support for SSLKEYLOGFILE in the frontend

On Sun, Mar 16, 2025 at 6:49 AM Daniel Gustafsson wrote: > IIRC the reasoning has been that if a rogue user can inject an environment > variable into your session and read your files it's probably game over > anyways. (Personally I'm no longer as convinced by this line of argument as I once was.

Re: PATCH: warn about, and deprecate, clear text passwords

On Sun, Mar 16, 2025 at 11:36 PM David G. Johnston wrote: > It could also be: > > warning: your password is known to Big Brother > hint: use psql \password to supply a private password, or see “docs/wiki > page” for more details and a way to pre-compute and send a private password > via SQL. OK

Re: lwlocknames.h beautification attempt

On 2025-Mar-17, Robert Haas wrote: > On Mon, Mar 17, 2025 at 2:43 AM Álvaro Herrera > wrote: > > Tom didn't say he didn't like this change. He said he didn't like a > > different change, which is not the one I committed. > > Sorry, I should have read the emails more carefully. I missed the fac

Re: lwlocknames.h beautification attempt

On Mon, Mar 17, 2025 at 2:43 AM Álvaro Herrera wrote: > Tom didn't say he didn't like this change. He said he didn't like a > different change, which is not the one I committed. Sorry, I should have read the emails more carefully. I missed the fact that there were two different proposals. It was

Re: TOAST versus toast

On 3/17/25 00:24, Tom Lane wrote: Note the lack of any upper case. Shortly later we reverse-engineered an acronym for it [2], with the winner being Tom Lockhart's The Oversized-Attribute Storage Technique Which made it into an acronym. Acronyms are typically capitalized to distinguish t

Re: Incorrect result of bitmap heap scan.

On Sun, 16 Mar 2025 at 13:55, vignesh C wrote: > > On Wed, 5 Mar 2025 at 16:43, Matthias van de Meent > wrote: > > > > On Sun, 2 Mar 2025 at 01:35, Tom Lane wrote: > > > > > > Peter Geoghegan writes: > > > > Is everybody in agreement about committing and back patching this fix, > > > > which si

Re: Disabling vacuum truncate for autovacuum

On Sun, Mar 16, 2025 at 06:24:59PM -0400, Robert Treat wrote: > So if the general idea is a guc "vacuum_truncate" which sets a global > default for whether vacuums and autovacuums should do truncation, and > we then have the storage parameter which would override the global > setting. And to be cle

Re: Forbid to DROP temp tables of other sessions

On Monday, March 17, 2025, Daniil Davydov <3daniss...@gmail.com> wrote: > > > > > 2."you have not any temporary relations" --> "you have no any temporary > > relations" > I am not an English speaker, but it seems that "have not" would be > more correct. Someone has to judge us :) > > Both are not

Re: [PoC] Federated Authn/z with OAUTHBEARER

On Mon, Mar 17, 2025 at 4:37 AM Nazir Bilal Yavuz wrote: > > Hi, > > I just wanted to report that the 'oauth_validator/t/001_server.pl' > test failed on FreeBSD in one of my local CI runs [1]. I looked at the > thread but could not find the same error report; if this is already > known, please exc

  1   2   >