On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada <msaw...@postgresql.org> wrote: > pg_upgrade: Preserve default char signedness value from old cluster.
Hi, I noticed that after running 'meson test --suite setup --suite pg_upgrade', the file delete_old_cluster.sh is left behind in the source directory, which should not happen. Everything created for the tests should be created in the meson directories. I traced the problem down to 005_char_signedness.pl. I believe the problem is likely that other pg_upgrade TAP tests include this locution, whereas 005_char_signedness.pl does not: # In a VPATH build, we'll be started in the source directory, but we want # to run pg_upgrade in the build directory so that any files generated finish # in it, like delete_old_cluster.{sh,bat}. chdir ${PostgreSQL::Test::Utils::tmp_check}; Regards, -- Robert Haas EDB: http://www.enterprisedb.com