On Mon, Mar 17, 2025 at 2:43 AM Álvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Tom didn't say he didn't like this change. He said he didn't like a > different change, which is not the one I committed.
Sorry, I should have read the emails more carefully. I missed the fact that there were two different proposals. It was the idea of right-aligning things that I was unhappy about. So, no objection to what you actually committed... except that I don't think that using % specifiers in SOME places in a format string is better than using them in ALL the places. It's not broken because $lockidx can't contain a % sign, but in general I think when we switch from print to printf it's better for us to have the format string be a constant so that it's clear that we can't accidentally get an extra % escape in there depending on the values of variables being interpolated. -- Robert Haas EDB: http://www.enterprisedb.com
