> I think there is a difference. A collation is a database object, a
> collation order is the order produced when invoking that collation.
> For example, in amcheck.sgml:
>
> """
> ... an inconsistency in the collation order between a primary server
> and a standby server ...
> """
>
> If we wro
On Fri, Dec 13, 2024 at 5:53 PM Melanie Plageman
wrote:
> On Thu, Nov 7, 2024 at 10:42 AM Andres Freund wrote:
> > Hi,
>
> Thanks for the review!
> Attached v2 should address your feedback and also fixes a few bugs with v1.
>
> I've still yet to run very long-running benchmarks. I did start runni
On Fri, Dec 13, 2024 at 3:01 AM Masahiko Sawada wrote:
>
> DDLs write not only XLOG_XACT_INVALIDATIONS but also system catalog
> changes. I think that when decoding these system catalog changes, we
> end up calling SnapBuildProcessChange(). I understand that decoding
> XLOG_XACT_INVALIDATIONS does
On Sun, Dec 15, 2024 at 04:50:57PM +1300, Thomas Munro wrote:
> On Sun, Dec 15, 2024 at 3:27 PM Noah Misch wrote:
> > yielding mojibake
>
> Thank you for this magnificent terminology.
Thank you for reviewing.
> > What we can do safely is exit if we could not convert the command line to
> > the
On Sun, Dec 15, 2024 at 3:27 PM Noah Misch wrote:
> yielding mojibake
Thank you for this magnificent terminology.
> What we can do safely is exit if we could not convert the command line to the
> Windows ANSI code page (losslessly). Patch attached.
This seems to make sense generally, since (ba
Greetings pgsql devs,
I would appreciate a review of my strategy for backporting the commits
related to CVE-2024-10978. (I am working with versions 11, 9.6, and 9.4,
for some older Debian releases.)
My conclusion is that of the two commits associated with CVE-2024-10978,
both are required in 11 a
The security team received a report about misbehavior when a Windows program
executes a PostgreSQL program, passing a wide character on the command line.
Every such character gets translated to something else. Of note, a U+FF02
FULLWIDTH QUOTATION MARK in the caller-provided command line becomes U
Since ~2019, Windows has option "Beta: Use Unicode UTF-8 for worldwide
language support". That option breaks the appendShellString() assumption that
it can escape every byte except '\0', '\r'. and '\n'. Instead, process
creation injects U+FFFD REPLACEMENT CHARACTER (UTF-8: ef bf bd) for each byte
On Wed, Dec 11, 2024 at 2:32 PM Zhijie Hou (Fujitsu)
wrote:
>
> Attach the V16 patch set which addressed above comments.
>
Review Comments
1.
+/*
+ * Workhorse for the RCI_WAIT_FOR_LOCAL_FLUSH phase.
+ */
+static void
+wait_for_local_flush(RetainConflictInfoData *data)
+{
...
+ /
On Sat, Dec 14, 2024 at 09:57:11PM +, Dagfinn Ilmari Mannsåker wrote:
> While I was going through the TAP tests to fix the formatting of command
> argument lists to be less confusing, I noticed that pg_combinebackup's
> 002_compare_backups.pl test accidentally ran pg_dumpall twice against
> the
Here's the remaining two patches in the current set. This is just
to pacify the cfbot: I've not done anything to them, just verified
that they still apply and pass regression.
regards, tom lane
>From 9c5235cd123eeb55b95b8bfd281dfcc37df197c5 Mon Sep 17 00:00:00 2001
From:
Hi hackers,
While I was going through the TAP tests to fix the formatting of command
argument lists to be less confusing, I noticed that pg_combinebackup's
002_compare_backups.pl test accidentally ran pg_dumpall twice against
the same database, thus rendering the tests useless.
Fixing that reveal
I wrote:
> I see that the cfbot is unhappy because it doesn't understand
> that some of the patches have been applied already. I am going
> to go ahead and get the earthdistance one done, because we have
> a live problem report about that [1]. I'll rebase and repost
> the remainder afterwards.
P
On 12/13/24 00:04, Tomas Vondra wrote:
> ...
>
> The main difference is here:
>
>
> master / no parallel workers:
>
> pages: 0 removed, 221239 remain, 221239 scanned (100.00% of total)
>
> 1 parallel worker:
>
> pages: 0 removed, 221239 remain, 10001 scanned (4.52% of total)
>
>
> Clearl
Michael Paquier writes:
> Doing that step-by-step is better than nothing, hence limiting the use
> of named parameters for only the functions whose body is rewritten is
> fine by me, as a first step, as long as the names are used rather the
> dollar parameter numbers. I'd suggest to do take the b
On 14.12.24 03:32, Tatsuo Ishii wrote:
Currently in the docs both "collation" and "collation order" are
used. I think this is confusing because IMO "collation" implies
"order", and "collation order" is redundant.
I think there is a difference. A collation is a database object, a
collation ord
On 13.12.24 20:54, Andres Freund wrote:
Another wrinkle: While __attribute__((noreturn)) works for function pointers
(or function pointer typedefs) _Noreturn doesn't. Gah. We only use it that
way in two places, but still :(
Yeah, I wrote an experimental patch for noreturn support some years ag
On 13.12.24 20:10, Andres Freund wrote:
C11 has been out a while, so I'm somewhat inclined to adopt _Noreturn/noreturn
in a conditional way. Older compilers would still work, just not understand
noreturn.
One wrinkle: _Noreturn/noreturn have been deprecated in C23, because that
adopted C++11's a
Hi,
On 2024-12-14 12:08:57 +0700, John Naylor wrote:
> On Thu, Jun 13, 2024 at 2:37 AM Andres Freund wrote:
> >
> > It's hard to understand, but a nonetheless helpful page is
> > https://users.ece.cmu.edu/~koopman/crc/crc32.html which lists properties for
> > crc32c:
> > https://users.ece.cmu.edu
Hi Ashutosh,
On Fri, Dec 6, 2024 at 12:34 AM Ashutosh Bapat
wrote:
>
> Sorry, I forgot to attach patches. PFA the patches.
>
> On Thu, Dec 5, 2024 at 4:38 PM Ashutosh Bapat
> wrote:
> >
> > On Fri, Nov 22, 2024 at 7:29 PM Ashutosh Bapat
> > wrote:
> > >
> > > On Tue, Nov 19, 2024 at 10:08 PM Vi
On Mon, Nov 25, 2024 at 10:23 PM Anton Shmigirilov <
a.shmigiri...@postgrespro.ru> wrote:
>
> > Hi Hackers,
> >
> > I am working on a feature in postgres_fdw extension to show plans used
> by remote postgresql servers in the output of the EXPLAIN command.
> > I think this will help end users under
Hello
The following message introduced by commit 03734a7fed7d appears in two
places:
if (returning->typid != JSONOID && returning->typid != JSONBOID)
ereport(ERROR,
(errcode(ERRCODE_DATATYPE_MISMATCH),
errmsg("cannot use RETURNING type
{
"emoji": "😀",
"version": 1
}
Hi
+Only superusers and users with the appropriate SET
+privilege and change this setting.
a typo? should be "can change"?
I like the separation of vacuum_delay_point and analyze_delay_point, it
improves the readability of the analyze code. Looks good. I would like to
enable tr
On Sat, Dec 14, 2024 at 9:29 PM Alvaro Herrera wrote:
> On 2024-Dec-11, Andres Freund wrote:
> > One thing that I think we should definitely do is to include more detail in
> > the error message. mdzeroextend()'s error messages don't include how many
> > blocks the relation was to be extended by.
On Sat, Dec 14, 2024 at 1:45 PM Thomas Munro wrote:
> On Sat, Dec 14, 2024 at 9:55 AM Andres Freund wrote:
> > But since the above change checkpointer doesn't use
> > EXTENSION_DONT_CHECK_SIZE
> > anymore.
> >
> > Seems we should remove this code?
>
> +1
And done.
On 2024-Dec-11, Andres Freund wrote:
> One thing that I think we should definitely do is to include more detail in
> the error message. mdzeroextend()'s error messages don't include how many
> blocks the relation was to be extended by. Neither mdextend() nor
> mdzeroextend() include the offset at
27 matches
Mail list logo
