On 29.11.24 15:25, Marcos Pegoraro wrote:
Em ter., 19 de nov. de 2024 às 13:27, Peter Eisentraut
mailto:pe...@eisentraut.org>> escreveu:
3. Some documentation updates to explain some of the differences
between
NO ACTION and RESTRICT better.
There is a typo on your commit "doc: Imp
On Fri, Nov 29, 2024 at 12:17 PM Masahiko Sawada wrote:
>
> On Fri, Nov 29, 2024 at 11:47 AM Marcos Pegoraro wrote:
> >
> > Em sex., 29 de nov. de 2024 às 15:49, Masahiko Sawada
> > escreveu:
> >>
> >> uuidv7 () uuid
> >
> >
> > Wouldn't it be better to change this to
> > uuidv7 ([interval])
On Sat, 30 Nov 2024 at 01:57, Kirill Gavrilov wrote:
>
> On Fri, Nov 29, 2024 at 10:12 PM Jim Jones wrote:
>>
>>
>>
>> On 29.11.24 12:05, Kirill Gavrilov wrote:
>> > Setting max_log_size to 0 already disables truncation.
>> > I changed guc units to bytes, just to make it more human-friendly.
On Fri, 11 Oct 2024 at 06:53, Fujii Masao wrote:
> However, this issue already exists without the proposed patch.
> Since file_fdw already reports progress partially, querying multiple
> file_fdw tables can lead to inaccurate or confusing progress reports.
> You can even observe this when analyzin
On Wed, 13 Nov 2024 at 21:21, Alena Rybakina wrote:
>
> Hi! Thank you for your contribution to this thread!
>
> On 13.11.2024 03:24, Jim Nasby wrote:
>
> On Nov 10, 2024, at 2:09 PM, Alena Rybakina wrote:
>
>
> On 08.11.2024 22:34, Jim Nasby wrote:
>
>
> On Nov 2, 2024, at 7:22 AM, Alena Rybakina
On Fri, Nov 29, 2024 at 11:05:51AM +0900, Michael Paquier wrote:
> This is a follow-up of ea792bfd93ab and this thread where I've noticed
> that some memory was still leaking when running sysbench with a
> logical replication setup:
> https://www.postgresql.org/message-id/zz7srcbxxhoyn...@paquier.x
On Fri, Nov 29, 2024 at 05:42:13AM +, Hayato Kuroda (Fujitsu) wrote:
> It was not good to follow existing codes without confirmation :-(.
No problem.
> I grepped files in bin/ and could not find lines which includes
> catalog/pg_xxx.h files.
> (One exception is pg_control.h. It is not a cata
On 2024-11-30, Dean Rasheed wrote:
On Fri, 29 Nov 2024 at 13:10, Dean Rasheed wrote:
>
> There are a couple more things that I think need tidying up. I'll post an
> update when I get back to my computer.
>
Here's an update with some cosmetic tidying up, plus a couple of
not-so-cosmetic changes:
On Fri, Nov 29, 2024 at 11:12 PM Thomas Munro wrote:
> New idea: let's just redefine PRI...{32,64,PTR} on that platform,
> instead of modifying snprintf.c.
D'oh, that's not going to fly. gettext() would replace % with
the system's PRId64, so we can't avoid teaching our snprintf.c to
understand W
I wrote:
> David Rowley writes:
>> nodeAgg.c seems to do this by using prepare_hash_slot() which deforms
>> the heap tuple and sets the Datums verbatim rather than making copies
>> of any byref ones.
> I'll take a look at that, thanks for the pointer.
So after digging into it, I realized that I'
On Wed, Nov 27, 2024 at 03:43:27PM +, Malladi, Rama wrote:
> • Attachments protected by Amazon:
> • 0001-SVE-popcount-support.patch |
> • SVE-popcount-support-PostgreSQL.png |
>
> Amazon has replaced the attachments in this email with download links.
> Downloads will be available until D
On Fri, 29 Nov 2024 at 13:10, Dean Rasheed wrote:
>
> There are a couple more things that I think need tidying up. I'll post an
> update when I get back to my computer.
>
Here's an update with some cosmetic tidying up, plus a couple of
not-so-cosmetic changes:
The new #include wasn't in the rig
On Fri, Nov 29, 2024 at 10:12 PM Jim Jones
wrote:
>
>
> On 29.11.24 12:05, Kirill Gavrilov wrote:
> > Setting max_log_size to 0 already disables truncation.
> > I changed guc units to bytes, just to make it more human-friendly.
> > Did some refactoring and fixed all warnings. Set default valu
On Mon, Nov 25, 2024 at 08:56:50PM -0500, Tom Lane wrote:
> [ getting back to the document-ABI-breakage-rules-better topic ... ]
>
> I wrote:
> > That text says exactly nothing about what specific code changes to
> > make or not make. I'm not sure offhand where (or if) we have this
> > documented
On Fri, Nov 29, 2024 at 11:47 AM Marcos Pegoraro wrote:
>
> Em sex., 29 de nov. de 2024 às 15:49, Masahiko Sawada
> escreveu:
>>
>> uuidv7 () uuid
>
>
> Wouldn't it be better to change this to
> uuidv7 ([interval]) uuid and explain what that param is ?
Yes, the function synopsis in the doc sh
> On 29 Nov 2024, at 19:36, Tom Lane wrote:
>
> David Benjamin writes:
>> Thanks! I got asked about release branches, so I thought I'd pass it along:
>> how do you all handle merges to release branches and would it make sense to
>> merge this change? On the one hand, nothing is actively on fire
Em sex., 29 de nov. de 2024 às 15:49, Masahiko Sawada
escreveu:
> uuidv7 () uuid
>
Wouldn't it be better to change this to
uuidv7 ([interval]) uuid
On Wed, Nov 27, 2024 at 9:01 AM Robert Haas wrote:
>
> On Tue, Nov 26, 2024 at 8:38 PM Masahiko Sawada wrote:
> > > visibility map: 5 pages set all-visible, 4 pages set all-frozen.
> >
> > Which means that 5 pages were marked as only all-visible and 4 pages
> > were marked as all-frozen (and poss
David Rowley writes:
> Here's a quick review of all 5 patches together.
Thanks for looking at it!
> 1. In setop_load_group(), the primary concern with the result of
> setop_compare_slots() seems to be if the tuples match or not. If
> you're not too concerned with keeping the Assert checking for
On Fri, Nov 29, 2024 at 11:12 PM Thomas Munro wrote:
> WIP patch attached.
Slightly better version. I'd missed some configure stuff that could
be removed, and tidied up a few minor typos and mistakes.
I was thinking about that ECPG stuff: I bet real applications prefer
to use int64_t etc direct
On 29.11.24 12:05, Kirill Gavrilov wrote:
> Setting max_log_size to 0 already disables truncation.
> I changed guc units to bytes, just to make it more human-friendly.
> Did some refactoring and fixed all warnings. Set default value in
> postgresql.conf.
Nice. The patch applies cleanly and
On Fri, Nov 29, 2024 at 10:39 AM Andrey M. Borodin wrote:
>
>
>
> > On 29 Nov 2024, at 00:46, Peter Eisentraut wrote:
> >
> > Here as well.
>
> Peter, many thanks for the next round of review. I agree with all corrections.
> I'm sending amendments addressing your review as a separate step in patc
> On 29 Nov 2024, at 00:46, Peter Eisentraut wrote:
>
> Here as well.
Peter, many thanks for the next round of review. I agree with all corrections.
I'm sending amendments addressing your review as a separate step in patch set.
Step 1 of this patch set is identical to v39.
Thanks!
Best reg
David Benjamin writes:
> Thanks! I got asked about release branches, so I thought I'd pass it along:
> how do you all handle merges to release branches and would it make sense to
> merge this change? On the one hand, nothing is actively on fire yet, but
> the current setup does risk breakage if Op
Hi,
On 2024-11-28 17:30:32 +0100, Dmitry Dolgov wrote:
> The assumption about picking up a lowest address is just how it works right
> now
> on Linux, this fact is already used in the patch. The idea that we could put
> upper boundary on the size of other mappings based on total available memory
On 29/11/2024 12:04, postgresql_contributors wrote:
Hi,
I recently installed and tested the CF-5044 patch using the query
provided on the PostgreSQL community page but could not confirm its
functionality. I followed the standard process:
1. Applied the patch using |git|.
2. Rebuilt PostgreS
On Fri, Nov 29, 2024 at 5:59 AM Sergey Prokhorenko
wrote:
>
>
>
> Sergey Prokhorenko sergeyprokhore...@yahoo.com.au
>
>
> On Friday 29 November 2024 at 09:19:33 am GMT+3, Masahiko Sawada
> wrote:
>
>
> On Thu, Nov 28, 2024 at 8:13 PM Sergey Prokhorenko
>
> wrote:
> >
> > I mean to add not bench
Thanks! I got asked about release branches, so I thought I'd pass it along:
how do you all handle merges to release branches and would it make sense to
merge this change? On the one hand, nothing is actively on fire yet, but
the current setup does risk breakage if OpenSSL ever migrates BIO_s_socket
Hi,
On 29/11/24 04:28, Nazir Bilal Yavuz wrote:
-for (; blkno < nblocks; blkno++)
+p.last_exclusive = nblocks;
+
+while (BufferIsValid(buf = read_stream_next_buffer(stream, NULL)))
{
CHECK_FOR_INTERRUPTS();
-pagefn(&stat, rel, blkno,
> On Fri, Nov 29, 2024 at 01:56:30AM GMT, Matthias van de Meent wrote:
>
> I mean, we can do the following to get a nice contiguous empty address
> space no other mmap(NULL)s will get put into:
>
> /* reserve size bytes of memory */
> base = mmap(NULL, size, PROT_NONE, ...flags, ...);
>
> On 29 Nov 2024, at 18:57, Sergey Prokhorenko
> wrote:
>
> Workloads can and must be added with parameters. Typically, companies use
> test tables of 10,000 and 1,000,000 records, etc. Different companies have
> mostly similar usage scenarios (for example, incremental loading). Each
> com
On Fri, 29 Nov 2024 at 20:20, Bertrand Drouvot
wrote:
> On Fri, Nov 29, 2024 at 11:23:12AM +0500, Kirill Reshke wrote:
> > If we don’t have the relation OID when writing buffers out, can we
> > just store oid to buffertag mapping somewhere and use it?
>
> Do you mean add the relation OID into the
Hi,
On 11/29/24 12:04, postgresql_contributors wrote:
> Hi,
> I recently installed and tested the CF-5044 patch using the query
> provided on the PostgreSQL community page but could not confirm its
> functionality. I followed the standard process:
>
> 1. Applied the patch using |git|.
> 2. Reb
Hi,
On Fri, Nov 29, 2024 at 11:23:12AM +0500, Kirill Reshke wrote:
> On Tue, 5 Nov 2024 at 11:06, Bertrand Drouvot
> wrote:
> >
> >
> > Does it sound ok to you to move with the above principal? (I'm +1 on it).
> >
>
> Hi! I looked through this thread.
Thanks for looking at it!
> Looks like we
Em ter., 19 de nov. de 2024 às 13:27, Peter Eisentraut
escreveu:
> 3. Some documentation updates to explain some of the differences between
> NO ACTION and RESTRICT better.
>
There is a typo on your commit "doc: Improve description of referential
actions"
There is also a noticeable difference b
On Fri, 29 Nov 2024 at 18:47, jian he wrote:
>
> new patch, add tab complete for it.
Thank you. You may also be interested in reviewing [0].
[0]
https://www.postgresql.org/message-id/CALdSSPhqfvKbDwqJaY%3DyEePi_aq61GmMpW88i6ZH7CMG_2Z4Cg%40mail.gmail.com
--
Best regards,
Kirill Reshke
Sergey Prokhorenko sergeyprokhore...@yahoo.com.au
On Friday 29 November 2024 at 09:19:33 am GMT+3, Masahiko Sawada
wrote:
On Thu, Nov 28, 2024 at 8:13 PM Sergey Prokhorenko
wrote:
>
> I mean to add not benchmark results to the patch, but functions so that
> everyone can compare the
new patch, add tab complete for it.
From 91d05e547ca722d4537ff7420b8248a3fcce3b58 Mon Sep 17 00:00:00 2001
From: jian he
Date: Fri, 29 Nov 2024 21:44:54 +0800
Subject: [PATCH v5 1/1] support CREATE SCHEMA CREATE DOMAIN
SQL standard allow domain to be specified with CREATE SCHEMA
statement. This p
There are lots of strange things related to this (... rows)
First, (0 rows) are completely useless. If no one record is shown, why do
we need that list ?
We could change (0 rows), like this one on dblink.sgml
SELECT * FROM dblink_get_notify();
notify_name | be_pid | extra
-++-
On Fri, 29 Nov 2024, 12:01 David Rowley, wrote:
> On Fri, 29 Nov 2024 at 18:50, songjinzhou
> wrote:
> > Hello, thank you and David Rowley for your comments.
> >
> > I have used pgindent to adjust the code format and added comments and
> missing regression test cases. Here is the patch of versio
On Fri, 29 Nov 2024 at 15:49, vignesh C wrote:
>
> On Fri, 29 Nov 2024 at 13:38, Shlok Kyal wrote:
> >
> > On Thu, 28 Nov 2024 at 16:38, Amit Kapila wrote:
> > >
> > > On Thu, Nov 21, 2024 at 5:30 PM Shlok Kyal
> > > wrote:
> > > >
> > >
> > > Review comments:
> > > ===
> > > 1.
>
On Thu, Nov 28, 2024 at 5:20 AM Peter Smith wrote:
>
> Hi Nisha. Here are some review comments for patch v51-0002.
>
> ==
> src/backend/replication/slot.c
>
> ReplicationSlotAcquire:
>
> 2.
> GENERAL.
>
> This just is a question/idea. It may not be feasible to change. It
> seems like there is
On Thu, Nov 28, 2024 at 1:29 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Nisha,
>
> >
> > Attached v51 patch-set addressing all comments in [1] and [2].
> >
>
> Thanks for working on the feature! I've stated to review the patch.
> Here are my comments - sorry if there are something which have alrea
On Tue, Nov 19, 2024 at 12:47 PM Nisha Moond wrote:
>
> On Thu, Nov 14, 2024 at 5:29 AM Peter Smith wrote:
> >
> >
> > 12.
> > /*
> > - * If the slot can be acquired, do so and mark it invalidated
> > - * immediately. Otherwise we'll signal the owning process, below, and
> > - * retry.
> > + *
On Thu, Nov 28, 2024 at 2:44 PM vignesh C wrote:
>
> >
> > We are setting inactive_since when the replication slot is released.
> > We are marking the slot as inactive only if it has been released.
> > However, there's a scenario where the network connection between the
> > publisher and subscribe
On Fri, 29 Nov 2024 at 18:50, songjinzhou wrote:
> Hello, thank you and David Rowley for your comments.
>
> I have used pgindent to adjust the code format and added comments and missing
> regression test cases. Here is the patch of version v3.
It looks fine to me. The only things I'd adjust are
Hello, Michael!
> I fail to see how this is related? The original issue was that this
> was impossible to run safely concurrently, but now we have the
> facilities able to do so. There are a few cases where using a wait
> point has limits, for example outside a transaction context for some
> of
Hi,
Thank you for your commit.
Regards,
Ryohei Takahashi
Hi,
Thank you for looking into this.
On Fri, 29 Nov 2024 at 06:55, Kirill Reshke wrote:
> > + old_blk = &(p->block_info[p->pos - 1]);
> > + cur_blk = &(p->block_info[p->pos]);
> Should we Assert(p->pos > 0 && p->pos < *something*)
I think it is worth adding:
+ Assert(p->pos > 0 && p->pos < p-
pá 29. 11. 2024 v 10:42 odesílatel Pavel Stehule
napsal:
> Hi
>
> I tried to add meson support to plpgsql_check. As template I used
> https://raw.githubusercontent.com/petere/plsh/refs/heads/meson/meson.build
>
> Unfortunately, for tests I need to know MAJORVERSION. In makefile I use
>
> ifndef M
On Fri, Nov 29, 2024 at 3:24 AM Jim Jones wrote:
>
>
> On 28.11.24 20:20, Kirill Gavrilov wrote:
> > Here is version 3 of this patch. I found another place where this
> > setting can be applied.
> > Also added some documentation and specified that this setting
> > truncates queries by size in
On Wed, 14 Aug 2024 at 23:08, Сергей Соловьев
wrote:
>
>
>
> 10.08.2024, 16:40, "Kirill Reshke" :
>
> On Thu, 4 Jul 2024 at 21:46, Sergey Solovev
> wrote:
>
>
> Hi.
>
> We encountered a problem with excessive logging when transaction is
> sampled.
> When it is getting sampled every statement
Hi,
I recently installed and tested the CF-5044 patch using the query provided on
the PostgreSQL community page but could not confirm its functionality. I
followed the standard process:
1. Applied the patch using git.
2. Rebuilt PostgreSQL from source (./configure, make, make install).
On Fri, 15 Nov 2024 at 13:37, Yugo NAGATA wrote:
>
> On Sun, 03 Nov 2024 13:42:33 -0500
> Tom Lane wrote:
>
> > Yugo Nagata writes:
> > > While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5,
> > > I noticed that we can create a materialized view using Ephemeral Named
> > > Rel
On Fri, Nov 29, 2024 at 4:05 PM Hayato Kuroda (Fujitsu)
wrote:
>
> 07. wait_for_publisher_status
>
> I think all calculations and checking in the function can be done even on the
> walsender. Based on this, I come up with an idea to reduce the message size:
> walsender can just send a status (bool
Dear Hou,
Thanks for updating the patch! Here are my comments mainly for 0001.
01. protocol.sgml
I think the ordering of attributes in "Primary status update" seems not correct.
The second entry is LSN, not the oldest running xid.
02. maybe_advance_nonremovable_xid
```
+case RCI_REQUES
On Fri, 29 Nov 2024 at 13:38, Shlok Kyal wrote:
>
> On Thu, 28 Nov 2024 at 16:38, Amit Kapila wrote:
> >
> > On Thu, Nov 21, 2024 at 5:30 PM Shlok Kyal wrote:
> > >
> >
> > Review comments:
> > ===
> > 1.
> > +
> > + /*
> > + * true if all generated columns which are part of replica
On 12.11.24 17:10, Peter Eisentraut wrote:
On 11.11.24 06:51, vignesh C wrote:
The patch needs to be rebased due to a recent commit 14e87ffa5c5.
done in v9
I
have verified the behavior of logical replication of row filters on
the virtual generated column, and everything appears to be functio
On Tue, Jul 23, 2024 at 2:39 AM Peter Eisentraut wrote:
> On 14.07.24 16:51, Tom Lane wrote:
> > Peter Eisentraut writes:
> >> On 04.07.24 03:55, Thomas Munro wrote:
> Personally, I find "PRId64" pretty unreadable. "INT64_MODIFIER" wasn't
> nice either, though, and following standards i
On Fri, Nov 29, 2024 at 7:54 AM Zhijie Hou (Fujitsu)
wrote:
>
> It is possible to reach here if user creates a subscription with
> (connect=false,detect_update_deleted=true), in which case we could not check
> it
> during creation. But I agree that it would be better to report an ERROR here,
> so
On Thu, 21 Nov 2024 at 18:00, Nathan Bossart wrote:
>
> In light of CVE-2024-10976, which was fixed by commit cd7ab57, I'd like to
> propose a bigger change to this area of the code that aims to future-proof
> it a bit. Instead of requiring hackers to carefully cart around whether a
> query refer
On 14.11.24 09:48, jian he wrote:
inspired by not-null and check check_modified_virtual_generated again.
in plpgsql_exec_trigger, we can:
/*
* In BEFORE trigger, stored generated columns are not computed yet,
* so make them null in the NEW row. (Only needed in UPDAT
On 13.11.24 04:30, jian he wrote:
in
transformColumnDefinition
we can add parser_errposition for the error report.
if (column->is_not_null && column->generated ==
ATTRIBUTE_GENERATED_VIRTUAL)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
On 12.11.24 17:50, Alvaro Herrera wrote:
On 12.11.24 09:49, jian he wrote:
On Wed, Nov 6, 2024 at 12:17 AM Peter Eisentraut wrote:
check_modified_virtual_generated, we can replace fastgetattr to
heap_attisnull? like:
// boolisnull;
// fastgetattr(tuple, i
On 14.11.24 10:46, Amit Kapila wrote:
Moreover, we would have to implement some elaborate cross-checks if a
table gets added to a publication. How would that work? "Can't add
table x to publication because it contains a virtual generated column
with a non-simple expression"? With row filters,
Hi
I tried to add meson support to plpgsql_check. As template I used
https://raw.githubusercontent.com/petere/plsh/refs/heads/meson/meson.build
Unfortunately, for tests I need to know MAJORVERSION. In makefile I use
ifndef MAJORVERSION
MAJORVERSION := $(basename $(VERSION))
endif
Is there some
Thanks for your valuable input, Michael!
> On 29 Nov 2024, at 09:42, Michael Paquier wrote:
>
> As a whole, I'm very dubious about the need for injection points at
> all here. The sortsupport property claimed for this patch tells that
> this results in smaller index sizes, but the tests don't r
On Fri, 29 Nov 2024 at 20:04, jian he wrote:
> I found that unique expression index can also be used for groupby
> column removal.
> so I implemented it, aslo added two tests on it.
> what do you think?
I think it's likely just not common enough to be worthwhile, plus,
unfortunately, I don't thi
Hi,
Le sam. 19 oct. 2024 à 06:46, Benoit Lobréau a
écrit :
> On 10/15/24 09:52, Benoit Lobréau wrote:
> > Thank you, it's a lot cleaner that way.
> > I'll add this asap.
>
> This is an updated version with the suggested changes.
>
>
AFAICT, Benoit answered to all questions and requests. Is there
Hi,
Please find attached a patch to help tab completion show only currently set
vars
during ALTER USER RESET.
Currently tab completion provides a list of all vars which is only
partially helpful.
This patch allows tab completion to see which vars are currently set for
the role
and only show those
On Mon, Nov 18, 2024 at 10:25 PM Yan Chengpeng
wrote:
>
>
> I encountered an issue with the B-Tree ordering of `jsonb` values. According
> to the PostgreSQL documentation[1], the ordering should follow this
> precedence:
>
> `Object > Array > Boolean > Number > String > Null`
>
>
> However, empt
On Thu, 28 Nov 2024 at 20:22, Malladi, Rama wrote:
>
> Attachments protected by Amazon: 0001-SVE-popcount-support.patch |
SVE-popcount-support-PostgreSQL.png |
> Amazon has replaced the attachments in this email with download links.
Downloads will be available until December 27, 2024, 15:43 (UTC+0
Hi,
On Fri, 29 Nov 2024 at 08:40, Zharkov Roman wrote:
>
> Hello,
>
> On 2024-11-27 21:50, Andrew Dunstan wrote:
> > it should give the same answer
>
> Sometimes "version" and "api_versionstring" are different. Here are two
> simple examples from my windows system and from a linux system of one o
On Thursday, November 28, 2024 8:16 PM Alvaro Herrera
wrote:
>
> Gabriele just reported a crash when changing synchronized_standby_slots
> under SIGHUP and logging collector working. The problem apparently is
> that validate_sync_standby_slots is run for the GUC check routine, and
> it requires
On Thu, 28 Nov 2024 at 16:38, Amit Kapila wrote:
>
> On Thu, Nov 21, 2024 at 5:30 PM Shlok Kyal wrote:
> >
>
> Review comments:
> ===
> 1.
> +
> + /*
> + * true if all generated columns which are part of replica identity are
> + * published or the publication actions do not include UP
75 matches
Mail list logo
