On Fri, Nov 29, 2024 at 12:17 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Fri, Nov 29, 2024 at 11:47 AM Marcos Pegoraro <mar...@f10.com.br> wrote: > > > > Em sex., 29 de nov. de 2024 às 15:49, Masahiko Sawada > > <sawada.m...@gmail.com> escreveu: > >> > >> <function>uuidv7</function> () <returnvalue>uuid</returnvalue> > > > > > > Wouldn't it be better to change this to > > <function>uuidv7</function> ([interval]) <returnvalue>uuid</returnvalue > > and explain what that param is ? > > Yes, the function synopsis in the doc should be either: > > uuidv7([interval]) -> uuid > > or > > uuidv7([shift interval]) -> uuid > > Since this function has only one function argument it doesn't > necessarily need an argument name 'shift'. So the proposed description > might be okay but we need to change at least the function synopsis. >
I realized that the description of uuid_extract_timestamp() needs to be updated as well since it now supports version 7 too: <synopsis> <function>uuid_extract_timestamp</function> (uuid) <returnvalue>timestamp with time zone</returnvalue> </synopsis> This function extracts a <type>timestamp with time zone</type> from UUID version 1. For other versions, this function returns null. Note that the extracted timestamp is not necessarily exactly equal to the time the UUID was generated; this depends on the implementation that generated the UUID. </para> Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com