On Fri, Nov 8, 2024 at 8:36 PM Tom Lane wrote:
> Dilip Kumar writes:
> > IIRC, In catalog we intentionally left it as Oid because RelFileNumber is
> > an internal typedef bug, it is not an exposed datatype, so probably we
> can
> > not use it in catalog.
>
> We could declare it as RelFileNumber
On Fri, Nov 8, 2024, at 22:47, David G. Johnston wrote:
> On Fri, Nov 8, 2024 at 2:20 PM Joel Jacobson wrote:
>>
>> 1. Text files containing \. in the middle of the file
>> % cat /tmp/test.txt
>> foo
>> \.
>> bar
>>
>> Or another option to turn off the special meaning of \.?
>
> This does seem l
> On 2024/11/08 11:47, Tatsuo Ishii wrote:
>> I think you need to adjust
>> fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the current
>> line */
>> to:
>> fprintf(stderr, "%*c\r", chars, ' '); /* Clear the current
>> line */
>> since now chars does not consider th
On 2024/11/08 11:47, Tatsuo Ishii wrote:
I think you need to adjust
fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the
current line */
to:
fprintf(stderr, "%*c\r", chars, ' '); /* Clear the current line
*/
since now chars does not consider the EOL c
Hi,
On Mon, Nov 04, 2024 at 12:53:05PM -0500, Robert Haas wrote:
> Hi,
>
> When I gave my talk on pg_basebackup at pgconf.eu, people took the
> opportunity to mention various improvements which they would find
> useful. One of those improvements was the ability to combine several
> incremental ba
Hi,
On Fri, Nov 08, 2024 at 11:18:09PM +1300, David Rowley wrote:
> I tried with [1] and the
> latest gcc does not seem to be smart enough to figure this out. I
> tried adding some additional len checks that the compiler can use as a
> cue and won't need to emit code for the checks providing the
Hi,
On Sat, Nov 09, 2024 at 08:00:35AM +0900, Michael Paquier wrote:
> On Fri, Nov 08, 2024 at 11:18:09PM +1300, David Rowley wrote:
> > I'm slightly worried due to the current rate we're receiving cleanup
> > suggestions that someone might come along and think they'd be doing us
> > a favour by s
On Fri, Nov 8, 2024 at 5:17 PM Alvaro Herrera wrote:
>
> On 2024-Nov-07, Amit Kapila wrote:
>
> > BTW, I was thinking as to how to fix it on back branches and it seems
> > we should restrict to define REPLICA IDENTITY on stored generated
> > columns in the first place in back branches as those can
On Sun, Nov 03, 2024 at 10:29:25AM -0800, Noah Misch wrote:
> Pushed as 0bada39.
>
> Buildfarm member hornet REL_15_STABLE was in the same hang. Other buildfarm
> runs 2024-10-25T13:51:02Z - 2024-11-02T16:04:56Z may hang the same way. It's
> early to make a comprehensive list of hung buildfarm m
On Thu, Nov 7, 2024 at 4:38 PM Jacob Champion
wrote:
> Oh... I think that alone is enough to change my mind; I neglected the
> effects of that little pgstat_report_appname() stinger...
(Note that application_name is not yet set at the site of the first
call, so I think the set-unset-set can't hap
On Thu, Nov 7, 2024 at 12:34 AM Andrey M. Borodin wrote:
>
>
>
> > On 7 Nov 2024, at 12:42, Masahiko Sawada wrote:
> >
> > On Wed, Nov 6, 2024 at 10:14 AM Andrey M. Borodin
> > wrote:
> >>
> >>
> >>
> >>> On 5 Nov 2024, at 23:56, Andrey M. Borodin wrote:
> >>>
> >>>
> >>
> >> Some more though
On Fri, Nov 08, 2024 at 11:18:09PM +1300, David Rowley wrote:
> I'm slightly worried due to the current rate we're receiving cleanup
> suggestions that someone might come along and think they'd be doing us
> a favour by submitting a patch to "fixup the inefficient bitwise-ORs
> and use boolean-OR".
On Sat, Nov 09, 2024 at 11:26:44AM +1300, Thomas Munro wrote:
> Out of curiosity, is nixos deliberately using an old macOS deployment
> target or SDK, 10.something? I'm just wondering if our feature
> detection is working correctly on macOS/x86, because I'd expect real
> preadv/pwritev to be there
On Sat, Nov 9, 2024 at 8:08 AM Wolfgang Walther wrote:
> When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we
> encounter the following build failure in nixpkgs:
Out of curiosity, is nixos deliberately using an old macOS deployment
target or SDK, 10.something? I'm just wonderin
On Fri, Nov 08, 2024 at 04:42:14PM -0500, Tom Lane wrote:
> I've finished the first draft of 17.1 release notes; see
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=4145ea0910d7bdbf131aa6514ffce8eb92230a5f
>
> Please send comments/corrections by Sunday.
I've just committed
On Fri, Nov 08, 2024 at 03:20:00PM -0600, Nathan Bossart wrote:
> Here is a new version of the patch with an updated commit message. The
> cfbot results [0] look good, so I plan to commit this one shortly unless
> someone objects.
Committed.
--
nathan
On Fri, Nov 8, 2024 at 1:25 PM Sergey Prokhorenko
wrote:
>
> On Thursday 7 November 2024 at 11:34:31 am GMT+3, Andrey M. Borodin
> wrote:
>
>
> > 12 bits does not differ much. We can have much longer counters. Before
> > switching to Method 3 I used 18 bits counter. See version
> > v24-0001-Im
On Fri, Nov 8, 2024 at 2:20 PM Joel Jacobson wrote:
>
> 1. Text files containing \. in the middle of the file
> % cat /tmp/test.txt
> foo
> \.
> bar
>
> Or another option to turn off the special meaning of \.?
>
This does seem like an orthogonal option worth considering.
> > Besides, "single"
I've finished the first draft of 17.1 release notes; see
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=4145ea0910d7bdbf131aa6514ffce8eb92230a5f
Please send comments/corrections by Sunday.
regards, tom lane
On Thursday 7 November 2024 at 11:34:31 am GMT+3, Andrey M. Borodin
wrote:
> 12 bits does not differ much. We can have much longer counters. Before
> switching to Method 3 I used 18 bits counter. See version
> v24-0001-Implement-UUID-v7.patch> This version is more resilent to generating
> a l
On Fri, Nov 8, 2024, at 20:44, Daniel Verite wrote:
> Aleksander Alekseev wrote:
>
>> IMO it should be 'text' we already have with special options e.g.
>> DELIMITER AS NULL ESCAPE AS NULL. If there are no escape characters
>> and column delimiters (and no NULLs designations, and what else I
>> forg
Here is a new version of the patch with an updated commit message. The
cfbot results [0] look good, so I plan to commit this one shortly unless
someone objects.
[0] https://cirrus-ci.com/build/6599760059039744
--
nathan
>From 5e7156defd3a169323e2bc354c3a3c4cb232fa67 Mon Sep 17 00:00:00 2001
Fro
On Fri, Nov 08, 2024 at 08:08:06PM +0100, Wolfgang Walther wrote:
> @@ -68,7 +68,7 @@ pg_preadv(int fd, const struct iovec *iov, int iovcnt,
> off_t offset)
> }
> sum += part;
> offset += part;
> - if (part < iov[i].iov_len)
> + if
Aleksander Alekseev wrote:
> IMO it should be 'text' we already have with special options e.g.
> DELIMITER AS NULL ESCAPE AS NULL. If there are no escape characters
> and column delimiters (and no NULLs designations, and what else I
> forgot) then your text file just contains one tuple per
On Thu, Nov 7, 2024, at 17:15, Joel Jacobson wrote:
> Attachments:
> * v18-0001-Introduce-CopyFormat-and-replace-csv_mode-and-binary.patch
> * v18-0002-Add-COPY-format-single.patch
> * v18-0003-Reorganize-option-validations.patch
I want to bring up a potential problem with v18, which has been disc
> On Nov 2, 2024, at 7:22 AM, Alena Rybakina wrote:
>
>>> The second is the interrupts field. It is needed for monitoring to know
>>> do we have them or not, so tracking them on the database level will do
>>> the trick. Interrupt is quite rare event, so once the monitoring system
>>> will catch
Hi! Thank you for review!
On 07.11.2024 17:49, Ilia Evdokimov wrote:
Thank you for fixing it.
1) I have found some typos in the test output files (out-files) when
running 'make check' and 'make check-world'. These typos might cause
minor discrepancies in test results. You may already be awar
When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we
encounter the following build failure in nixpkgs:
/nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:71:12:
error: comparison of integers of different signs: 'ssize_t' (aka 'long'
V3: With the suggested changes.
Raghuveer
> -Original Message-
> From: Devulapalli, Raghuveer
> Sent: Friday, November 8, 2024 10:43 AM
> To: Nathan Bossart
> Cc: pgsql-hackers@lists.postgresql.org; Shankaran, Akash
>
> Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
> I believe we expect MSVC builds to use meson at this point, which is probably
> why there's this extra check:
>
> if cc.get_id() == 'msvc'
> cdata.set('USE_SSE42_CRC32C', false)
> cdata.set('USE_SSE42_CRC32C_WITH_RUNTIME_CHECK', 1)
> have_optimized_crc = true
>
Ah, I missed this.
Hi ,
When a user tries to enter a large query, thinking the server is still running,
and to their surprise, they discover that the server has crashed or stopped, I
have observed that the psql process will still be running if it is idle even
after the server crashes or stops.
solved this
On Fri, Nov 8, 2024 at 8:25 AM Masahiro Ikeda wrote:
> Thank you! I've confirmed that the v2 patch fixed the bug. As you
> mentioned, I also feel that the v2 patch is now easier to understand.
Great. I pushed something quite similar to v2 just now. Thanks!
> Since I couldn't understand the reaso
Hi,
Thank you for investigating this issue.
On Thu, Nov 7, 2024 at 10:40 AM Tomas Vondra wrote:
>
> Hi,
>
> I kept investigating this, but I haven't made much progress. I still
> don't understand why would it be OK to move any of the LSN fields
> backwards - certainly for fields like confirm_flu
On Fri, Nov 08, 2024 at 05:52:23PM +, Devulapalli, Raghuveer wrote:
>> So, for meson builds, we do test with and without
>> __attribute___((target(..."))),
>> but for autoconf builds, we check for __SSE4_2__ to determine whether we need
>> a runtime check. This difference isn't the fault of y
> -prog = '''
> +sse42_crc_prog = '''
>
> nitpick: Why does this need to be renamed?
Doesn't need to be renamed, but just a better name to describe that the code is
meant for. It will be followed up with avx512_crc_prog in the next patch.
>
> +#ifdef TEST_SSE42_WITH_ATTRIBUTE
> +#if d
On Wed, Nov 06, 2024 at 08:51:07PM +0800, wenhui qiu wrote:
>> Thank you. FWIW, I would prefer a sub-linear growth, so maybe something
>> like this
>
>> vacthresh = Min(vac_base_thresh + vac_scale_factor * reltuples,
>> vac_base_thresh + vac_scale_factor * pow(reltuples, 0.7) * 100);
>
>> T
Hi,
On Fri, Nov 08, 2024 at 11:18:09PM +1300, David Rowley wrote:
> On Fri, 8 Nov 2024 at 18:34, Michael Paquier wrote:
> > I've done a round of comment and term cleanup for the whole patch,
> > while on it.
>
> I don't think "intrinsics" is the correct word to use here:
>
> + * - 8 * sizeof(si
-prog = '''
+sse42_crc_prog = '''
nitpick: Why does this need to be renamed?
+#ifdef TEST_SSE42_WITH_ATTRIBUTE
+#if defined(__has_attribute) && __has_attribute (target)
+__attribute__((target("sse4.2")))
+#endif
+#endif
So, for meson builds, we do test with and without
__attribute___((ta
> On Wed, Nov 06, 2024 at 07:10:06PM GMT, Vladlen Popolitov wrote:
> Hi
>
> I tried to apply patches, but failed. I suppose the problem with CRLF in the
> end of lines in the patch files. At least, after manual change of v1-0001 and
> v1-0002 from CRLF to LF patches applied, but it was not helped
> On Thu, Nov 07, 2024 at 02:05:52PM GMT, Thomas Munro wrote:
> On Sat, Oct 19, 2024 at 8:21 AM Dmitry Dolgov <9erthali...@gmail.com> wrote:
> > Currently it
> > supports only an increase of shared_buffers.
>
> Just BTW in case it is interesting, Palak and I experimented with how
> to shrink the bu
Alvaro Herrera writes:
> But we'll see what else the buildfarm has to say now that I pushed it ...
A lot of the buildfarm is saying
adder | 2024-11-08 13:04:39 |
../pgsql/src/backend/catalog/pg_constraint.c:708:37: warning: comparison is
always true due to limited range of data type [
Alvaro Herrera writes:
>> Perhaps one more task for me is to figure out a way to get a list of all
>> the constraints that are broken because of this ... let me see if I can
>> figure that out.
> It's gotta be something like this,
> SELECT conrelid::regclass AS "constrained table",
>conn
Dilip Kumar writes:
> IIRC, In catalog we intentionally left it as Oid because RelFileNumber is
> an internal typedef bug, it is not an exposed datatype, so probably we can
> not use it in catalog.
We could declare it as RelFileNumber so that that is what C code sees,
and teach Catalog.pm to tran
=?UTF-8?Q?Przemys=C5=82aw_Sztoch?= writes:
> Am I right, If we leave (or convert) TYPE linked to VIEW, then DROP will be
> possible?
No ...
CREATE VIEW level1 AS SELECT * FROM base_table;
CREATE VIEW level2 AS SELECT * FROM level1;
You can't drop level1 without dropping level2; the composite t
On Wed, Nov 6, 2024 at 8:54 PM Tomas Vondra wrote:
>
> Hi,
>
> I've been investigating some issues reported by users, related to
> logical replication unexpectedly breaking with messages like:
>
> LOG: invalidating slot "s" because its restart_lsn X/Y exceeds
>max_slot_wal_keep_size
>
>
On Fri, Nov 8, 2024 at 7:51 AM Przemysław Sztoch
wrote:
> Is it possible to extend DROP VIEW command:
>
> DROP VIEW [ IF EXISTS ] *name* [, ...] [ CASCADE | RESTRICT | WITHOUT TYPE]
>
> I want to allow to DROP VIEW if any objects depend on it.
>
> Am I right, If we leave (or convert) TYPE linked
On 10/31/24 19:05, Andrey M. Borodin wrote:
>
>
>> On 8 Oct 2024, at 17:05, Tomas Vondra wrote:
>>
>> Here's an updated patch adding the queryid.
>
> I've took another round of looking through the patch.
> Everything I see seems correct to me. It just occurred to me that we
> will have: buffere
Hi,
On 2024-11-08 09:08:55 +, Zhijie Hou (Fujitsu) wrote:
> On Friday, November 8, 2024 2:20 AM Andres Freund wrote:
> > On 2024-11-05 08:58:36 -0500, Jan Wieck wrote:
> > > The attached solution is minimally invasive because it doesn't move
> > > the timestamp generation (clock_gettime() cal
Is it possible to extend DROP VIEW command:
DROP VIEW [ IF EXISTS ]/|name|/ [, ...] [ CASCADE | RESTRICT | WITHOUT TYPE]
I want to allow to DROP VIEW if any objects depend on it.
Am I right, If we leave (or convert) TYPE linked to VIEW, then DROP will be
possible?
--
Przemysław Sztoch | Mobil
On 11/8/24 05:08, Michael Paquier wrote:
On Thu, Nov 07, 2024 at 02:36:58PM +0900, Michael Paquier wrote:
Incorrect comment format, about which pgindent does not complain..
.. But pgindent complains in execMain.c and pgstat_database.c. These
are only nits, the patch is fine. If anybody has o
Hi,
On Thu, Nov 07, 2024 at 04:32:44PM +, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Nov 07, 2024 at 09:50:59AM +0900, Michael Paquier wrote:
> > On Wed, Nov 06, 2024 at 01:51:02PM +, Bertrand Drouvot wrote:
> > > That's not needed, the patch I'm working on stores the proc number in the
>
On Thu, Nov 7, 2024 at 4:38 PM Tom Lane wrote:
> > What I'm unhappy about is not being able to tell the difference
> > between a name that was invented by or at least meaningful to the user
> > and one that isn't.
>
> You can already tell that, by looking to see whether
> RTE->alias->aliasname exi
On 2024-11-08 07:42, Peter Geoghegan wrote:
Attached revision v2 pushes the fix further in this direction. It
explicitly documents that parallel _bt_readnextpage callers are
allowed to use their so->currPos state (including
blkno/nextPage/prevPage) to help _bt_readnextpage to decide whether it
ca
On 2024-Nov-08, jian he wrote:
> > Here's v11, which I intended to commit today, but didn't get around to.
> > CI is happy with it, so I'll probably do it tomorrow first thing.
> >
> v11 still has column_constraint versus table_constraint inconsistency.
>
> create table t7 (a int generated by def
On Fri, Nov 8, 2024, at 12:25, Aleksander Alekseev wrote:
> Sorry for being late for the discussion.
No worries, better late than never, thanks for chiming in.
> I disagree with the idea of adding a new format name for this. Mostly
> because it is *not* a new format and pretending that it is will
On Fri, 8 Nov 2024 at 17:11, Alvaro Herrera wrote:
>
> We recently had a customer report a very strange problem, involving a
> very large insert-only table: without explanation, insertions would
> stall for several seconds, causing application timeout and process
> accumulation and other nastiness
On 2024-Nov-07, Amit Kapila wrote:
> BTW, I was thinking as to how to fix it on back branches and it seems
> we should restrict to define REPLICA IDENTITY on stored generated
> columns in the first place in back branches as those can't be
> replicated. So, the following should fail:
>
> CREATE TA
On Fri, Nov 8, 2024 at 4:30 PM Alvaro Herrera
wrote:
> On 2024-Nov-08, Dilip Kumar wrote:
>
> > It appears that we are passing InvalidOid instead of InvalidRelFileNumber
> > when calling index_create(). While this isn’t technically a bug, since
> > InvalidRelFileNumber is defined as InvalidOid, i
Hi Joel,
> Recap: This is about adding support to import/export text-based formats such
> as
> JSONL, or any unstructured text file, where wanting to import each line "as
> is"
> into a single column, or wanting to export a single column to a text file.
Sorry for being late for the discussion.
Hi,
> > Recap: This is about adding support to import/export text-based formats
> > such as
> > JSONL, or any unstructured text file, where wanting to import each line "as
> > is"
> > into a single column, or wanting to export a single column to a text file.
>
> Sorry for being late for the disc
Hi Amit,
On Thu, 7 Nov 2024 at 11:37, Amit Kapila wrote:
>
> On Tue, Nov 5, 2024 at 12:53 PM Shlok Kyal wrote:
> >
> > To avoid the issue, we can disallow UPDATE/DELETE on table with
> > unpublished generated column as REPLICA IDENTITY. I have attached a
> > patch for the same.
> >
>
> +CREATE P
On 2024-Nov-08, Dilip Kumar wrote:
> It appears that we are passing InvalidOid instead of InvalidRelFileNumber
> when calling index_create(). While this isn’t technically a bug, since
> InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the
> correct identifier for clarity and c
On Fri, Nov 8, 2024 at 3:17 PM Dilip Kumar wrote:
>
> It appears that we are passing InvalidOid instead of InvalidRelFileNumber
> when calling index_create(). While this isn’t technically a bug, since
> InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the
> correct identifi
On Fri, 8 Nov 2024 at 18:34, Michael Paquier wrote:
> I've done a round of comment and term cleanup for the whole patch,
> while on it.
I don't think "intrinsics" is the correct word to use here:
+ * - 8 * sizeof(size_t) comparisons using bitwise OR, to encourage compilers
+ * to use SIMD intr
On Thu, Nov 7, 2024 at 9:39 PM Jan Wieck wrote:
>
> On 11/6/24 21:30, Zhijie Hou (Fujitsu) wrote:
> >
> > Thanks for the patch! I am reading the patch and noticed few minor things.
> >
> > 1.
> > + /*
> > + * This is a local transaction. Make sure that the xact_time
> > + * higher th
Hi Karina Liskevich
> + /*
> + * There is no need to hold entry->mutex when reading
stats_since and
> + * minmax_stats_since for (unlike counters) they are always
written
> + * while holding pgss->lock exclusively. We are holding
pgss->lock
> +
It appears that we are passing InvalidOid instead of InvalidRelFileNumber
when calling index_create(). While this isn’t technically a bug, since
InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the
correct identifier for clarity and consistency.
--
Regards,
Dilip Kumar
Enterp
> Here's v11, which I intended to commit today, but didn't get around to.
> CI is happy with it, so I'll probably do it tomorrow first thing.
>
v11 still has column_constraint versus table_constraint inconsistency.
create table t7 (a int generated by default as identity, constraint
foo not null a
Hi,
On Wed, Nov 6, 2024 at 12:19 PM jian he wrote:
> looks good to me.
> I didn't find any issue.
Thanks for the review.
> group_by_has_partkey can even cope with:
> EXPLAIN (COSTS OFF, settings)
> SELECT c collate "C" collate case_insensitive collate "C", count(c)
> FROM pagg_tab3 GROUP BY c c
On 2024-Nov-08, jian he wrote:
> > Here's v11, which I intended to commit today, but didn't get around to.
> > CI is happy with it, so I'll probably do it tomorrow first thing.
> >
>
> CREATE TABLE notnull_tbl2 (a INTEGER CONSTRAINT blah NOT NULL, b
> INTEGER CONSTRAINT blah NOT NULL);
>
> Relat
On 06.11.24 00:33, Jacob Champion wrote:
Done in v36, attached.
Assorted review comments from me:
Everything in the commit message between
= Debug Mode =
and
Several TODOs:
should be moved to the documentation. In some cases, it already is,
but it doesn't always have the same leve
On Friday, November 8, 2024 2:20 AM Andres Freund wrote:
Hi,
> On 2024-11-05 08:58:36 -0500, Jan Wieck wrote:
> > The attached solution is minimally invasive because it doesn't move
> > the timestamp generation (clock_gettime() call) into the critical
> > section of
> > ReserveXLogInsertLocation
> On Thu, Sep 26, 2024 at 08:46:17AM GMT, Dmitry Dolgov wrote:
> > On Thu, Sep 26, 2024 at 07:57:12AM GMT, Gabriele Bartolini wrote:
> > Hi Dmitry,
> >
> > I've been attempting to replicate this issue directly in Kubernetes, but I
> > haven't been successful so far. I've been using EKS nodes, and i
I did a quick testing.
As expected, both "ALTER TYPE xxx RENAME VALUE yyy TO zzz CASCADE" and
"ALTER TYPE xxx RENAME VALUE yyy TO zzz RESTRICT" in v4-0002 cause
syntax errors.
In v4-0004 you might also want to complete
"CREATE MATERIALIZED VIEW... USING ..." with "AS".
Other completions work fin
On Fri, Nov 8, 2024, at 08:42, Joel Jacobson wrote:
>> I’d be concerned choosing “single” given this future possibility. I do
>> agree that such an enhancement would be best done in its own patch.
>
> OK, sounds good to do it in its own patch.
>
> If the name "single" doesn't work for this reason
75 matches
Mail list logo
