On Fri, Nov 8, 2024 at 3:17 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > It appears that we are passing InvalidOid instead of InvalidRelFileNumber > when calling index_create(). While this isn’t technically a bug, since > InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the > correct identifier for clarity and consistency. >
Agreed. We already use InvalidRelFileNumber at one of the other callers in index_concurrently_create_copy(). Your patch looks good to me. -- With Regards, Amit Kapila.
