On Wed, Sep 27, 2023 at 6:58 AM Peter Smith wrote:
>
> On Tue, Sep 26, 2023 at 11:57 PM vignesh C wrote:
> >
> > On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
> > >
> > > Here are some comments for patch v2-0001.
> > >
> > > ==
> > > src/backend/replication/logical/worker.c
> > >
> > > 1
Hi Kuroda-san.
Here are my review comments for your v3 patch.
TBH, I felt the new text descriptions deviated a bit too much from the
originals. IMO only quite a small tweak was needed, so my suggested
text in the comments below reflects that.
==
Commit message.
1.
missing description
=
Hi -hackers,
We've got customer report that high max_connections (3k) with high
pgstat_track_activity_query_size (1MB) ends up with:
postgres=# select * from pg_stat_get_activity(NULL);
ERROR: invalid memory alloc request size 18446744072590721024
postgres=# select version();
On Wed, 27 Sep 2023 at 13:46, Michael Paquier wrote:
> On Wed, Sep 27, 2023 at 09:15:00AM +0800, Japin Li wrote:
>> On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
>>> I am not sure that many people run this script frequently so that may
>>> not be worth adding a check for a defined, still
On Wed, 27 Sept 2023 at 06:58, Peter Smith wrote:
>
> On Tue, Sep 26, 2023 at 11:57 PM vignesh C wrote:
> >
> > On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
> > >
> > > Here are some comments for patch v2-0001.
> > >
> > > ==
> > > src/backend/replication/logical/worker.c
> > >
> > > 1.
On Wed, Sep 27, 2023 at 04:51:29AM +, Zhijie Hou (Fujitsu) wrote:
> While searching the code, I noticed one postgres fork where the PGoutputData
> is
> used in other places, although it's a separate fork, but it seems better to
> discuss the removal separately.
>
> [1]
> https://github.com/T
On Wed, Sep 27, 2023 at 09:15:00AM +0800, Japin Li wrote:
> On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
>> I am not sure that many people run this script frequently so that may
>> not be worth adding a check for a defined, still empty or incorrect
>
> Yeah, not frequently, however, it al
On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
>
> Here are some comments for patch v2-0001.
> ==
> src/test/subscription/t/027_nosuperuser.pl
>
> 3.
> # The apply worker should get restarted after the superuser prvileges are
> # revoked for subscription owner alice.
>
> typo
>
> /prvileges
On Fri, Sep 22, 2023 at 4:44 PM Alvaro Herrera
wrote:
> On 2023-Sep-21, Tom Lane wrote:
>
> > Bruce Momjian writes:
>
> > > Wow, I never added code to pg_upgrade to check for that, and no one
> > > complained either.
> >
> > Yeah, so most people had indeed listened to warnings and moved away
> >
On Wed, Sep 27, 2023 at 10:26 AM Michael Paquier wrote:
>
> On Wed, Sep 27, 2023 at 10:15:24AM +0530, Amit Kapila wrote:
> > It's like that from the beginning. Now, even if we want to move, your
> > suggestion is not directly related to this patch as we are just
> > changing one field, and that to
On Wed, Sep 27, 2023 at 10:15:24AM +0530, Amit Kapila wrote:
> It's like that from the beginning. Now, even if we want to move, your
> suggestion is not directly related to this patch as we are just
> changing one field, and that too to fix a bug. We should start a
> separate thread to gather a bro
On Wednesday, September 27, 2023 12:45 PM Amit Kapila
>
> On Wed, Sep 27, 2023 at 9:46 AM Michael Paquier
> wrote:
> >
> > On Wed, Sep 27, 2023 at 09:39:19AM +0530, Amit Kapila wrote:
> > > On Wed, Sep 27, 2023 at 9:10 AM Michael Paquier
> wrote:
> > >> Err, actually, I am going to disagree her
On Wed, Sep 27, 2023 at 9:46 AM Michael Paquier wrote:
>
> On Wed, Sep 27, 2023 at 09:39:19AM +0530, Amit Kapila wrote:
> > On Wed, Sep 27, 2023 at 9:10 AM Michael Paquier wrote:
> >> Err, actually, I am going to disagree here for the patch of HEAD. It
> >> seems to me that there is zero need fo
Here are some more review comments for the patch v19-0002.
This is a WIP these review comments are all for the file slotsync.c
==
src/backend/replication/logical/slotsync.c
1. wait_for_primary_slot_catchup
+ WalRcvExecResult *res;
+ TupleTableSlot *slot;
+ Oid slotRow[1] = {LSNOID};
+ S
Dear Bharath,
Thank you for reviewing!
> Thanks for the new patch. Here's a comment on v46:
>
> 1.
> +Datum
> +binary_upgrade_validate_wal_logical_end(PG_FUNCTION_ARGS
> +{ oid => '8046', descr => 'for use by pg_upgrade',
> + proname => 'binary_upgrade_validate_wal_logical_end', proisstrict =>
On Wed, Sep 27, 2023 at 09:39:19AM +0530, Amit Kapila wrote:
> On Wed, Sep 27, 2023 at 9:10 AM Michael Paquier wrote:
>> Err, actually, I am going to disagree here for the patch of HEAD. It
>> seems to me that there is zero need for pgoutput.h and we don't need
>> to show PGOutputData to the worl
On Wed, Sep 27, 2023 at 9:10 AM Michael Paquier wrote:
>
> On Tue, Sep 26, 2023 at 01:55:10PM +, Zhijie Hou (Fujitsu) wrote:
> > On Tuesday, September 26, 2023 4:40 PM Amit Kapila
> > wrote:
> >> Do we really need a new parameter in above structure? Can't we just use the
> >> existing origin
On Tue, Sep 26, 2023 at 09:40:48AM +0530, Amit Kapila wrote:
> On Mon, Sep 25, 2023 at 11:43 AM Michael Paquier wrote:
>> Sure, that's assuming that the publisher side is upgraded.
>
> At some point, user needs to upgrade publisher and subscriber could
> itself have some publications defined whic
On Tue, Sep 26, 2023 at 01:55:10PM +, Zhijie Hou (Fujitsu) wrote:
> On Tuesday, September 26, 2023 4:40 PM Amit Kapila
> wrote:
>> Do we really need a new parameter in above structure? Can't we just use the
>> existing origin in the same structure? Please remember if this needs to be
>> backp
> 2023年9月27日 00:45，Matthias van de Meent 写道：
>
> On Tue, 26 Sept 2023 at 18:38, jacktby jacktby wrote:
>>
>> typedef bool (*aminsert_function) (Relation indexRelation,
>> Datum *values,
>> bool *isnull,
>> ItemPointer heap_tid,
>> Relation heapRelation,
>> IndexUniqueCheck checkUnique,
On Tue, Sep 26, 2023 at 11:57 PM vignesh C wrote:
>
> On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
> >
> > Here are some comments for patch v2-0001.
> >
> > ==
> > src/backend/replication/logical/worker.c
> >
> > 1. maybe_reread_subscription
> >
> > ereport(LOG,
> > (errmsg("logi
On Wed, Sep 27, 2023 at 11:06:37AM +1300, Thomas Munro wrote:
> On Tue, Sep 26, 2023 at 8:38 PM Michael Paquier wrote:
> > Thoughts and/or comments are welcome.
>
> I don't have an opinion yet on your other thread about making this
> stuff configurable for replicas, but for the simple crash recov
On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
> On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote:
>> # Allow running this even without --with-python
>> PYTHON ?= python
>>
>> $(srcdir)/unaccent.rules: generate_unaccent_rules.py
>> ../../src/common/unicode/UnicodeData.txt Latin-A
I wrote:
> Since updating to Xcode 15.0, my macOS machines have been
> spitting a bunch of linker-generated warnings. There
> seems to be one instance of
> ld: warning: -multiply_defined is obsolete
> for each loadable module we link ...
I poked into this a little more. We started using "-multip
On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote:
> # Allow running this even without --with-python
> PYTHON ?= python
>
> $(srcdir)/unaccent.rules: generate_unaccent_rules.py
> ../../src/common/unicode/UnicodeData.txt Latin-ASCII.xml
> $(PYTHON) $< --unicode-data-file $(word 2,$^
On Mon, Sep 25, 2023 at 07:40:00PM +0200, Matthias van de Meent wrote:
> On Wed, 20 Sept 2023 at 07:06, Michael Paquier wrote:
>> #define COPY_HEADER_FIELD(_dst, _size)\
>> do {\
>> -if (remaining < _size)\
>> +
On Wed, Sep 27, 2023 at 02:05:44AM +1300, David Rowley wrote:
> On Tue, 12 Sept 2023 at 03:03, Bruce Momjian wrote:
> >
> > On Mon, Sep 11, 2023 at 10:02:55PM +1200, David Rowley wrote:
> > > It's certainly not a show-stopper. I do believe the patch makes some
> > > improvements. The reason I'd p
On Mon, 2023-09-25 at 00:31 -0700, Gurjeet Singh wrote:
> Please see attached v4 of the patch. The patch takes care of rebase
> to
> the master/17-devel branch, and includes some changes, too.
FWIW I got some failures applying. I didn't investigate much, and
instead I looked at your git branch (7
On Tue, Sep 26, 2023 at 06:44:50PM +0300, Aleksander Alekseev wrote:
>> And also, I'm afraid that I'm not sure what kind of tests I have to make
>> for fix this behavior. Would you mind giving me some advice?
>
> Personally I would prefer not to increase the scope of work. Your TAP
> test added in
On Wed, Sep 27, 2023 at 11:06:37AM +1300, Thomas Munro wrote:
> I don't have an opinion yet on your other thread about making this
> stuff configurable for replicas, but for the simple crash recovery
> case shown here, hard failure makes sense to me.
Also, if we conclude that we're OK with just fa
On Wed, 2023-09-27 at 00:14 +0300, Heikki Linnakangas wrote:
> Looks correct. You now loop through all the block IDs three times,
> however. I wonder if that is measurably slower, but even if it's not,
> was there a reason you wanted to move the XLogRegisterBuffer() calls
> to
> a separate loop?
On Tue, Sep 12, 2023 at 05:25:44PM -0700, Gurjeet Singh wrote:
> On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian wrote:
> >
> > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> > > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > > > On Thu, Sep 7, 2023 at 02:54:13
On Thu, Sep 7, 2023 at 01:52:45PM -0400, Bruce Momjian wrote:
> On Mon, Jul 10, 2023 at 02:37:24PM -0700, Nikolay Samokhvalov wrote:
> > Maybe. It will require changes in other parts of this doc.
> > Thinking (here:
> > https://gitlab.com/postgres/postgres/-/merge_requests/18/diffs)
> >
> > Mean
Since updating to Xcode 15.0, my macOS machines have been
spitting a bunch of linker-generated warnings. There
seems to be one instance of
ld: warning: -multiply_defined is obsolete
for each loadable module we link, and some program links complain
ld: warning: ignoring duplicate libraries: '-lp
On Tue, Sep 26, 2023 at 8:38 PM Michael Paquier wrote:
> Thoughts and/or comments are welcome.
I don't have an opinion yet on your other thread about making this
stuff configurable for replicas, but for the simple crash recovery
case shown here, hard failure makes sense to me.
Here are some inte
Tomas Vondra writes:
> Hmmm, I got to install BETA2 yesterday, but I still se the tcl failure:
Huh. I'm baffled as to what's up there. Is it possible that this is
actually a hardware-based difference? I didn't think there was much
difference between Pi 3B and Pi 4, but we're running out of oth
Sep 26, 2023 1:10:55 PM Tom Lane :
> "Karl O. Pinc" writes:
>> For the last hunk you'd change around "anything". Write:
>> "... it will be truncated to less than NAMEDATALEN characters and
>> the bytes of the string which are not printable ASCII characters ...".
>
>> Notice that I have also chan
On Thu, Sep 7, 2023 at 12:58:29PM -0400, Bruce Momjian wrote:
> You are right something is wrong. However, I looked at your patch and I
> am thinking we need to go the other way and add "For" in the upper
> block, rather than removing it in the lower one. I have two reasons.
> Looking at the co
On 22.09.23 22:01, Tristen Raab wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hello,
I've reviewed all 4 of y
On 26/09/2023 22:32, Jeff Davis wrote:
On Mon, 2023-09-25 at 13:04 +0300, Heikki Linnakangas wrote:
Yes, that's a problem.
Patch attached. I rearranged the code a bit to follow the expected
pattern of: write, mark dirty, WAL, set LSN. I think computing the
deltas could also be moved earlier, o
On Thu, Sep 7, 2023 at 10:44:25AM +0200, Daniel Gustafsson wrote:
> > On 6 Sep 2023, at 21:13, Bruce Momjian wrote:
> > On Wed, Jul 26, 2023 at 05:14:08PM -0400, Tom Lane wrote:
>
> >> I think we should reword this to just generically claim that holding
> >> the Relation reference open for the w
On 9/26/23 06:34, Peter Eisentraut wrote:
On 09.09.23 21:03, David Steele wrote:
On 9/1/23 11:39, David Steele wrote:
Hackers,
I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c an
On Mon, 2023-09-25 at 13:04 +0300, Heikki Linnakangas wrote:
> Yes, that's a problem.
Patch attached. I rearranged the code a bit to follow the expected
pattern of: write, mark dirty, WAL, set LSN. I think computing the
deltas could also be moved earlier, outside of the critical section,
but I'm n
Hi!
On 26.09.23 15:19, Peter Eisentraut wrote:
On 04.09.23 11:54, Jim Jones wrote:
This patch proposes the column "comment" to the pg_hba_file_rules
view. It basically parses the inline comment (if any) of a valid
pg_hba.conf entry and displays it in the new column.
For such pg_hba entries .
"Karl O. Pinc" writes:
> For the last hunk you'd change around "anything". Write:
> "... it will be truncated to less than NAMEDATALEN characters and
> the bytes of the string which are not printable ASCII characters ...".
> Notice that I have also changed "that" to "which" just above.
> I _th
On Tue, Sep 26, 2023 at 1:00 PM Jeff Davis wrote:
> As I said earlier, I think the best thing to do is to just have a
> section that describes when to use password_required, what specific
> things you should do to satisfy that case, and what caveats you should
> avoid. Something like:
>
> "If yo
On Tue, Sep 26, 2023 at 11:11 AM Andres Freund wrote:
> That I'd like you to expand on "using the RedoRecPtr of the latest checkpoint
> rather than the LSN of the previou vacuum." - I can think of ways of doing so
> that could end up with quite different behaviour...
Yeah, me too. I'm not sure wh
On Tue, 26 Sep 2023 13:40:26 +
"Hayato Kuroda (Fujitsu)" wrote:
> Your effort is quite helpful for me.
You're welcome.
> Before replying your comments, I thought I should show the difference
> between versions. Regarding old versions (here PG15 was used),
> non-ASCIIs (like Japanese) are re
Em ter., 26 de set. de 2023 às 09:30, Ranier Vilela
escreveu:
> Em ter., 26 de set. de 2023 às 07:34, Ashutosh Bapat <
> ashutosh.bapat@gmail.com> escreveu:
>
>> On Tue, Sep 26, 2023 at 3:32 PM David Rowley
>> wrote:
>> >
>> > find_base_rel() could be made more robust for free by just castin
On Tue, 2023-09-26 at 18:21 +0200, Benoit Lobréau wrote:
> On 9/26/23 16:27, Benoit Lobréau wrote:
> > I will try to come up with a documentation patch.
>
> This is my attempt at a documentation patch.
>
+ If the ownership of a subscription with
password_required=true
+ is transferred t
On Tue, 26 Sept 2023 at 18:38, jacktby jacktby wrote:
>
> typedef bool (*aminsert_function) (Relation indexRelation,
> Datum *values,
> bool *isnull,
> ItemPointer heap_tid,
> Relation heapRelation,
> IndexUniqueCheck checkUnique,
> bool indexUnchanged,
> struct IndexInfo *indexInfo)
On 25/08/2023 07:29, Imseih (AWS), Sami wrote:
diff --git a/src/backend/storage/lmgr/predicate.c
b/src/backend/storage/lmgr/predicate.c
index 1af41213b4..7e7be3b885 100644
--- a/src/backend/storage/lmgr/predicate.c
+++ b/src/backend/storage/lmgr/predicate.c
@@ -992,6 +992,13 @@ SerialSetActiveSe
On 9/26/23 16:27, Benoit Lobréau wrote:
I will try to come up with a documentation patch.
This is my attempt at a documentation patch.
--
Benoit Lobréau
Consultant
http://dalibo.comFrom a73baa91032fff37ef039168c276508553830f86 Mon Sep 17 00:00:00 2001
From: benoit
Date: Tue, 26 Sep 2023 18:07
On 2023-09-26 Tu 01:25, NINGWEI CHEN wrote:
On Fri, 22 Sep 2023 10:12:29 +0900
Michael Paquier wrote:
As of today, I can see that the only buildfarm members relying on
these scripts are bowerbird and hamerkop, so these two would fail if
the patch attached were to be applied today. I am addin
On Tue, Sep 26, 2023 at 8:19 AM Andres Freund wrote:
> However, I'm not at all convinced doing this on a system wide level is a good
> idea. Databases do often contain multiple types of workloads at the same
> time. E.g., we want to freeze aggressively in a database that has the bulk of
> its size
Also a reluctant -1, as the comment-at-EOL style is very rare in my
experience over the years of seeing many a pg_hba file.
Hi,
> >> IMO a test is needed that makes sure no one is going to break this in
> >> the future.
> >
> > You definitely need more complex test scenarios for that. If you can
> > come up with new ways to make the TAP tests of pg_rewind mode modular
> > in handling more complicated node setups, that
Hi,
> This scheme is reused later for the XLogRecord xl_tot_len field over
> at [0], and FWIW is thus being reused. Sure, it's tailored to this WAL
> use case, but IMO we're getting good value from it. We don't use
> protobuf or JSON for WAL, we use our own serialization format. Having
> some spec
On Mon, Sep 25, 2023 at 3:09 PM Nathan Bossart
wrote:
> On Fri, Sep 15, 2023 at 02:36:16PM -0700, Yurii Rashkovskii wrote:
> > On Fri, Sep 15, 2023 at 1:47 PM Nathan Bossart >
> > wrote:
> >> I think another issue is that the aforementioned note doesn't mention
> the
> >> new SET option added in
On Mon, Sep 25, 2023 at 1:56 PM Jeff Davis wrote:
> Do users like Bob do that today? If not, what causes you to expect them
> to do so in the future?
What I would say is that if there's a reasonable way of securing your
stuff and you don't make use of it, that's your problem. If securing
your stu
Hi,
On 2023-09-25 14:16:46 -0700, Peter Geoghegan wrote:
> On Mon, Sep 25, 2023 at 11:45 AM Robert Haas wrote:
> I'm surprised that there hasn't been any discussion of the absolute
> amount of system-wide freeze debt on this thread. If 90% of the pages
> in the entire database are frozen, it'll g
Hi,
> Hmm, I think I like "where" better.
OK.
> Attached is an updated patch set where I have split the changes into
> smaller pieces. The last two patches still have some open questions
> about what certain constants mean etc. The other patches should be settled.
The patches 0001..0005 seem
Hi,
On 2023-09-25 14:45:07 -0400, Robert Haas wrote:
> On Fri, Sep 8, 2023 at 12:07 AM Andres Freund wrote:
> > > Downthread, I proposed using the RedoRecPtr of the latest checkpoint
> > > rather than the LSN of the previou vacuum. I still like that idea.
> >
> > Assuming that "downthread" refere
Hi,
On Tue, 26 Sept 2023 at 13:48, Peter Eisentraut wrote:
>
> On 25.09.23 12:56, Nazir Bilal Yavuz wrote:
> > + # Only run if a specific OS is not requested and if there are changes in
> > docs
> > + # or in the CI files.
> > + skip: >
> > +$CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' |
typedef bool (*aminsert_function) (Relation indexRelation,
Datum
*values,
bool *isnull,
ItemPoint
On 9/22/23 21:58, Robert Haas wrote
I think that there normally shouldn't be any problem here, because if
form->subpasswordrequired is true, we expect that the connection
string should contain a password which the remote side actually uses,
or we expect the subscription to be owned by the superus
On Tue, Sep 26, 2023 at 06:26:25AM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> Hi Mr.Bruce.
> > I think this needs to be explained in the docs. I am ready to adjust the
> > patch to improve the wording whenever you are
> > ready. Should I do it now and post an updated version for you
/* Typedef for callback function for table_index_build_scan */
typedef void (*IndexBuildCallback) (Relation index,
ItemPointer tid,
Datum
*values,
On 9/20/23 20:09, Tomas Vondra wrote:
> On 9/20/23 19:59, Tomas Vondra wrote:
>>
>>
>> On 9/20/23 01:24, Tom Lane wrote:
>>> Tomas Vondra writes:
bsd@freebsd:~ $ tclsh8.6
% clock scan "1/26/2010"
time value too large/small to represent
>>>
>>> In hopes of replicating this, I trie
On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
>
> Here are some comments for patch v2-0001.
>
> ==
> src/backend/replication/logical/worker.c
>
> 1. maybe_reread_subscription
>
> ereport(LOG,
> (errmsg("logical replication worker for subscription \"%s\"
> will restart because of a
> On 26 Sep 2023, at 15:19, Peter Eisentraut wrote:
>
> On 04.09.23 11:54, Jim Jones wrote:
>> This patch proposes the column "comment" to the pg_hba_file_rules view. It
>> basically parses the inline comment (if any) of a valid pg_hba.conf entry
>> and displays it in the new column.
>> For suc
On Tuesday, September 26, 2023 4:40 PM Amit Kapila
wrote:
>
> On Tue, Sep 19, 2023 at 12:48 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > - static bool publish_no_origin;
> >
> > This flag is also local to pgoutput instance, and we didn't reset the
> > flag in output shutdown callback, so if we cons
On Tuesday, September 19, 2023 1:44 PM Michael Paquier
wrote:
>
> On Tue, Sep 19, 2023 at 04:10:39AM +, Zhijie Hou (Fujitsu) wrote:
> > Currently we have serval global variables in pgoutput, but each of
> > them is inherently local to an individual pgoutput instance. This
> > could cause iss
Dear Karl,
Thank you for reviewing! PSA new version.
> I see a few problems with the English and style of the patches
> and am commenting below and have signed up as a reviewer.
Your effort is quite helpful for me.
> At
> commitfest.postgresql.org I have marked the thread
> as needing author at
On 04.09.23 11:54, Jim Jones wrote:
This patch proposes the column "comment" to the pg_hba_file_rules view.
It basically parses the inline comment (if any) of a valid pg_hba.conf
entry and displays it in the new column.
For such pg_hba entries ...
host db jim 127.0.0.1/32 md5 # foo
host db ji
fujii.y...@df.mitsubishielectric.co.jp писал 2023-09-25 06:18:
Hi Mr.Bruce, Mr.Pyhalov, Mr.Finnerty, hackers.
Thank you for your valuable comments. I sincerely apologize for the
very late reply.
Here is a response to your comments or a fix to the patch.
Tuesday, August 8, 2023 at 3:31 Bruce Mom
On Tue, 12 Sept 2023 at 03:03, Bruce Momjian wrote:
>
> On Mon, Sep 11, 2023 at 10:02:55PM +1200, David Rowley wrote:
> > It's certainly not a show-stopper. I do believe the patch makes some
> > improvements. The reason I'd prefer to see either "and" or "and/or"
> > in place of "or" is because th
Hi,
PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.
To support it I have below points:-
1) Grepping this table 'test_prepared_savepoint' shows occurrences
only i
On Mon, Jun 5, 2023 at 1:24 PM Fabrízio de Royes Mello <
fabriziome...@gmail.com> wrote:
>
> On Sat, Jun 3, 2023 at 7:42 PM Fabrízio de Royes Mello <
fabriziome...@gmail.com> wrote:
> >
> >
> > Hi all,
> >
> > During the PGCon Unconference session about Table Access Method one
missing item pointed
On Wed, 27 Sept 2023 at 01:31, Ranier Vilela wrote:
> It seems to me that it adds a LEA instruction.
> https://godbolt.org/z/b4jK3PErE
There's a fairly significant difference in the optimisability of a
comparison with a compile-time constant vs a variable. For example,
would you expect the compil
Em ter., 26 de set. de 2023 às 07:34, Ashutosh Bapat <
ashutosh.bapat@gmail.com> escreveu:
> On Tue, Sep 26, 2023 at 3:32 PM David Rowley wrote:
> >
> > find_base_rel() could be made more robust for free by just casting the
> > relid and simple_rel_array_size to uint32 while checking that rel
On Tue, Sep 5, 2023 at 1:40 PM Melanie Plageman
wrote:
>
> On Wed, Jun 21, 2023 at 8:51 AM James Coleman wrote:
> > While at PGCon I was chatting with Andres (and I think Peter G. and a
> > few others who I can't remember at the moment, apologies) and Andres
> > noted that while we opportunistica
On Tue, Sep 26, 2023 at 10:51 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Again, thank you for reviewing! PSA a new version.
Thanks for the new patch. Here's a comment on v46:
1.
+Datum
+binary_upgrade_validate_wal_logical_end(PG_FUNCTION_ARGS
+{ oid => '8046', descr => 'for use by pg_upgrade',
+ pro
On 25.09.23 12:56, Nazir Bilal Yavuz wrote:
+ # Only run if a specific OS is not requested and if there are changes in docs
+ # or in the CI files.
+ skip: >
+$CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' ||
+!changesInclude('doc/**',
+'.cirrus.yml',
+
On Tue, Sep 26, 2023 at 3:32 PM David Rowley wrote:
>
> find_base_rel() could be made more robust for free by just casting the
> relid and simple_rel_array_size to uint32 while checking that relid <
> root->simple_rel_array_size. The 0th element should be NULL anyway,
> so "if (rel)" should let r
On 09.09.23 21:03, David Steele wrote:
On 9/1/23 11:39, David Steele wrote:
Hackers,
I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c and that led me to use ^static
const.*\*.*=
On Tue, 26 Sept 2023 at 21:45, Ashutosh Bapat
wrote:
> However, I agree that changing find_base_rel() the way you have done
> in your patch is fine and mildly future-proof. +1 to that idea
> irrespective of what bitmapset functions do.
I'm not a fan of adding additional run-time overhead for this
Sorry for the duplicates, I received a letter that my letter did not
reach the addressee, I thought the design was incorrect.
On 26.09.2023 12:21, a.rybakina wrote:
I'm sorry I didn't write for a long time, but I really had a very
difficult month, now I'm fully back to work.
*I was able to
> On 26 Sep 2023, at 10:36, Adrien Nayrat wrote:
> Should Postgres support alternative SSL libraries has HAProxy?
PostgreSQL can be built with LibreSSL instead of OpenSSL, which may or may not
be a better option performance wise for a particular application. Benchmarking
your workload is key to
On Tue, Sep 19, 2023 at 12:48 PM Zhijie Hou (Fujitsu)
wrote:
>
> - static bool publish_no_origin;
>
> This flag is also local to pgoutput instance, and we didn't reset the flag in
> output shutdown callback, so if we consume changes from different slots, then
> the second call would reuse the flag
Hello,
I read this article from Haproxy, they noticed OpenSSL v3 has huge
performance regressions :
https://github.com/haproxy/wiki/wiki/SSL-Libraries-Support-Status#openssl
This is a known issue :
https://github.com/openssl/openssl/issues/17627#issuecomment-1060123659
Unfortunately, v3 is
Here is an improved version of the patch with regression tests.
Yours,
Laurenz Albe
From 71744ada1e2c8cfdbb57e03018572a1af623b09e Mon Sep 17 00:00:00 2001
From: Laurenz Albe
Date: Tue, 26 Sep 2023 10:09:49 +0200
Subject: [PATCH] Evaluate defaults in COPY FROM only if necessary
Since commit 9f837
Hi Daniel,
Thanks for the feedback.
Le mardi 05 septembre 2023 à 11:35 +0200, Daniel Gustafsson a écrit :
> > On 30 Aug 2023, at 14:36, Étienne BERSAC wrote:
>
> > ..what do you think of having logfmt output along json and CSV ?
>
> Less ideal is
> that there is no official formal definition o
Hi all,
(Thomas in CC.)
Now that becfbdd6c1c9 has improved the situation to detect the
difference between out-of-memory and invalid WAL data in WAL, I guess
that it is time to tackle the problem of what we should do when
reading WAL records bit fail on out-of-memory.
To summarize, currently the W
Here are some comments for patch v2-0001.
==
src/backend/replication/logical/worker.c
1. maybe_reread_subscription
ereport(LOG,
(errmsg("logical replication worker for subscription \"%s\"
will restart because of a parameter change",
MySubscription->name)));
Is this r
95 matches
Mail list logo
