Re: Minimal logical decoding on standbys

Hi, New wording works for me, thanks! Bertrand Le sam. 8 avr. 2023, 08:26, Andres Freund a écrit : > Hi, > > On 2023-04-07 11:12:26 -0700, Andres Freund wrote: > > + > > + > > + confl_active_logicalslot > bigint > > + > > + > > + Number of active logical slot

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 11:12:26 -0700, Andres Freund wrote: > + > + > + confl_active_logicalslot > bigint > + > + > + Number of active logical slots in this database that have been > + invalidated because they conflict with recovery (note that inactive > ones

Re: Direct I/O

Hi, On 2023-04-08 16:59:20 +1200, Thomas Munro wrote: > On Sat, Apr 8, 2023 at 4:47 PM Thomas Munro wrote: > > After a bit more copy-editing on docs and comments and a round of > > automated indenting, I have now pushed this. I will now watch the > > build farm. I tested on quite a few OSes tha

Re: CREATE SUBSCRIPTION -- add missing tab-completes

On Fri, Apr 7, 2023 at 6:59 PM Masahiko Sawada wrote: > > On Fri, Apr 7, 2023 at 6:10 PM Amit Kapila wrote: > > > > On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada > > wrote: > > > > > > > Do you mean that because 'password_required' is used each time we make > > a connection to a publisher duri

Re: Non-superuser subscription owners

On Thu, Mar 30, 2023 at 9:35 PM Robert Haas wrote: > > On Tue, Mar 28, 2023 at 1:52 PM Jeff Davis wrote: > > On Fri, 2023-03-24 at 00:17 -0700, Jeff Davis wrote: > > > The other patch you posted seems like it makes a lot of progress in > > > that direction, and I think that should go in first. Th

Re: check_GUC_init(wal_writer_flush_after) fails with non-default block size

Hi, On 2023-04-08 13:18:55 +1200, Thomas Munro wrote: > If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but > 8, this breaks: > > running bootstrap script ... LOG: GUC (PGC_INT) > wal_writer_flush_after, boot_val=256, C-var=128 > TRAP: failed Assert("check_GUC_init(hentry->gucv

Re: Direct I/O

Thomas Munro writes: > I did some testing with non-default block sizes, and found a few minor > things that needed adjustment. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-04-08%2004%3A42%3A04 This seems like another thing that should not have been pushed mere hours befo

Re: Direct I/O

On Sat, Apr 8, 2023 at 4:47 PM Thomas Munro wrote: > After a bit more copy-editing on docs and comments and a round of > automated indenting, I have now pushed this. I will now watch the > build farm. I tested on quite a few OSes that I have access to, but > this is obviously a very OS-sensitive

Re: Direct I/O

I did some testing with non-default block sizes, and found a few minor things that needed adjustment. The short version is that I blocked some configurations that won't work or would break an assertion. After a bit more copy-editing on docs and comments and a round of automated indenting, I have n

Re: Minimal logical decoding on standbys

On Sat, Apr 8, 2023 at 9:31 AM Andres Freund wrote: > > On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: > > The new approach for invalidation looks clean. BTW, I see minor > > inconsistency in the following two error messages (errmsg): > > Thanks for checking. > > > > if (MyReplicationSlot->data.

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > I'm open to considering support for older versions, however ... NetBSD 9.3, which is their *latest production release*, doesn't have gssapi_ext.h [1]. For that matter, it doesn't look like their not-yet-released 10.0BETA does either (my NetBSD 10 animals would be failing

Re: Minimal logical decoding on standbys

On 4/8/23 12:01 AM, Andres Freund wrote: Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: The new approach for invalidation looks clean. BTW, I see minor inconsistency in the following two error messages (errmsg): Thanks for checking. if (MyReplicationSlot->data.invalidated == RS_INVAL

Re: Partial aggregates pushdown

On 2023-04-07 22:53:53 -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > > >> Uh, what? Why would we not be able to tell from the remote server's > > >> version number

Re: Minimal logical decoding on standbys

Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: > The new approach for invalidation looks clean. BTW, I see minor > inconsistency in the following two error messages (errmsg): Thanks for checking. > if (MyReplicationSlot->data.invalidated == RS_INVAL_WAL) > ereport(ERROR, > (errcode(ERRCOD

Re: Minimal logical decoding on standbys

On Fri, Apr 7, 2023 at 11:42 PM Andres Freund wrote: > > On 2023-04-07 08:47:57 -0700, Andres Freund wrote: > > Integrated all of these. > > Here's my current version. Changes: > - Integrated Bertrand's changes > - polished commit messages of 0001-0003 > - edited code comments for 0003, including

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 18:32:04 -0400, Melanie Plageman wrote: > Code review only of 0001-0005. > > I noticed you had two 0008, btw. Yea, sorry for that. One was the older version. Just before sending the patch I saw another occurance of a test failure, which I then fixed. In the course of that I cha

Re: daitch_mokotoff module

I wrote: > Anyway, I assume this is just syntactic sugar for something > we can do another way? If it's at all fundamental, I'll have > to back the patch out. On closer inspection, this script is completely devoid of any need to deal in non-ASCII data at all. So I just nuked the "use" lines.

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Looks like buildfarm animal hake, at least, has a version recent enough > > to have gssapi_ext.h ... but still older than 1.11 and therefore > > doesn't have the type gss_key_value_element_desc defined, so maybe the > >

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 10:53:53PM -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > > >> Uh, what? Why would we not be able to tell from the remote server's > > >> ve

Re: daitch_mokotoff module

Andrew Dunstan writes: > On 2023-04-07 Fr 21:52, Tom Lane wrote: >> pipit appears to be running a reasonably current system (RHEL8), so >> the claim that "open" is a Perl core module appears false. We need >> to rewrite this to not use that. > I think it is a core module (See

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > >> Uh, what? Why would we not be able to tell from the remote server's > >> version number whether it has this ability? > > > The issue is not a misma

Re: daitch_mokotoff module

On 2023-04-07 Fr 21:52, Tom Lane wrote: I wrote: I pushed this after some mostly-cosmetic fiddling. Most of the buildfarm seems okay with it, Spoke too soon [1]: make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch' '/usr/bin/perl' d

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > Looks like buildfarm animal hake, at least, has a version recent enough > to have gssapi_ext.h ... but still older than 1.11 and therefore > doesn't have the type gss_key_value_element_desc defined, so maybe the > check for gss_store_cred_into would be better? Well, now we

Re: Partial aggregates pushdown

Bruce Momjian writes: > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: >> Uh, what? Why would we not be able to tell from the remote server's >> version number whether it has this ability? > The issue is not a mismatch of postgres_fdw versions but the extension > versions and whether

Re: Commitfest 2023-03 starting tomorrow!

On Fri, Apr 7, 2023 at 6:29 PM Tom Lane wrote: > Kirk Wolak writes: > > The %T added to the PSQL Prompt is about 5 lines of code. Reviewed and > > Ready to commit. > > That could knock one more off really quickly :-) > > I'm still objecting to it, for the same reason as before. > >

Re: longfin missing gssapi_ext.h

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Stephen Frost writes: > > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > >> It's whatever Apple is shipping, or was shipping last year or so. > > > > > Sadly they've not been maintaining the Kerbero

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> It's whatever Apple is shipping, or was shipping last year or so. > > > Sadly they've not been maintaining the Kerberos libraries at all on > > their systems. > > Indeed :-(

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > What I don't want is an error-prone setup where administrators have to > > remember what the per-server settings are. Based on your suggestion, > > let's allow CREATE SERVER to have an option 'enable_async_aggre

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> It's whatever Apple is shipping, or was shipping last year or so. > Sadly they've not been maintaining the Kerberos libraries at all on > their systems. Indeed :-(. I wouldn't be surprised if there are security issues in their ve

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Looks like longfin has a particularly old Kerberos/GSSAPI installation > > on it > > It's whatever Apple is shipping, or was shipping last year or so. Sadly they've not been maintaining the Kerberos libraries at all o

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > Looks like longfin has a particularly old Kerberos/GSSAPI installation > on it It's whatever Apple is shipping, or was shipping last year or so. > I'm inclined to update our configure check to explicitly check for the > needed function (gss_store_cred_into) Sounds like a

longfin missing gssapi_ext.h

Greetings, Looks like longfin has a particularly old Kerberos/GSSAPI installation on it which pre-dates MIT release 1.11 from circa 2012 and is missing gssapi_ext.h, causing the recently committed patch to add Kerberos credential delegation to fail to build. I'm inclined to update our configure c

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > * David Christensen (da...@pgguru.net) wrote: > > > Ok, based on the interdiff there, I'm happy with that last change. > > > Marking > > > as Ready For Committer. > > > > Great, thanks! > >

Re: Partial aggregates pushdown

Bruce Momjian writes: > What I don't want is an error-prone setup where administrators have to > remember what the per-server settings are. Based on your suggestion, > let's allow CREATE SERVER to have an option 'enable_async_aggregate' (is > that the right name?), which defaults to 'true' for _a

Re: daitch_mokotoff module

I wrote: > I pushed this after some mostly-cosmetic fiddling. Most of the > buildfarm seems okay with it, Spoke too soon [1]: make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch' '/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 09:25:52AM +, fujii.y...@df.mitsubishielectric.co.jp wrote: > Hi Mr.Momjian > > > First, my apologies for not addressing this sooner. I was so focused on my > > own tasks that I didn't realize this very important patch was not getting > > attention. I will try my bes

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * David Christensen (da...@pgguru.net) wrote: > > Ok, based on the interdiff there, I'm happy with that last change. Marking > > as Ready For Committer. > > Great, thanks! > > I'm going to go through it again myself but I feel reasonably

Re: daitch_mokotoff module

Andres Freund writes: > On 2023-04-07 21:13:43 -0400, Tom Lane wrote: >> I pushed this after some mostly-cosmetic fiddling. Most of the >> buildfarm seems okay with it, but crake's perlcritic run is not: >> >> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at >> line

Re: daitch_mokotoff module

Hi, On 2023-04-07 21:13:43 -0400, Tom Lane wrote: > I wrote: > > That seems fine to me. I'll check this over and see if I can get > > it pushed today. > > I pushed this after some mostly-cosmetic fiddling. Most of the > buildfarm seems okay with it, but crake's perlcritic run is not: > > ./con

check_GUC_init(wal_writer_flush_after) fails with non-default block size

Hi, If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but 8, this breaks: running bootstrap script ... LOG: GUC (PGC_INT) wal_writer_flush_after, boot_val=256, C-var=128 TRAP: failed Assert("check_GUC_init(hentry->gucvar)"), File: "guc.c", Line: 1519, PID: 84605 From 48d971e0b19f

Re: daitch_mokotoff module

I wrote: > That seems fine to me. I'll check this over and see if I can get > it pushed today. I pushed this after some mostly-cosmetic fiddling. Most of the buildfarm seems okay with it, but crake's perlcritic run is not: ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" use

Re: Making background psql nicer to use in tap tests

Andres Freund writes: > On 2023-04-07 20:49:39 -0400, Tom Lane wrote: >> IPC::Run 0.98 is relatively new (2018), so I don't think it'd fly >> to make that our new minimum version across-the-board. I recommend >> just setting up this one test to SKIP if IPC::Run is too old. > Does the test actual

Re: Making background psql nicer to use in tap tests

Hi, On 2023-04-07 20:49:39 -0400, Tom Lane wrote: > I wrote: > > I've been doing some checking with perlbrew locally. It appears to not > > be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but > > not 0.79. Still bisecting to identify exactly what's the minimum > > okay version.

Re: Making background psql nicer to use in tap tests

I wrote: > I've been doing some checking with perlbrew locally. It appears to not > be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but > not 0.79. Still bisecting to identify exactly what's the minimum > okay version. The answer is: it works with IPC::Run >= 0.98. The version

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 17:19:42 -0700, Andres Freund wrote: > I think > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2023-04-07%2021%3A16%3A04 > might point out a problem with the pg_dump or pg_upgrade backward compat > paths: > > --- C:\\prog\\bf/root/upgrade.drongo/HEAD/origin-R

Re: Making background psql nicer to use in tap tests

Andrew Dunstan writes: >> Actually, one quick datapoint. prion and mantid report running IPC::Run >> version 0.92, and morepork 0.96. Animals that pass are running 20180523.0, >> 20200505.0, 20220807.0 or similar versions. We don't print the IO::Pty >> version >> during configure, but maybe th

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 18:26:28 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-04-07 17:46:33 -0400, Tom Lane wrote: > >> After quickly eyeing the diffs, I'm just going to take the new output > >> as good. I'm not surprised that there are additional output messages > >> given the addition

Re: monitoring usage count distribution

On Fri, Apr 07, 2023 at 02:29:31PM -0400, Tom Lane wrote: > I'm not sure if there is consensus for 0002, but I reviewed and pushed > 0001. I made one non-cosmetic change: it no longer skips invalid > buffers. Otherwise, the row for usage count 0 would be pretty useless. > Also it seemed to me tha

Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?

Michael Paquier writes: > On Sat, Apr 08, 2023 at 01:32:22AM +1200, Thomas Munro wrote: >> I'm hoping to get just the regex changes in ASAP, and then take a >> little bit longer on the recovery conflict patch itself (v6-0005) on >> the basis that it's bugfix work and not subject to the feature fre

Re: Track IO times in pg_stat_io

Hi, On 2023-04-07 12:17:38 -0400, Melanie Plageman wrote: > Attached v9 addresses review feedback as well as resolving merge > conflicts with recent relation extension patchset. I've edited it a bit more: - removed pgstat_tracks_io_time() and replaced it by returning the new IO_COL_INVALID = -

Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?

On Sat, Apr 08, 2023 at 01:32:22AM +1200, Thomas Munro wrote: > I'm hoping to get just the regex changes in ASAP, and then take a > little bit longer on the recovery conflict patch itself (v6-0005) on > the basis that it's bugfix work and not subject to the feature freeze. Agreed. It would be goo

Re: Making background psql nicer to use in tap tests

On 2023-04-07 Fr 19:14, Daniel Gustafsson wrote: On 8 Apr 2023, at 00:59, Daniel Gustafsson wrote: On 8 Apr 2023, at 00:35, Tom Lane wrote: Daniel Gustafsson writes: On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote: Staring at this I've been unable to figure out if there an underlying p

Re: Show various offset arrays for heap WAL records

On Fri, Apr 7, 2023 at 4:21 PM Melanie Plageman wrote: > It's come to my attention that I forgot to include the btree patch earlier. Pushed that one too. Also removed the use of the "restrict" keyword here. Thanks -- Peter Geoghegan

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * David Christensen (da...@pgguru.net) wrote: > Ok, based on the interdiff there, I'm happy with that last change. Marking > as Ready For Committer. Great, thanks! I'm going to go through it again myself but I feel reasonably good about it and if nothing else pops and there aren't ob

Re: Disable rdns for Kerberos tests

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Stephen Frost writes: > > > Push, thanks again! > > > > Why'd you only change HEAD? Isn't the test equally fragile in the > > back branches? > > Following on from this after some additional cros

Re: Disable rdns for Kerberos tests

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Push, thanks again! > > Why'd you only change HEAD? Isn't the test equally fragile in the > back branches? Back-patched. Thanks! Stephen signature.asc Description: PGP signature

Re: Show various offset arrays for heap WAL records

On Fri, Apr 7, 2023 at 7:09 PM Peter Geoghegan wrote: > > On Fri, Apr 7, 2023 at 4:01 PM Melanie Plageman > wrote: > > LGTM > > Pushed, thanks. It's come to my attention that I forgot to include the btree patch earlier. PFA From 4f502b2513ba79d738e7ed87aaf7d18ed2a2e30f Mon Sep 17 00:00:00 2001

Re: Making background psql nicer to use in tap tests

> On 8 Apr 2023, at 00:59, Daniel Gustafsson wrote: > >> On 8 Apr 2023, at 00:35, Tom Lane wrote: >> >> Daniel Gustafsson writes: On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote: >>> Staring at this I've been unable to figure out if there an underlying >>> problem >>> here or a flaky t

Re: Show various offset arrays for heap WAL records

On Fri, Apr 7, 2023 at 4:01 PM Melanie Plageman wrote: > LGTM Pushed, thanks. -- Peter Geoghegan

Re: Show various offset arrays for heap WAL records

On Fri, Apr 7, 2023 at 5:43 PM Peter Geoghegan wrote: > > On Fri, Apr 7, 2023 at 1:33 PM Melanie Plageman > wrote: > > Attached v3 is cleaned up and includes a pg_walinspect docs update as > > well as some edited comments in rmgr_utils.c > > Attached v4 has some small tweaks on your v3. Mostly ju

Re: Making background psql nicer to use in tap tests

> On 8 Apr 2023, at 00:35, Tom Lane wrote: > > Daniel Gustafsson writes: >>> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote: >> Staring at this I've been unable to figure out if there an underlying problem >> here or a flaky testrun, since I can't reproduce it. Maybe the animal owner >> (on

Re: cataloguing NOT NULL constraints

... BTW, shouldn't https://commitfest.postgresql.org/42/3869/ now get closed as committed? regards, tom lane

Re: Making background psql nicer to use in tap tests

Daniel Gustafsson writes: >> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote: > Staring at this I've been unable to figure out if there an underlying problem > here or a flaky testrun, since I can't reproduce it. Maybe the animal owner > (on cc) have any insights? > The test has passed on seve

Re: Minimal logical decoding on standbys

Code review only of 0001-0005. I noticed you had two 0008, btw. On Fri, Apr 07, 2023 at 11:12:26AM -0700, Andres Freund wrote: > Hi, > > On 2023-04-07 08:47:57 -0700, Andres Freund wrote: > > Integrated all of these. > > From 0e038eb5dfddec500fbf4625775d1fa508a208f6 Mon Sep 17 00:00:00 2001 > F

Re: Commitfest 2023-03 starting tomorrow!

Kirk Wolak writes: > The %T added to the PSQL Prompt is about 5 lines of code. Reviewed and > Ready to commit. > That could knock one more off really quickly :-) I'm still objecting to it, for the same reason as before. regards, tom lane

Re: cataloguing NOT NULL constraints

Andres Freund writes: > On 2023-04-07 17:46:33 -0400, Tom Lane wrote: >> After quickly eyeing the diffs, I'm just going to take the new output >> as good. I'm not surprised that there are additional output messages >> given the additional catalog entries this made. I *am* a bit surprised >> that

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 17:46:33 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote: > >> Ah, cool, no worries. I would have stopped indeed, but I had to stay > >> around in case of any test failures. > > > Looks like there's work for you if you want

Re: Commitfest 2023-03 starting tomorrow!

On Fri, Apr 7, 2023 at 10:21 AM Greg Stark wrote: > As announced on this list feature freeze is at 00:00 April 8 AoE. > That's less than 24 hours away. If you need to set your watches to AoE > timezone it's currently: > > $ TZ=AOE+12 date > Fri 07 Apr 2023 02:05:50 AM AOE > > As we stand we have:

Re: Making background psql nicer to use in tap tests

> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote: > Looks like morepork wasn't happy with the interactive \password test. > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=morepork&dt=2023-04-07%2020%3A30%3A29 > > Looking into why the timer timed out in that test. Staring at this I

Re: Kerberos delegation support in libpq and postgres_fdw

Ok, based on the interdiff there, I'm happy with that last change. Marking as Ready For Committer. Best, David

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * David Christensen (da...@pgguru.net) wrote: > Reviewed v8; largely looking good, though I notice this hunk, which may > arguably be a bug fix, but doesn't appear to be relevant to this specific > patch, so could probably be debated independently (and if a bug, should > probably be bac

Re: cataloguing NOT NULL constraints

Andres Freund writes: > On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote: >> Ah, cool, no worries. I would have stopped indeed, but I had to stay >> around in case of any test failures. > Looks like there's work for you if you want ;) > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=r

Re: Kerberos delegation support in libpq and postgres_fdw

Reviewed v8; largely looking good, though I notice this hunk, which may arguably be a bug fix, but doesn't appear to be relevant to this specific patch, so could probably be debated independently (and if a bug, should probably be backpatched): diff --git a/contrib/postgres_fdw/option.c b/contrib/p

Re: Show various offset arrays for heap WAL records

On Fri, Apr 7, 2023 at 1:33 PM Melanie Plageman wrote: > Attached v3 is cleaned up and includes a pg_walinspect docs update as > well as some edited comments in rmgr_utils.c Attached v4 has some small tweaks on your v3. Mostly just whitespace tweaks. Two slightly notable tweaks: * I changed the

Re: [PATCH] Allow Postgres to pick an unused port to listen

Hi Andrew, On Fri, Apr 7, 2023, 7:07 p.m. Andrew Dunstan wrote: > > On 2023-03-29 We 07:55, Tom Lane wrote: > > Yurii Rashkovskii writes: > > I would like to suggest a patch against master (although it may be worth > backporting it) that makes it possible to listen on any unused port. > > I th

Re: Minimal logical decoding on standbys

I gave a very quick look at 0001 and 0003. I find no fault with 0001. It was clear back when we added that stuff that invalidated_at was not terribly useful -- I was just too conservative to not have it -- but now that a lot of time has passed and we haven't done anything with it, removing it seem

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 22:54:01 +0200, Drouvot, Bertrand wrote: > That looks good to me Cool. I think I'll push these in a few hours. While this needed more changes than I'd like shortly before the freeze, I think they're largely not in very interesting bits and pieces - and this feature has been in

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote: > On 2023-Apr-07, Andres Freund wrote: > > > I just pushed a fix - sorry, I thought you might have stopped working for > > the > > day and CI finished with the modification a few seconds before your email > > arrived... > > Ah, cool, no wo

Re: cataloguing NOT NULL constraints

On 2023-Apr-07, Andres Freund wrote: > I just pushed a fix - sorry, I thought you might have stopped working for the > day and CI finished with the modification a few seconds before your email > arrived... Ah, cool, no worries. I would have stopped indeed, but I had to stay around in case of any

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 23:00:01 +0200, Alvaro Herrera wrote: > On 2023-Apr-07, Andres Freund wrote: > > > src/test/regress/sql/triggers.sql > > 2127:create table child partition of parent for values in ('AAA'); > > 2266:create table child () inherits (parent); > > 2759:create table child () inherits (

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * David Christensen (da...@pgguru.net) wrote: > On Wed, Apr 5, 2023 at 3:30 PM Stephen Frost wrote: > > Per GSS docs, seems like we should be comparing to GSS_C_NO_CREDENTIAL > > and validating that the gflags has the `deleg_flag` bit set before > > considering whether there are valid

Re: Making background psql nicer to use in tap tests

> On 7 Apr 2023, at 22:24, Daniel Gustafsson wrote: > >> On 7 Apr 2023, at 18:14, Daniel Gustafsson wrote: >>> On 7 Apr 2023, at 17:04, Andres Freund wrote: > >>> Afaict the failures are purely about patch 2, not 1, right? >> >> Correct. The attached v6 wraps the interactive_psql test in a S

Re: cataloguing NOT NULL constraints

On 2023-Apr-07, Andres Freund wrote: > src/test/regress/sql/triggers.sql > 2127:create table child partition of parent for values in ('AAA'); > 2266:create table child () inherits (parent); > 2759:create table child () inherits (parent); > > The inherit.sql part is new. Yeah. > I'll see how har

Re: Minimal logical decoding on standbys

Hi, On 4/7/23 8:24 PM, Drouvot, Bertrand wrote: Hi, On 4/7/23 5:47 PM, Andres Freund wrote: Hi, - write a test that invalidated logical slots do not lead to retaining WAL I'm not sure how to do that since pg_switch_wal() and friends can't be executed on a standby. You can do it on the p

Re: Minimal logical decoding on standbys

Hi, On 4/7/23 8:27 PM, Drouvot, Bertrand wrote: Hi, I think some of the patches might have more reviewers than really applicable, and might also miss some. I'd appreciate if you could go over that... Sure, will do in a couple of hours. That looks good to me, just few remarks: 0005 is

Re: cataloguing NOT NULL constraints

Hi, On 2023-04-07 13:38:43 -0700, Andres Freund wrote: > I suspect there's a naming conflict between tests in different groups. Yep: test: create_aggregate create_function_sql create_cast constraints triggers select inherit typed_table vacuum drop_if_exists updatable_views roleattributes creat

Re: cataloguing NOT NULL constraints

Hi, I think there's some test instability: Fail: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=parula&dt=2023-04-07%2018%3A43%3A02 Subsequent success, without relevant changes: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=parula&dt=2023-04-07%2020%3A22%3A01 Followed by a fail

Re: Show various offset arrays for heap WAL records

Attached v3 is cleaned up and includes a pg_walinspect docs update as well as some edited comments in rmgr_utils.c On Mon, Mar 27, 2023 at 6:27 PM Peter Geoghegan wrote: > > On Mon, Mar 27, 2023 at 2:29 PM Melanie Plageman > wrote: > > I went to add dedup records and noticed that since the actua

Re: Making background psql nicer to use in tap tests

> On 7 Apr 2023, at 18:14, Daniel Gustafsson wrote: >> On 7 Apr 2023, at 17:04, Andres Freund wrote: >> Afaict the failures are purely about patch 2, not 1, right? > > Correct. The attached v6 wraps the interactive_psql test in a SKIP block with > a conditional on IO::Pty being available. Thi

Re: Add index scan progress to pg_stat_progress_vacuum

> The arguments of pgstat_progress_update_param() would be given by the > worker directly as components of the 'P' message. It seems to me that > this approach would have the simplicity to not require the setup of a > shmem area for the extra counters, and there would be no need for a > callback. H

Re: Add index scan progress to pg_stat_progress_vacuum

Hi, On 2023-04-06 12:28:04 +0900, Michael Paquier wrote: > As some say, the introduction of a new message type in pqmq.c would be > basically a one-way door, because we'd have to maintain it in a stable > branch. Why would it mean that? Parallel workers are updated together with the leader, so th

Re: daitch_mokotoff module

Tomas Vondra writes: > Hi, I think from the technical point of view it's sound and ready for > commit. The patch stalled on the copyright/credit stuff, which is > somewhat separate and mostly non-technical aspect of patches. Sorry for > that, I'm sure it's annoying/frustrating :-( > I see the cur

Re: monitoring usage count distribution

Nathan Bossart writes: > On Thu, Apr 06, 2023 at 01:32:35PM -0400, Tom Lane wrote: >> There seems to be enough support for the existing summary function >> definition to leave it as-is; Andres likes it for one, and I'm not >> excited about trying to persuade him he's wrong. But a second >> slight

Re: Minimal logical decoding on standbys

Hi, On 4/7/23 8:12 PM, Andres Freund wrote: Hi, On 2023-04-07 08:47:57 -0700, Andres Freund wrote: Integrated all of these. Here's my current version. Changes: - Integrated Bertrand's changes - polished commit messages of 0001-0003 - edited code comments for 0003, including InvalidateObso

Re: Minimal logical decoding on standbys

Hi, On 4/7/23 5:47 PM, Andres Freund wrote: Hi, - write a test that invalidated logical slots do not lead to retaining WAL I'm not sure how to do that since pg_switch_wal() and friends can't be executed on a standby. You can do it on the primary and wait for the records to have been appli

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 08:47:57 -0700, Andres Freund wrote: > Integrated all of these. Here's my current version. Changes: - Integrated Bertrand's changes - polished commit messages of 0001-0003 - edited code comments for 0003, including InvalidateObsoleteReplicationSlots()'s header - added a bump o

Unnecessary confirm work on logical replication

I was reading the logical replication code and found a little unnecessary work we are doing. The confirmed_flushed_lsn cannot reasonably be ahead of the current_lsn, so there is no point of calling LogicalConfirmReceivedLocation() every time we update the candidate xmin or restart_lsn. Patch is a

Re: Fix the description of GUC "max_locks_per_transaction" and "max_pred_locks_per_transaction" in guc_table.c

"wangw.f...@fujitsu.com" writes: > On Tues, Apr 4, 2023 at 23:48 PM Tom Lane wrote: >> I like the "per eligible process" wording, at least for guc_tables.c; >> or maybe it could be "per server process"? That would be more >> accurate and not much longer than what we have now. > Thanks both for

Re: Track IO times in pg_stat_io

Attached v9 addresses review feedback as well as resolving merge conflicts with recent relation extension patchset. I've changed pgstat_count_io_op_time() to take a count and call pgstat_count_io_op_n() so it can be used with smgrzeroextend(). I do wish that the parameter to pgstat_count_io_op_n()

Re: Making background psql nicer to use in tap tests

> On 7 Apr 2023, at 17:04, Andres Freund wrote: > Afaict the failures are purely about patch 2, not 1, right? Correct. The attached v6 wraps the interactive_psql test in a SKIP block with a conditional on IO::Pty being available. -- Daniel Gustafsson v6-0002-Test-SCRAM-iteration-changes-wit

  1   2   >