Greetings,

* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost <sfr...@snowman.net> writes:
> > * Tom Lane (t...@sss.pgh.pa.us) wrote:
> >> It's whatever Apple is shipping, or was shipping last year or so.
> 
> > Sadly they've not been maintaining the Kerberos libraries at all on
> > their systems.
> 
> Indeed :-(.  I wouldn't be surprised if there are security issues in
> their version.  Perhaps what we really ought to do is refuse to build
> with their version --- but if so, we need some clearer error message
> about it.

The attached should (I believe?) at least add the needed check for
gssapi_ext.h which will cause builds to fail and complain about the
header being missing from their installation.

I'm certainly open to ideas about how to provide a better error message,
particularly on OSX systems which have an ancient version, to make it
clear that people need to install an updated version.  I don't have an
OSX system at hand though.

Should I push this to at least address the header check ... ?

Thanks,

Stephen
diff --git a/configure.ac b/configure.ac
index 8095dfcf1d..2bdb3dc3ed 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1562,6 +1562,7 @@ fi
 if test "$with_gssapi" = yes ; then
   AC_CHECK_HEADERS(gssapi/gssapi.h, [],
 	[AC_CHECK_HEADERS(gssapi.h, [], [AC_MSG_ERROR([gssapi.h header file is required for GSSAPI])])])
+	[AC_CHECK_HEADERS(gssapi_ext.h, [], [AC_MSG_ERROR([gssapi_ext.h header file is required for GSSAPI])])])
 fi
 
 PGAC_PATH_PROGS(OPENSSL, openssl)

Attachment: signature.asc
Description: PGP signature

Reply via email to