so 11. 2. 2023 v 7:53 odesílatel Justin Pryzby
napsal:
> On Sat, Feb 11, 2023 at 07:06:45AM +0100, Pavel Stehule wrote:
> > pá 10. 2. 2023 v 23:01 odesílatel Justin Pryzby
> napsal:
> > > On Fri, Feb 10, 2023 at 09:23:11PM +0100, Pavel Stehule wrote:
> > > > pá 10. 2. 2023 v 21:18 odesílatel And
Hi,
On 2023-02-11 00:53:48 -0600, Justin Pryzby wrote:
> On Sat, Feb 11, 2023 at 07:06:45AM +0100, Pavel Stehule wrote:
> > pá 10. 2. 2023 v 23:01 odesílatel Justin Pryzby
> > napsal:
> > > On Fri, Feb 10, 2023 at 09:23:11PM +0100, Pavel Stehule wrote:
> > > > pá 10. 2. 2023 v 21:18 odesílatel A
On Sat, Feb 11, 2023 at 07:06:45AM +0100, Pavel Stehule wrote:
> pá 10. 2. 2023 v 23:01 odesílatel Justin Pryzby napsal:
> > On Fri, Feb 10, 2023 at 09:23:11PM +0100, Pavel Stehule wrote:
> > > pá 10. 2. 2023 v 21:18 odesílatel Andres Freund
> > > napsal:
> > > > On 2023-02-10 21:09:06 +0100, Pa
pá 10. 2. 2023 v 23:01 odesílatel Justin Pryzby
napsal:
> On Fri, Feb 10, 2023 at 09:23:11PM +0100, Pavel Stehule wrote:
> > pá 10. 2. 2023 v 21:18 odesílatel Andres Freund
> napsal:
> > >
> > > On 2023-02-10 21:09:06 +0100, Pavel Stehule wrote:
> > > > Just a small note - I executed VACUUM ANAL
Hi
On Saturday, February 11, 2023 11:10 AM Andres Freund
wrote:
> On 2023-02-10 11:26:21 +, Takamichi Osumi (Fujitsu) wrote:
> > Subject: [PATCH v34] Time-delayed logical replication subscriber
> >
> > Similar to physical replication, a time-delayed copy of the data for
> > logical replicat
I didn't get any closer to radix-tree regression, but I did find some
inefficiencies in tidstore_add_tids() that are worth talking about first,
addressed in a rough fashion in the attached .txt addendums that I can
clean up and incorporate later.
To start, I can reproduce the regression with this
On Fri, Feb 10, 2023 at 12:54 PM Jeff Davis wrote:
> In our tests you can see colstrength=primary is used to mean "case
> insensitive". That's where I picked up the "colstrength" keyword, which
> is also present in the ICU sources, but now that you ask I'm embarassed
> that I don't see the keyword
Hi,
On 2023-02-09 10:28:36 +0100, Dag Lem wrote:
> I'll ask again, would the proposed credits be acceptable? In this case,
> the code already existed elsewhere (as in your example for double
> metaphone) as a separate extension. The copyright owner is OK with
> copyright assignment, however I find
On Fri, Feb 10, 2023 at 5:14 PM Andres Freund wrote:
>
> Perhaps we should name the function something like
> gen_time_ordered_random_uuid() instead? That gives us a bit more flexibility
> about what uuid version we generate. And it might be easier for users, anyway.
I think users would be happy
Hi,
On 2023-02-10 11:26:21 +, Takamichi Osumi (Fujitsu) wrote:
> Subject: [PATCH v34] Time-delayed logical replication subscriber
>
> Similar to physical replication, a time-delayed copy of the data for
> logical replication is useful for some scenarios (particularly to fix
> errors that migh
Hi,
On 2023-02-10 16:17:00 -0800, Jeff Davis wrote:
> One CI test is failing: "Windows - Server 2019, VS 2019 - Meson &
> ninja"; if I apply Andres patch (
> https://github.com/anarazel/postgres/commit/dde7c68 ), then it works.
Until something like my patch above is done more generally applicable
Andres Freund writes:
> On 2023-02-10 15:57:50 -0800, Andrey Borodin wrote:
>> From my POV v7 is especially needed for users. Current standard status
>> is "draft". And I'm not sure it will be accepted before our feature
>> freeze for PG16. Maybe we could provide a draft implementation in 16
>> an
Hi,
On 2023-02-10 15:57:50 -0800, Andrey Borodin wrote:
> As you may know there's a new version of UUID being standardized [0].
> These new algorithms of UUID generation are very promising for
> database performance.
I agree it's very useful to have.
> [0]
> https://datatracker.ietf.org/doc/ht
On Wed, 2023-02-08 at 18:22 -0800, Andres Freund wrote:
> On 2023-02-08 12:16:46 -0800, Jeff Davis wrote:
> > On Thu, 2023-02-02 at 18:10 -0500, Tom Lane wrote:
> > > Yeah. I would be resistant to making ICU a required dependency,
> > > but it doesn't seem unreasonable to start moving towards it b
Hello pgsql-hackers!
As you may know there's a new version of UUID being standardized [0].
These new algorithms of UUID generation are very promising for
database performance. It keeps data locality for time-ordered values.
>From my POV v7 is especially needed for users. Current standard status
is
On Wed, Feb 8, 2023 at 11:13 PM Tom Lane wrote:
>
> Bharath Rupireddy writes:
> > Thanks a lot Robert for taking care of this. The patch is committed on
> > HEAD and reverted on v15. Now that the minor version branches are
> > stamped, is it time for us to get this to v15? I can then close the CF
On Fri, Feb 10, 2023 at 2:08 PM David Zhang wrote:
>
> I noticed the document psql-ref.sgml has been updated for both `du+` and
> `dg+`, but only `du` and `\du+` are covered in regression test. Is that
> because `dg+` is treated exactly the same as `du+` from testing point of
> view?
>
Yes.
>
>
On Fri, Feb 10, 2023 at 09:23:11PM +0100, Pavel Stehule wrote:
> pá 10. 2. 2023 v 21:18 odesílatel Andres Freund napsal:
> >
> > On 2023-02-10 21:09:06 +0100, Pavel Stehule wrote:
> > > Just a small note - I executed VACUUM ANALYZE on one customer's database,
> > > and I had to cancel it after a f
Hi,
On 2023-02-09 11:38:18 +0100, Drouvot, Bertrand wrote:
> Please find attached a patch proposal for $SUBJECT.
>
> The idea has been raised in [1] by Andres: it would allow to simplify even
> more the work done to
> generate pg_stat_get_xact*() functions with Macros.
Thanks!
I think this is
Michael Paquier writes:
> Okay, understood. Following this string of thoughts, I am a bit
> surprised for two cases, though:
> - PartitionPruneStep.
> - Plan.
> Both are abstract and both are marked with no_equal. I guess that
> applying no_query_jumble to both of them is fine, and that's what y
Hi,
Replying on the new thread. Original message at
https://www.postgresql.org/message-id/CAA4eK1%2BH2m95HhzfpRkwv2-GtFwtbcVp7837X49%2Bvs0RXX3dBA%40mail.gmail.com
On 2023-02-09 15:54:19 +0530, Amit Kapila wrote:
> One thing to note about the changes we are discussing here is that
> some of the p
On Fri, Feb 10, 2023 at 11:05:55AM -0800, Jeff Davis wrote:
> Right now, it says that the default locale_provider is libc; but
> actually it's the same as the template from which the database is
> created.
>
> Doc patch attached.
>
> I also adjusted the wording of both CREATE DATABASE and CREATE
Thanks a lot for the improvement, and it will definitely help provide
more very useful information.
I noticed the document psql-ref.sgml has been updated for both `du+` and
`dg+`, but only `du` and `\du+` are covered in regression test. Is that
because `dg+` is treated exactly the same as `du+
Hi,
This is a reply to:
https://www.postgresql.org/message-id/CAA4eK1%2BDB66cYRRVyGcaMm7%2BtQ_u%3Dq%3D%2BHWGjpu9X0pqMFWbsZQ%40mail.gmail.com
split off, so patches to address some of my concerns don't confuse cfbot.
On 2023-02-09 11:21:41 +0530, Amit Kapila wrote:
> On Thu, Feb 9, 2023 at 1:33 AM
Outer-join removal does this:
/*
* Mark the rel as "dead" to show it is no longer part of the join tree.
* (Removing it from the baserel array altogether seems too risky.)
*/
rel->reloptkind = RELOPT_DEADREL;
which apparently I thought was a good idea in 2010 (cf b78f6264e)
pá 10. 2. 2023 v 21:18 odesílatel Andres Freund napsal:
> Hi,
>
> On 2023-02-10 21:09:06 +0100, Pavel Stehule wrote:
> > Just a small note - I executed VACUUM ANALYZE on one customer's database,
> > and I had to cancel it after a few hours, because it had more than 20GB
> RAM
> > (almost all phys
Hi,
On 2023-02-10 21:09:06 +0100, Pavel Stehule wrote:
> Just a small note - I executed VACUUM ANALYZE on one customer's database,
> and I had to cancel it after a few hours, because it had more than 20GB RAM
> (almost all physical RAM).
Just to make sure: You're certain this was an actual memory
: Andres Freund
References:
<20230210.113242.699878230551547182.horikyota@gmail.com>
<5420b28c-d33f-d25d-9f47-b06b8a237...@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5420b28c-d33f-d25d-9f47-b06b8a237...@gmail.com>
Hi,
Hi
Just a small note - I executed VACUUM ANALYZE on one customer's database,
and I had to cancel it after a few hours, because it had more than 20GB RAM
(almost all physical RAM). The memory leak is probably not too big. This
database is a little bit unusual. This one database has more than 1 800
Hi,
On 2023-02-10 21:22:14 +0300, Nikita Malakhov wrote:
> If I understand Andres' message correctly - the proposition is to
> make use of compression dictionaries automatic, possibly just setting
> a parameter when the table is created, something like
> CREATE TABLE t ( ..., t JSONB USE DICTIONAR
On Fri, Feb 10, 2023 at 10:51:20AM -0800, Nathan Bossart wrote:
> On Fri, Feb 10, 2023 at 10:18:34AM -0500, Tom Lane wrote:
>> Robert Haas writes:
>>> I wonder if we should have a wrapper around WaitLatch() that documents
>>> that if the latch is set before the time expires, it will reset the
>>>
On Fri, Feb 10, 2023 at 7:16 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 19.12.22 07:13, Peter Eisentraut wrote:
> > Also, the argument type of appendBinaryStringInfo() is char *. There is
> > some code that uses this function to assemble some kind of packed binary
> > la
Right now, it says that the default locale_provider is libc; but
actually it's the same as the template from which the database is
created.
Doc patch attached.
I also adjusted the wording of both CREATE DATABASE and CREATE
COLLATION to be more definite that there are two providers.
--
Jeff Davi
On Fri, Feb 10, 2023 at 10:18:34AM -0500, Tom Lane wrote:
> Robert Haas writes:
>> I wonder if we should have a wrapper around WaitLatch() that documents
>> that if the latch is set before the time expires, it will reset the
>> latch and try again to wait for the remaining time, after checking for
Richard Guo writes:
> However, for 'above_sjinfo' case, we should not use
> othersj->syn_righthand, because othersj->syn_righthand contains relids
> in sjinfo's righthand which should not be nulled by othersj after the
> commutation. It seems what we should use here is sjinfo->syn_lefthand.
I h
Hi!
If I understand Andres' message correctly - the proposition is to
make use of compression dictionaries automatic, possibly just setting
a parameter when the table is created, something like
CREATE TABLE t ( ..., t JSONB USE DICTIONARY);
The question is then how to create such dictionaries auto
On Fri, 2023-02-10 at 09:43 -0500, Robert Haas wrote:
> On Thu, Feb 9, 2023 at 5:09 PM Jeff Davis wrote:
> > I do like the ICU format locale IDs from a readability standpoint.
> > "en_US@colstrength=primary" is more meaningful to me than "en-US-u-
> > ks-
> > level1" (the equivalent language tag).
I'll continue reviewing this, but here's some feedback on the first two
patches:
v2-0001-aio-Add-some-error-checking-around-pinning.patch:
I wonder if the extra assertion in LockBufHdr() is worth the overhead.
It won't add anything without assertions, of course, but still. No
objections if yo
On Fri, 10 Feb 2023 at 21:50, vignesh C wrote:
> The attached v68 version patch has the changes for the same.
I was not sure if we should support ddl replication of
create/alter/drop subscription commands as there might be some data
inconsistency issues in the following cases:
#node1 who is runni
On Fri, Feb 10, 2023 at 6:16 AM Andres Freund wrote:
>
> That's true for buffers_fsync_backend, but not true for
> buffers_backend/buffers_written_backend.
>
> That isn't tied to checkpointer.
>
> I think if we end up breaking compat, we should just drop that column. The
> pg_stat_io patch from Me
On Tue, 7 Feb 2023 at 17:35, vignesh C wrote:
>
> On Mon, 6 Feb 2023 at 17:02, vignesh C wrote:
> >
> > On Mon, 6 Feb 2023 at 06:47, Peter Smith wrote:
> > >
> > > Here are some comments for patch v63-0002.
> > >
> > > This is a WIP because I have not yet looked at the large file -
> > > ddl_de
On Fri, 2023-02-10 at 07:42 +0100, Peter Eisentraut wrote:
> It turns out that 'de_AT' is actually a distinct collation from 'de'
> in
> CLDR, so that was not the best example. What behavior do you see for
> 'de_CH'?
The canonicalized form is de_CH and the bcp47 tag is de-CH.
uloc_canonicalize(
Hi,
On 2/10/23 3:32 AM, Kyotaro Horiguchi wrote:
At Thu, 9 Feb 2023 11:38:18 +0100, "Drouvot, Bertrand"
wrote in
Hi hackers,
Please find attached a patch proposal for $SUBJECT.
The idea has been raised in [1] by Andres: it would allow to simplify
even more the work done to
generate pg_stat_
On 2023-02-09 Th 15:25, David Rowley wrote:
On Thu, 9 Feb 2023 at 21:20, John Naylor wrote:
Looks good at a glance, just found a spurious word:
+ "by forcing the planner into to generate plans which contains nodes "
Thanks for looking. I'll fix that.
Likely the hardest part to get right her
On 2023-02-10 Fr 04:25, Jelte Fennema wrote:
Ah yes, I had seen that when I read the initial --commit patch but
then forgot about it when the flag didn't work at all when I tried it.
Attached is a patch that fixes the issue. And also implements the
--dirty and --staged flags in pgindent that Ro
Robert Haas writes:
> I somehow feel that we should be trying to get rid of cases where
> WaitLatch is not desired.
+1
> I wonder if we should have a wrapper around WaitLatch() that documents
> that if the latch is set before the time expires, it will reset the
> latch and try again to wait for
On Fri, Feb 10, 2023 at 3:30 AM Alvaro Herrera wrote:
> Maybe for these cases where a WaitLatch is not desired, it'd be simpler
> to do pg_usleep (5L * 1000 * 1000);
I somehow feel that we should be trying to get rid of cases where
WaitLatch is not desired.
That's probably overly simplistic - th
Hi,
On Thu, Feb 9, 2023 at 6:55 PM Ajin Cherian wrote:
>
(v67)
I have some questions about adding the infrastructure for DDL deparsing.
Apart from the changes made by 0001 patch to add infrastructure for
DDL deparsing, 0002 patch seems to add some variables that are not
used in 0002 patch:
@@
On Thu, Feb 9, 2023 at 5:09 PM Jeff Davis wrote:
> I do like the ICU format locale IDs from a readability standpoint.
> "en_US@colstrength=primary" is more meaningful to me than "en-US-u-ks-
> level1" (the equivalent language tag).
Sadly, neither of those means a whole lot to me? :-(
How did you
On 2023-02-07 Tu 11:32, Jelte Fennema wrote:
On Tue, 7 Feb 2023 at 17:11, Robert Haas wrote:
I don't know if that works or not, but it does seem plausible, at
least. My idea would have been to use the --name-status option, which
works for both git diff and git show. You just look and see which
On Fri, Feb 10, 2023 at 1:24 AM Andres Freund wrote:
> pgstat: Track more detailed relation IO statistics
I assume there's more commits coming here, but for the record, the
previous patch introduced a reference to pg_stat_io in the
documentation, but just a brief reference and not full details. T
Dear Amit,
> Can't we have this option just as a bool (like shutdown_immediate)?
> Why do we want to keep multiple modes?
Of course we can use boolean instead, but current style is motivated by the
post[1].
This allows to add another option in future, whereas I do not have idea now.
I want to a
OK, I've updated the PR with a benchmark (in the main directory).
On this benchmark I'm seeing about a 24% reduction in "user" CPU time, and
a 8% reduction in "system" CPU time. (Almost no reduction in wall-clock
time.)
Jeroen
On Fri, 10 Feb 2023 at 11:32, Jeroen Vermeulen wrote:
> Here's th
On 19.12.22 07:13, Peter Eisentraut wrote:
Also, the argument type of appendBinaryStringInfo() is char *. There is
some code that uses this function to assemble some kind of packed binary
layout, which requires a bunch of casts because of this. I think
functions taking binary data plus length
On Fri, Feb 10, 2023 at 5:24 PM Hayato Kuroda (Fujitsu)
wrote:
>
Can't we have this option just as a bool (like shutdown_immediate)?
Why do we want to keep multiple modes?
--
With Regards,
Amit Kapila.
Here's the patch (as a PR just to make it easy to read):
https://github.com/jtv/postgres/pull/1
I don't have an easily readable benchmark yet, since I've been timing the
potential impact on libpqxx. But can do that next.
Jeroen
On Fri, Feb 10, 2023, 11:26 Bharath Rupireddy <
bharath.rupireddyf
Hi,
On Friday, February 10, 2023 2:05 PM Friday, February 10, 2023 2:05 PM wrote:
> On Fri, Feb 10, 2023 at 10:11 AM Amit Kapila
> wrote:
> >
> > On Fri, Feb 10, 2023 at 6:27 AM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Thu, 9 Feb 2023 13:48:52 +0530, Amit Kapila
> > > wrote in
> > > > On Thu
On Thu, Feb 9, 2023 at 3:25 PM Ajin Cherian wrote:
>
Comments on 0001 and 0002
===
1.
* CREATE COLLATION
*/
ObjectAddress
-DefineCollation(ParseState *pstate, List *names, List *parameters,
bool if_not_exists)
+DefineCollation(ParseState *pstate, List *names, List *parame
On Fri, Feb 10, 2023 at 3:43 PM Jeroen Vermeulen wrote:
>
> Would there be interest in a variant of PQgetCopyData() that re-uses the same
> buffer for a new row, rather than allocating a new buffer on each iteration?
>
> I tried it on a toy benchmark, and it reduced client-side CPU time by about
Would there be interest in a variant of PQgetCopyData() that re-uses the
same buffer for a new row, rather than allocating a new buffer on each
iteration?
I tried it on a toy benchmark, and it reduced client-side CPU time by about
12%. (Less of a difference in wall-clock time of course; the clien
Ah yes, I had seen that when I read the initial --commit patch but
then forgot about it when the flag didn't work at all when I tried it.
Attached is a patch that fixes the issue. And also implements the
--dirty and --staged flags in pgindent that Robert Haas requested.
On Fri, 10 Feb 2023 at 03:
On 2023-Feb-09, Nathan Bossart wrote:
> I just found myself carefully counting the zeros in a call to pg_usleep().
> Besides getting my eyes checked, perhaps there should be a wrapper called
> pg_ssleep() than can be used for multisecond sleeps. Or maybe the
> USECS_PER_SEC macro should be used m
On Fri, Feb 10, 2023 at 11:08 AM Richard Guo wrote:
> On Thu, Feb 9, 2023 at 11:55 PM Tom Lane wrote:
>
>> Richard Guo writes:
>> > This query would trigger the Assert() in search_indexed_tlist_for_var.
>> > So I wonder that we should use othersj->syn_righthand here.
>>
>> There are two such ca
On 10.02.23 02:10, Peter Smith wrote:
On Thu, Feb 9, 2023 at 7:17 PM Jim Jones wrote:
1.
FYI, there are some whitespace warnings applying the v5 patch
Trailing whitespaces removed. The patch applies now without warnings.
==
src/test/regress/sql/xml.sql
2.
The v5 patch was already testing
64 matches
Mail list logo
